signal-bot/fake_signal/routes_api.py
Krzysztof kuhy Rudnicki aefffb2fd9
Some checks are pending
CI / check (push) Waiting to run
feat: add a photo to the album from the chat, tagged, stripped and verified
Send a photo captioned "!add_photo alfa wakacje" in one of the album's own
groups and it lands in the pack tagged with both, retrievable through !alfa
and the new !losowe immediately -- no restart, and no tagger session on the PC.
A label matching nobody becomes a custom tag, and !losowe is the only door to
one, which is what keeps a live swap a *data* swap: it can never register a
trigger or widen a command's groups.

No typed label travels. Labels become pseudonym keys in a new registry
arg_resolver, at the dispatcher, before the line that logs the command name --
so no handler, journal entry, command_uses row or reply body ever holds a word
somebody typed. The reply is counts and pseudonyms: "dodano · p1: 4 · t1: 1".

Stripping is exiftool with a *positive* check on the output, never an exit
code. ffmpeg was tried first and fails silently on photos: given a JPEG with a
real APP1 Exif segment it returned a byte-identical file, GPS intact, exit 0.
The surviving-tag allowlist is per tag *name* rather than per group, because
measurement showed a group-level "must be empty" rule rejects every format
except JPEG -- a valid PNG always reports its IHDR, an MP4 some fifty QuickTime
tags that are the container itself. Codec configuration (CompressorName,
VendorID, the HEVC parameter set) is on the list by decision: CompressorName
lives in the avc1 sample description and exiftool cannot write it at all, so
the alternative was refusing every video and every iPhone HEIC. Location and
identity tags are still refused, and the e2e run re-reads the stored files to
prove a QuickTime geotag did not survive.

.webm and .svg stay on the format allowlist and are stored *unstripped*:
exiftool 13.55 can write neither, and its SVG reader does not even surface
<metadata>. That is a deliberate, documented hole, not an oversight.

Two things this had to defuse along the way:
- personal_data_sources now reads custom.json, so "!add_photo kot <photo>"
  would have outlawed the word "kot" and refused every future commit, fixable
  only by hand-editing an album the committer cannot see. Minting now refuses
  a word that is already a command, and the gate subtracts the repo's own
  alias vocabulary from custom labels only -- curated people.json names are
  never excused.
- signal_bot/external.py is now the single subprocess site in the repository,
  so ruff's S603 needs exactly one scoped per-file-ignore instead of one per
  module that shells out. A test asserts nothing else imports subprocess.

A failed add changes nothing: media and the three manifests are written, the
album is reloaded, and only a load that succeeds is published; a load that
fails rolls all four back and keeps serving the pack that was already working,
without raising -- Restart=always would turn a ConfigError into a loop.

977 tests, 100% branch coverage, no omits and no suppressions. scripts/e2e.sh
gains 8 scenarios driven against the real exiftool on media generated at run
time, and asserts the invariants a reply cannot: that a refused upload is not
stored, that a message with no attachment leaves custom.json byte-identical,
and that signal-cli's own copy of every ingested attachment is gone.

Closes TODO-add-photo.md.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JqqE22jp94B1ypwxppdr1o
2026-08-31 11:20:00 +02:00

117 lines
4.4 KiB
Python

# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
"""The endpoints the real signal-cli-rest-api exposes."""
from __future__ import annotations
from typing import Any
from fastapi import APIRouter, Request, WebSocket, WebSocketDisconnect
from fastapi.responses import JSONResponse, Response
from fake_signal.state import PIXEL_PNG, State
def _state(request: Request) -> State:
"""Return the State attached to the running app."""
state: State = request.app.state.fake
return state
def build_api_router() -> APIRouter:
"""Build the router mirroring the real container's API."""
router = APIRouter()
@router.get("/v1/about")
async def about(request: Request) -> dict[str, Any]:
return {"build": 2, "mode": _state(request).mode, "versions": ["v1", "v2"]}
@router.get("/v1/qrcodelink")
async def qrcodelink(device_name: str = "signal-api") -> Response:
# The real endpoint returns a PNG, which is why the live runbook has
# to open an image rather than print a string.
return Response(
content=PIXEL_PNG,
media_type="image/png",
headers={"X-Device-Name": device_name},
)
@router.get("/v1/devices/{number}")
async def devices(request: Request, number: str) -> JSONResponse:
"""The endpoint the deafness gate probes.
Answers from Signal, never from local state, which is exactly why
the bot uses it to tell "quiet" apart from "deaf".
"""
state = _state(request)
if number not in state.accounts:
return JSONResponse({"error": f"{number} is not registered"}, status_code=400)
if not state.connection_alive:
return JSONResponse(
{"error": "Failed to get linked devices: Closed unexpectedly"},
status_code=400,
)
return JSONResponse([{"id": 1, "name": "", "created": 0, "last_seen": 0}])
@router.post("/v2/send")
async def send(request: Request, payload: dict[str, Any]) -> JSONResponse:
_state(request).record_send(payload)
return JSONResponse({"timestamp": 1719177917717}, status_code=201)
_add_attachment_routes(router)
_add_receive_route(router)
return router
def _add_attachment_routes(router: APIRouter) -> None:
"""Attach the attachment store's three endpoints.
Split out so the router builder stays under the complexity cap, exactly
as _add_receive_route already is.
"""
@router.get("/v1/attachments")
async def list_attachments(request: Request) -> list[str]:
return list(_state(request).attachments)
@router.get("/v1/attachments/{attachment_id}")
async def fetch_attachment(request: Request, attachment_id: str) -> Response:
"""Hand over one stored attachment, the way the container does."""
payload = _state(request).stored.get(attachment_id)
if payload is None:
return JSONResponse({"error": "no such attachment"}, status_code=404)
return Response(content=payload, media_type="application/octet-stream")
@router.delete("/v1/attachments/{attachment_id}")
async def delete_attachment(request: Request, attachment_id: str) -> Response:
state = _state(request)
if attachment_id in state.attachments:
state.attachments.remove(attachment_id)
# The bytes go too, which is what makes "the second copy is gone"
# something a scenario can assert rather than assume.
state.stored.pop(attachment_id, None)
return Response(status_code=204)
def _add_receive_route(router: APIRouter) -> None:
"""Attach the WebSocket receive endpoint.
Split out so the router builder stays under the complexity cap.
"""
@router.websocket("/v1/receive/{number}")
async def receive(websocket: WebSocket, number: str) -> None:
state: State = websocket.app.state.fake
await websocket.accept()
await websocket.send_json({"envelope": {"subscribed": number}})
state.sockets.append(websocket)
try:
while True:
# Blocks until the client goes away. The bot never sends.
await websocket.receive_text()
except WebSocketDisconnect:
pass
finally:
# Branchless: a conditional remove leaves an arc no test can reach.
state.sockets[:] = [s for s in state.sockets if s is not websocket]