signal-bot/tests/test_pack_random.py
Krzysztof kuhy Rudnicki 48957a105d
Some checks are pending
CI / check (push) Waiting to run
feat: serve several photo albums at once, each scoped to its own groups
You asked for !add_photo in testbot without the real album being reachable
there. One album cannot do that: its people.json "groups" list *is* the
privacy guarantee, so making the commands exist in a second group necessarily
makes the real photos postable there. So the bot now loads several albums.

PHOTO_PACK_DIR takes a comma-separated list, the spelling GROUP_IDS and
TRUSTED_INVITERS already use. Each album carries its own group scope, its own
people, its own tags and its own custom labels; they share nothing but the
process they run in.

That makes trigger collisions between albums legal for the first time, and the
registry had to learn it. Two albums are two different sets of people and both
may reasonably call somebody "!alfa" -- no message can ever mean both, because
a command a group is not scoped to is not a command there at all. So a trigger
may be claimed more than once, and DuplicateTriggerError now fires only where
the group sets *overlap*. Overlapping albums are refused at startup rather than
resolved by registration order: a coin toss about which private album receives
a photo is the outcome this whole design exists to prevent.

Two consequences worth naming:

- registry.resolve() takes an optional group. Without one it still answers
  "does anything claim this word", which is what pack_add's mint check wants;
  with one it answers "what runs here", which is what the dispatcher wants.
  resolve_with_args no longer resolves-then-checks, because with two claimants
  the first one found may be the wrong group's.
- CommandContext moved to signal_bot/context.py to keep registry.py under the
  250-line cap. A filing change: that file is "which word runs what", this one
  is "what the thing that runs may do".

DOCS-add-photo.md is likewise a split, not new prose -- DOCS-photo-pack.md had
grown past the cap and the ingest path is its own subject now.

Verified live: the unit serves both albums, the real group resolves its 13
album commands and testbot its 7, and !losowe / !alfa / !dodaj all fire in
testbot through the live dispatcher. 997 tests, 100% branch coverage, 28 e2e
scenarios.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JqqE22jp94B1ypwxppdr1o
2026-08-31 11:58:50 +02:00

184 lines
6.4 KiB
Python

# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
"""!random: the only door to a custom tag, and the one that mints nothing."""
from __future__ import annotations
import json
from typing import TYPE_CHECKING
import pytest
from signal_bot.context import CommandContext
from signal_bot.models import parse_envelope
from signal_bot.pack_command import NO_PHOTO
from signal_bot.pack_custom import CUSTOM_FILE
from signal_bot.pack_holder import PackHolder
from signal_bot.pack_load import load
from signal_bot.pack_random import COMMAND_NAME, register_random_command
from signal_bot.registry import CommandRegistry
from tests import pack_fixture
from tests.conftest import SECOND_GROUP, WATCHED_GROUP, envelope
if TYPE_CHECKING:
from pathlib import Path
from signal_bot.config import Config
from signal_bot.registry import Handler
from signal_bot.store import Store
from signal_bot.transport_fake import FakeTransport
TRIGGERS = ("!losowe", "!random")
@pytest.fixture
def holder(tmp_path: Path) -> PackHolder:
root = pack_fixture.build(tmp_path / "pack")
(root / CUSTOM_FILE).write_text(
json.dumps({"t1": ["wakacje"], "t2": ["gory"]}), encoding="utf-8"
)
tags = json.loads((root / "tags.json").read_text(encoding="utf-8"))
tags["alfa.png"] = ["p1", "t1"]
(root / "tags.json").write_text(json.dumps(tags), encoding="utf-8")
return PackHolder(load(root))
def _registry(holder: PackHolder) -> CommandRegistry:
registry = CommandRegistry()
register_random_command(registry, holder, TRIGGERS)
return registry
async def _run(
holder: PackHolder,
transport: FakeTransport,
store: Store,
config: Config,
text: str,
group: str = WATCHED_GROUP,
) -> None:
registry = _registry(holder)
resolved = registry.resolve_with_args(text, group)
if resolved is None:
return
message = parse_envelope(envelope(text=text))
assert message is not None
await resolved.command.handler(
CommandContext(
message=message,
group_id=group,
transport=transport,
store=store,
config=config,
command_name=resolved.command.name,
now=0.0,
day="2026-08-31",
args=resolved.args,
)
)
async def test_a_bare_random_posts_something_from_the_whole_album(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
"""matching(frozenset()) is already "everything", so there is no new path."""
await _run(holder, transport, store, config, "!losowe")
assert transport.sent[-1].image_base64 is not None
async def test_a_custom_label_narrows_to_its_own_photos(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
await _run(holder, transport, store, config, "!losowe wakacje")
assert transport.sent[-1].filename == "alfa.png"
async def test_a_label_nobody_has_gets_one_line_and_no_photo(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
await _run(holder, transport, store, config, "!losowe niktnietaki")
assert transport.texts[-1] == NO_PHOTO
async def test_a_typo_on_random_mints_nothing(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
"""The reason !random does not share !add_photo's resolver."""
before = (holder.pack.directory / CUSTOM_FILE).read_text(encoding="utf-8")
await _run(holder, transport, store, config, "!losowe wakacjee")
assert (holder.pack.directory / CUSTOM_FILE).read_text(encoding="utf-8") == before
assert holder.pack.custom.keys == {"t1", "t2"}
async def test_a_tag_nobody_photographed_gets_one_line(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
await _run(holder, transport, store, config, "!losowe gory")
assert transport.texts[-1] == NO_PHOTO
async def test_two_labels_intersect(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
"""t1 and t2 share no photo, so the intersection is empty."""
await _run(holder, transport, store, config, "!losowe wakacje gory")
assert transport.texts[-1] == NO_PHOTO
async def test_too_many_labels_are_refused_rather_than_multiplied(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
await _run(holder, transport, store, config, "!losowe " + " ".join(["wakacje"] * 7))
assert transport.texts[-1] == NO_PHOTO
async def test_random_never_resolves_a_person(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
"""!alfa already exists; a second entrance would be one too many."""
await _run(holder, transport, store, config, "!losowe alfa")
assert transport.texts[-1] == NO_PHOTO
async def test_it_does_not_exist_in_a_group_the_album_was_not_given_to(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
await _run(holder, transport, store, config, "!losowe wakacje", group=SECOND_GROUP)
assert transport.sent == []
def test_it_is_scoped_and_named_by_pseudonym(holder: PackHolder) -> None:
command = _registry(holder).commands[0]
assert command.name == COMMAND_NAME
assert command.groups == holder.pack.groups
assert "wakacje" not in command.description
async def test_a_tag_minted_after_registration_still_resolves(
holder: PackHolder, transport: FakeTransport, store: Store, config: Config
) -> None:
"""The resolver reads the holder, so a swap is enough -- no re-register."""
root = holder.pack.directory
(root / CUSTOM_FILE).write_text(
json.dumps({"t1": ["wakacje"], "t2": ["gory"], "t3": ["nowe"]}), encoding="utf-8"
)
tags = json.loads((root / "tags.json").read_text(encoding="utf-8"))
tags["gamma.png"] = ["p3", "t3"]
(root / "tags.json").write_text(json.dumps(tags), encoding="utf-8")
assert holder.reload() is True
await _run(holder, transport, store, config, "!losowe nowe")
assert transport.sent[-1].filename == "gamma.png"
def test_the_cooldown_decorator_is_applied_when_given(holder: PackHolder) -> None:
"""!random is a photo poster, so it takes the same cooldown as !alfa."""
calls: list[str] = []
def decorate(handler: Handler) -> Handler:
calls.append("wrapped")
return handler
registry = CommandRegistry()
register_random_command(registry, holder, TRIGGERS, decorate=decorate)
assert calls == ["wrapped"]