mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:17:02 +01:00
Krzysztof kuhy Rudnicki
405541be9b
One row per command attempt, not two aggregates written only on success. command_uses holds last-use only and daily_uses counts successes; both are rate-limiter state and both are written by store.record_use, which the dispatcher calls only when a handler returns cleanly. A gate refusal and a crash returned before it, so a command that failed every time looked exactly like one nobody ran, and nothing knew which command a counted message was. command_events now takes every attempt with its outcome, its duration and the item it served; upstream_calls takes every outbound request made while serving one. The two writes stay separate on purpose -- recording a refusal as a use is what slid the cooldown window forward every time somebody was told to wait -- and test_dispatcher_outcomes asserts last_used does not move. Backfilled from journald joined against message_events, with daily_uses filling the residual so the two sources cannot double-count. Two things were wrong on the first attempt and both were found by measuring rather than by reasoning: the window has to be symmetric, because sent_at_ms comes from the sender's phone and the journal stamp from this host (194 of 299 lines landed *before* their own message, by up to 3.2 s); and matching has to be a global closest-pair assignment, because per-row greedy cannot separate two commands seconds apart. Together those took the dropped rows from 137 to zero, and recovered 418 invocations back to 29 August. Also: !analityka in the group, twelve Polish lines, naming at most three people and only ones whose display name has been seen; an Analytics tab with Nivo charts; and continuous latency measurement, which answers the open question in DOCS-latency.md -- a text send is 235 ms and an image send about 2.2 s, so the upload really is where the time goes. EPHEMERAL_TABLES was doing two unrelated jobs and is now two tuples: what a schema bump rebuilds, and what leaving a group clears. daily_uses left the first (it is a backfill source now) and stayed in the second, and _drop_reshaped took over the repair a bump used to do for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QTp3h5Q3MvfrwGV8xqPf
58 lines
1.8 KiB
Python
58 lines
1.8 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The management application, assembled.
|
|
|
|
A second process rather than more routes on the bot's own app. Two reasons,
|
|
and both are about blast radius: this one can rewrite ``.env``, and the bot's
|
|
port already serves ``/_selftest``, which posts for real into a real group.
|
|
Keeping them apart means the surface that can reconfigure the bot is only
|
|
listening while somebody has the page open.
|
|
|
|
Order is load-bearing. The guard goes on first so it sees every request; the
|
|
API routers are registered next; the static catch-all is registered last,
|
|
because ``/{path:path}`` would otherwise shadow every route after it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from fastapi import FastAPI
|
|
|
|
from signal_bot.manage import (
|
|
assets,
|
|
guard,
|
|
routes_actions,
|
|
routes_album,
|
|
routes_analytics,
|
|
routes_env,
|
|
routes_status,
|
|
routes_suggestions,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.manage.deps import ManageDeps
|
|
|
|
DEFAULT_CONTAINER = "signal-api"
|
|
|
|
|
|
def build_app(deps: ManageDeps, *, container: str = DEFAULT_CONTAINER) -> FastAPI:
|
|
"""The whole page, bound to one bot and one album.
|
|
|
|
Args:
|
|
deps: Everything the app is pointed at.
|
|
container: The docker container signal-cli runs in.
|
|
|
|
Returns:
|
|
An application ready for uvicorn, or for a test client.
|
|
"""
|
|
app = FastAPI(title="signal-bot", docs_url=None, redoc_url=None, openapi_url=None)
|
|
guard.install(app, deps.port)
|
|
app.include_router(routes_status.router(deps))
|
|
app.include_router(routes_env.router(deps))
|
|
app.include_router(routes_actions.router(deps, container))
|
|
app.include_router(routes_album.router(deps))
|
|
app.include_router(routes_suggestions.router(deps))
|
|
app.include_router(routes_analytics.router(deps))
|
|
assets.install(app, deps.dist_dir)
|
|
return app
|