mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:17:02 +01:00
Krzysztof kuhy Rudnicki
405541be9b
One row per command attempt, not two aggregates written only on success. command_uses holds last-use only and daily_uses counts successes; both are rate-limiter state and both are written by store.record_use, which the dispatcher calls only when a handler returns cleanly. A gate refusal and a crash returned before it, so a command that failed every time looked exactly like one nobody ran, and nothing knew which command a counted message was. command_events now takes every attempt with its outcome, its duration and the item it served; upstream_calls takes every outbound request made while serving one. The two writes stay separate on purpose -- recording a refusal as a use is what slid the cooldown window forward every time somebody was told to wait -- and test_dispatcher_outcomes asserts last_used does not move. Backfilled from journald joined against message_events, with daily_uses filling the residual so the two sources cannot double-count. Two things were wrong on the first attempt and both were found by measuring rather than by reasoning: the window has to be symmetric, because sent_at_ms comes from the sender's phone and the journal stamp from this host (194 of 299 lines landed *before* their own message, by up to 3.2 s); and matching has to be a global closest-pair assignment, because per-row greedy cannot separate two commands seconds apart. Together those took the dropped rows from 137 to zero, and recovered 418 invocations back to 29 August. Also: !analityka in the group, twelve Polish lines, naming at most three people and only ones whose display name has been seen; an Analytics tab with Nivo charts; and continuous latency measurement, which answers the open question in DOCS-latency.md -- a text send is 235 ms and an image send about 2.2 s, so the upload really is where the time goes. EPHEMERAL_TABLES was doing two unrelated jobs and is now two tuples: what a schema bump rebuilds, and what leaving a group clears. daily_uses left the first (it is a backfill source now) and stayed in the second, and _drop_reshaped took over the repair a bump used to do for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QTp3h5Q3MvfrwGV8xqPf
91 lines
3.8 KiB
Python
91 lines
3.8 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The wish-list tables: what they keep, and what a redelivery does to them."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from signal_bot.schema import CLEARED_ON_LEAVE, PERMANENT_TABLES, REBUILT_ON_BUMP
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.store import Store
|
|
|
|
|
|
def test_nothing_collected_reads_as_nothing(store: Store) -> None:
|
|
"""Empty is a state, not an absence of tables."""
|
|
assert store.suggestions.filed() == []
|
|
assert store.suggestions.unknown() == []
|
|
|
|
|
|
def test_a_replayed_frame_does_not_become_a_second_row(store: Store) -> None:
|
|
"""signal-cli replays undelivered frames when the bot reconnects.
|
|
|
|
Keyed on the envelope's own timestamp rather than the wall clock, so a
|
|
replay collides with the row it already wrote and is ignored.
|
|
"""
|
|
for _ in range(3):
|
|
store.suggestions.record_unknown("g1", "!cta", "!cta", 500)
|
|
(row,) = store.suggestions.unknown()
|
|
assert row.hits == 1
|
|
|
|
|
|
def test_the_same_word_typed_again_later_counts_twice(store: Store) -> None:
|
|
"""A different message is a different row, which is what a tally is for."""
|
|
store.suggestions.record_unknown("g1", "!cta", "!cta", 500)
|
|
store.suggestions.record_unknown("g1", "!cta", "!cta znowu", 600)
|
|
(row,) = store.suggestions.unknown()
|
|
assert row.hits == 2
|
|
assert row.last_seen == 600
|
|
assert row.bodies == ("!cta", "!cta znowu")
|
|
|
|
|
|
def test_two_groups_never_share_a_tally(store: Store) -> None:
|
|
"""Every table in this schema is keyed by group first, and so is this one."""
|
|
store.suggestions.record_unknown("g1", "!cta", "!cta", 1)
|
|
store.suggestions.record_unknown("g2", "!cta", "!cta", 1)
|
|
assert {row.group_id for row in store.suggestions.unknown()} == {"g1", "g2"}
|
|
|
|
|
|
def test_tallies_come_back_most_tried_first(store: Store) -> None:
|
|
"""The page is a queue of work, so the loudest request sorts to the top."""
|
|
store.suggestions.record_unknown("g1", "!rare", "!rare", 1)
|
|
store.suggestions.record_unknown("g1", "!often", "!often", 2)
|
|
store.suggestions.record_unknown("g1", "!often", "!often", 3)
|
|
assert [row.word for row in store.suggestions.unknown()] == ["!often", "!rare"]
|
|
|
|
|
|
def test_suggestions_come_back_newest_first(store: Store) -> None:
|
|
"""The newest idea is the one most likely still worth acting on."""
|
|
store.suggestions.record_suggestion("g1", "!old", "stara", 1)
|
|
store.suggestions.record_suggestion("g1", "!new", "nowa", 2)
|
|
assert [row.command for row in store.suggestions.filed()] == ["!new", "!old"]
|
|
|
|
|
|
def test_two_people_can_ask_for_the_same_command(store: Store) -> None:
|
|
"""Different messages, so different rows -- twelve askers are twelve rows."""
|
|
store.suggestions.record_suggestion("g1", "!pogoda", "na jutro", 1)
|
|
store.suggestions.record_suggestion("g1", "!pogoda", "na tydzień", 2)
|
|
assert len(store.suggestions.filed()) == 2
|
|
|
|
|
|
def test_leaving_a_group_does_not_discard_the_wish_list(store: Store) -> None:
|
|
"""forget_group clears CLEARED_ON_LEAVE, and these are not among them.
|
|
|
|
A transient group listing that omits a member is the exact failure
|
|
discovery._permitted guards against, and it must not be able to delete
|
|
ideas nothing can recompute.
|
|
"""
|
|
store.suggestions.record_suggestion("g1", "!pogoda", "na jutro", 1)
|
|
store.suggestions.record_unknown("g1", "!cta", "!cta", 2)
|
|
store.forget_group("g1")
|
|
assert len(store.suggestions.filed()) == 1
|
|
assert len(store.suggestions.unknown()) == 1
|
|
|
|
|
|
def test_both_tables_are_declared_permanent() -> None:
|
|
"""The property above, asserted where it is actually configured."""
|
|
for table in ("suggestions", "unknown_commands"):
|
|
assert table in PERMANENT_TABLES
|
|
assert table not in CLEARED_ON_LEAVE
|
|
assert table not in REBUILT_ON_BUMP
|