mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-11 13:47:48 +01:00
Krzysztof kuhy Rudnicki
b48c945d89
First live reply, as its own registered account. `!cat` and `!dog` from the
phone return images -- verified in the production shape (the bot *invited to
an already-existing group*) and under a systemd user unit.
Four failures, each of which left the bot looking perfectly healthy:
- Invited is not joined. Signal only adds an account outright if the adder
holds its profile key; with no profile the add becomes a pending invite,
and signal-cli cannot accept one addressed to a phone number ("Cannot find
service ID for self"). Group listed, websocket up, /healthz OK, zero
messages. register_bot.sh now sets the profile *before* the add, and
startup refuses on `member: false`.
- MODE=json-rpc-native is a GraalVM build with no AWT: text sends work,
every attachment 400s with "Can't load library: awt". Both mode guards now
demand exactly json-rpc, and start_container replaces a wrong-mode
container instead of reusing it.
- The API spells one group two ways -- /v1/groups returns `group.<base64>`,
envelopes carry what that decodes to -- so the scoping gate rejected the
bot's own group. e2e.sh now models both spellings; reverting the fix fails
4 scenarios, which is why the offline suite missed it before.
- BIND_PORT in .env was dead: __main__ read os.getenv before anything loaded
a .env. The bind address comes from Config now.
A taken port used to be uvicorn logging the collision and exiting 0, which
every supervisor reads as success. portcheck.py refuses to start, exits
non-zero, and names the holder by reading /proc directly -- no subprocess, no
PATH assumptions, testable against a fake proc tree. Default port is 8137:
not 8000, and below the ephemeral range so the kernel cannot take it.
The bot now runs as signal-bot.service (Restart=always, linger checked rather
than assumed, StartLimitBurst so a config error fails visibly instead of
looping). Verified by SIGKILL and by re-running a command under the unit.
100% branch coverage, 230 tests, all gates green.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Console entrypoint, so `python -m signal_bot` actually starts the bot.
|
|
|
|
The old readme told people to run `python main.py`, which had no __main__
|
|
block and no uvicorn.run() call, so it silently did nothing at all.
|
|
|
|
The bind address comes from Config rather than os.getenv() here: this module
|
|
runs *before* uvicorn imports the app, and therefore before anything has
|
|
called load_dotenv(), so reading the environment directly would ignore
|
|
BIND_HOST/BIND_PORT whenever they live in .env -- which is where they live.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
|
|
import uvicorn
|
|
|
|
from signal_bot.config import load_config
|
|
from signal_bot.portcheck import PortInUseError, assert_port_free
|
|
|
|
|
|
def main() -> None:
|
|
"""Run the ASGI app under uvicorn, refusing to start on a taken port."""
|
|
config = load_config()
|
|
# Before anything else: uvicorn only configures its own loggers, so
|
|
# without this the bot's own log lines go to logging.lastResort and
|
|
# anything below WARNING is thrown away.
|
|
logging.basicConfig(
|
|
level=config.log_level, format="%(asctime)s %(levelname)s %(name)s: %(message)s"
|
|
)
|
|
try:
|
|
assert_port_free(config.bind_host, config.bind_port)
|
|
except PortInUseError as exc:
|
|
raise SystemExit(str(exc)) from exc
|
|
uvicorn.run("signal_bot.app:app", host=config.bind_host, port=config.bind_port)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|