mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-11 16:54:08 +01:00
Krzysztof kuhy Rudnicki
405541be9b
One row per command attempt, not two aggregates written only on success. command_uses holds last-use only and daily_uses counts successes; both are rate-limiter state and both are written by store.record_use, which the dispatcher calls only when a handler returns cleanly. A gate refusal and a crash returned before it, so a command that failed every time looked exactly like one nobody ran, and nothing knew which command a counted message was. command_events now takes every attempt with its outcome, its duration and the item it served; upstream_calls takes every outbound request made while serving one. The two writes stay separate on purpose -- recording a refusal as a use is what slid the cooldown window forward every time somebody was told to wait -- and test_dispatcher_outcomes asserts last_used does not move. Backfilled from journald joined against message_events, with daily_uses filling the residual so the two sources cannot double-count. Two things were wrong on the first attempt and both were found by measuring rather than by reasoning: the window has to be symmetric, because sent_at_ms comes from the sender's phone and the journal stamp from this host (194 of 299 lines landed *before* their own message, by up to 3.2 s); and matching has to be a global closest-pair assignment, because per-row greedy cannot separate two commands seconds apart. Together those took the dropped rows from 137 to zero, and recovered 418 invocations back to 29 August. Also: !analityka in the group, twelve Polish lines, naming at most three people and only ones whose display name has been seen; an Analytics tab with Nivo charts; and continuous latency measurement, which answers the open question in DOCS-latency.md -- a text send is 235 ms and an image send about 2.2 s, so the upload really is where the time goes. EPHEMERAL_TABLES was doing two unrelated jobs and is now two tuples: what a schema bump rebuilds, and what leaving a group clears. daily_uses left the first (it is a backfill source now) and stayed in the second, and _drop_reshaped took over the repair a bump used to do for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QTp3h5Q3MvfrwGV8xqPf
70 lines
2.4 KiB
Python
70 lines
2.4 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The !papież command: a random pope, his portrait, his Latin name, his article.
|
|
|
|
The list this draws from is the same signal_bot/popes.json the version ladder
|
|
is built on, so the bot posts the popes it is named after.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import secrets
|
|
from typing import TYPE_CHECKING, Final
|
|
|
|
from signal_bot.analytics import probe
|
|
from signal_bot.animals import load_aliases
|
|
from signal_bot.versioning import POPES, article_url, pope_line
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.context import CommandContext
|
|
from signal_bot.decorators import Decorator
|
|
from signal_bot.portraits import PortraitCache
|
|
from signal_bot.registry import CommandRegistry, Handler
|
|
from signal_bot.versioning import Pope
|
|
|
|
COMMAND_NAME: Final = "pope"
|
|
DESCRIPTION: Final = "losowy papież z portretem i imieniem po łacinie"
|
|
|
|
|
|
def random_pope() -> Pope:
|
|
"""Return one pope, uniformly at random.
|
|
|
|
secrets rather than random for the reason animals.paged_url gives: the
|
|
choice is not security-sensitive, but ruff's ALL rule set flags `random`
|
|
and this repo forbids the noqa that would silence it.
|
|
"""
|
|
return POPES[secrets.randbelow(len(POPES))]
|
|
|
|
|
|
def caption_for(pope: Pope) -> str:
|
|
"""Return the message that rides along with the portrait."""
|
|
return f"{pope.name} — {pope.latin}\n{pope_line(pope)}\n{article_url(pope)}"
|
|
|
|
|
|
def pope_handler(cache: PortraitCache) -> Handler:
|
|
"""Build the handler that posts a random pope."""
|
|
|
|
async def handler(ctx: CommandContext) -> None:
|
|
pope = random_pope()
|
|
# The ordinal, not the name: it is the pope's identifier here
|
|
# and in popes.json, and the caption is built at reply time.
|
|
probe.note_item(str(pope.ordinal))
|
|
image = await cache.get_base64(pope)
|
|
await ctx.reply_image(image, caption_for(pope))
|
|
|
|
return handler
|
|
|
|
|
|
def register_pope_command(
|
|
registry: CommandRegistry,
|
|
cache: PortraitCache,
|
|
*,
|
|
decorate: Decorator | None = None,
|
|
aliases: dict[str, list[str]] | None = None,
|
|
) -> None:
|
|
"""Register !papież under every trigger aliases.json gives it."""
|
|
table = load_aliases() if aliases is None else aliases
|
|
handler = pope_handler(cache)
|
|
if decorate is not None:
|
|
handler = decorate(handler)
|
|
registry.register(COMMAND_NAME, table[COMMAND_NAME], handler, DESCRIPTION)
|