mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:17:02 +01:00
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
131 lines
4.7 KiB
Python
131 lines
4.7 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Scenario files: what to inject, and what the bot must do in response."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from dataclasses import dataclass, field
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
import yaml
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class ScenarioError(ValueError):
|
|
"""Raised when a scenario file is malformed."""
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class Injection:
|
|
"""One inbound message to push down the websocket."""
|
|
|
|
text: str | None = None
|
|
uuid: str = "uuid-alice"
|
|
name: str = "Alice"
|
|
group: str | None = "watched"
|
|
sticker: bool = False
|
|
reaction: bool = False
|
|
sync: bool = False
|
|
|
|
def to_frame(self, groups: dict[str, str]) -> str:
|
|
"""Render this injection as a raw signal-cli envelope."""
|
|
payload: dict[str, Any] = {"timestamp": 1719177917717}
|
|
if self.text is not None:
|
|
payload["message"] = self.text
|
|
if self.group is not None:
|
|
if self.group not in groups:
|
|
msg = f"unknown group alias {self.group!r}; known: {sorted(groups)}"
|
|
raise ScenarioError(msg)
|
|
payload["groupInfo"] = {"groupId": groups[self.group], "type": "DELIVER"}
|
|
if self.sticker:
|
|
payload["sticker"] = {"packId": "abc", "stickerId": 6}
|
|
if self.reaction:
|
|
payload["reaction"] = {"emoji": "\U0001f44d", "targetAuthor": "x"}
|
|
|
|
body: dict[str, Any] = {"sourceUuid": self.uuid, "sourceName": self.name}
|
|
if self.sync:
|
|
body["syncMessage"] = {"sentMessage": payload}
|
|
else:
|
|
body["dataMessage"] = payload
|
|
return json.dumps({"envelope": body, "account": "+15550000000"})
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class Expectation:
|
|
"""One message the bot is expected to have sent."""
|
|
|
|
kind: str = "text"
|
|
to: str = "reply"
|
|
contains: str | None = None
|
|
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class Scenario:
|
|
"""A named list of injections and the sends they must produce."""
|
|
|
|
name: str
|
|
inject: list[Injection] = field(default_factory=list)
|
|
expect: list[Expectation] = field(default_factory=list)
|
|
|
|
|
|
def _build[T](cls: type[T], entry: object, what: str) -> T:
|
|
"""Instantiate a scenario dataclass, rejecting unknown keys."""
|
|
if not isinstance(entry, dict):
|
|
msg = f"each {what} entry must be a mapping, got {type(entry).__name__}"
|
|
raise ScenarioError(msg)
|
|
allowed = set(cls.__annotations__)
|
|
unknown = set(entry) - allowed
|
|
if unknown:
|
|
msg = f"unknown {what} keys {sorted(unknown)}; allowed: {sorted(allowed)}"
|
|
raise ScenarioError(msg)
|
|
return cls(**entry)
|
|
|
|
|
|
def load_scenario(path: Path) -> Scenario:
|
|
"""Load and validate one scenario file.
|
|
|
|
Raises:
|
|
ScenarioError: The file is not a mapping or carries unknown keys.
|
|
"""
|
|
document = yaml.safe_load(path.read_text(encoding="utf-8"))
|
|
if not isinstance(document, dict):
|
|
msg = f"{path} must contain a mapping"
|
|
raise ScenarioError(msg)
|
|
if "name" not in document:
|
|
msg = f"{path} is missing a name"
|
|
raise ScenarioError(msg)
|
|
return Scenario(
|
|
name=str(document["name"]),
|
|
inject=[_build(Injection, e, "inject") for e in document.get("inject", [])],
|
|
expect=[_build(Expectation, e, "expect") for e in document.get("expect", [])],
|
|
)
|
|
|
|
|
|
def describe(payload: dict[str, Any]) -> tuple[str, str, str]:
|
|
"""Reduce a captured send to (kind, recipient, body) for comparison."""
|
|
kind = "image" if payload.get("base64_attachments") else "text"
|
|
recipients = payload.get("recipients") or [""]
|
|
return kind, str(recipients[0]), str(payload.get("message", ""))
|
|
|
|
|
|
def check(scenario: Scenario, sent: list[dict[str, Any]], groups: dict[str, str]) -> list[str]:
|
|
"""Compare captured sends against expectations, returning failure lines."""
|
|
failures: list[str] = []
|
|
if len(sent) != len(scenario.expect):
|
|
failures.append(f"expected {len(scenario.expect)} send(s), captured {len(sent)}")
|
|
for index, expected in enumerate(scenario.expect):
|
|
if index >= len(sent):
|
|
failures.append(f"[{index}] missing: expected a {expected.kind}")
|
|
continue
|
|
kind, recipient, body = describe(sent[index])
|
|
want_to = groups.get(expected.to, expected.to)
|
|
if kind != expected.kind:
|
|
failures.append(f"[{index}] kind: expected {expected.kind}, got {kind}")
|
|
if recipient != want_to:
|
|
failures.append(f"[{index}] recipient: expected {want_to}, got {recipient}")
|
|
if expected.contains is not None and expected.contains not in body:
|
|
failures.append(f"[{index}] body: {expected.contains!r} not in {body!r}")
|
|
return failures
|