mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 20:27:17 +01:00
Krzysztof kuhy Rudnicki
6bde3493a4
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
88 lines
3.0 KiB
Python
88 lines
3.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Image fetching and JSON path walking."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import base64
|
|
from collections.abc import Callable
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from signal_bot.http_client import ImageFetcher, ImageFetchError
|
|
|
|
IMAGE = b"\x89PNG\r\n\x1a\nfake"
|
|
|
|
# The callable httpx.MockTransport expects -- not a bot command handler.
|
|
MockHandler = Callable[[httpx.Request], httpx.Response]
|
|
|
|
|
|
def _fetcher(handler: MockHandler) -> ImageFetcher:
|
|
return ImageFetcher(httpx.AsyncClient(transport=httpx.MockTransport(handler)))
|
|
|
|
|
|
def _api(payload: object, image: bytes = IMAGE) -> MockHandler:
|
|
def handler(request: httpx.Request) -> httpx.Response:
|
|
if "images" in str(request.url) or "breeds" in str(request.url):
|
|
return httpx.Response(200, json=payload)
|
|
return httpx.Response(200, content=image)
|
|
|
|
return handler
|
|
|
|
|
|
async def test_fetches_via_list_then_key_path() -> None:
|
|
fetcher = _fetcher(_api([{"url": "https://cdn.example/cat.png"}]))
|
|
encoded = await fetcher.fetch_base64("https://api/images/search", [0, "url"])
|
|
assert base64.b64decode(encoded) == IMAGE
|
|
|
|
|
|
async def test_fetches_via_single_key_path() -> None:
|
|
fetcher = _fetcher(_api({"message": "https://cdn.example/dog.png"}))
|
|
encoded = await fetcher.fetch_base64("https://api/breeds/x", ["message"])
|
|
assert base64.b64decode(encoded) == IMAGE
|
|
|
|
|
|
async def test_negative_index_is_supported() -> None:
|
|
fetcher = _fetcher(_api([{"url": "https://cdn.example/cat.png"}]))
|
|
encoded = await fetcher.fetch_base64("https://api/images/search", [-1, "url"])
|
|
assert base64.b64decode(encoded) == IMAGE
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("payload", "path"),
|
|
[
|
|
({"other": "x"}, ["message"]),
|
|
([], [0, "url"]),
|
|
([{"url": "x"}], [5, "url"]),
|
|
({"message": "x"}, [0]),
|
|
([{"url": "x"}], ["message"]),
|
|
],
|
|
)
|
|
async def test_missing_element_raises(payload: object, path: list) -> None:
|
|
fetcher = _fetcher(_api(payload))
|
|
with pytest.raises(ImageFetchError, match="no element at"):
|
|
await fetcher.fetch_base64("https://api/images/search", path)
|
|
|
|
|
|
@pytest.mark.parametrize("payload", [{"message": 42}, {"message": ""}])
|
|
async def test_non_url_element_raises(payload: object) -> None:
|
|
fetcher = _fetcher(_api(payload))
|
|
with pytest.raises(ImageFetchError, match="is not a URL"):
|
|
await fetcher.fetch_base64("https://api/breeds/x", ["message"])
|
|
|
|
|
|
async def test_api_error_propagates() -> None:
|
|
fetcher = _fetcher(lambda r: httpx.Response(503))
|
|
with pytest.raises(httpx.HTTPStatusError):
|
|
await fetcher.fetch_base64("https://api/images/search", [0, "url"])
|
|
|
|
|
|
async def test_image_download_error_propagates() -> None:
|
|
def handler(request: httpx.Request) -> httpx.Response:
|
|
if "images" in str(request.url):
|
|
return httpx.Response(200, json=[{"url": "https://cdn.example/cat.png"}])
|
|
return httpx.Response(404)
|
|
|
|
with pytest.raises(httpx.HTTPStatusError):
|
|
await _fetcher(handler).fetch_base64("https://api/images/search", [0, "url"])
|