mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:07:29 +01:00
Krzysztof kuhy Rudnicki
6bde3493a4
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
60 lines
1.9 KiB
Python
60 lines
1.9 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The console entrypoint.
|
|
|
|
`python main.py` used to do literally nothing: there was no __main__ block
|
|
and no uvicorn.run() call anywhere in the project.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import runpy
|
|
|
|
import pytest
|
|
import uvicorn
|
|
|
|
import signal_bot.__main__ as entrypoint
|
|
|
|
|
|
@pytest.fixture
|
|
def captured(monkeypatch: pytest.MonkeyPatch) -> dict[str, object]:
|
|
seen: dict[str, object] = {}
|
|
|
|
def fake_run(target: str, **kwargs: object) -> None:
|
|
seen["target"] = target
|
|
seen.update(kwargs)
|
|
|
|
monkeypatch.setattr(entrypoint.uvicorn, "run", fake_run)
|
|
return seen
|
|
|
|
|
|
def test_runs_the_asgi_app_on_loopback_by_default(
|
|
captured: dict[str, object], monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.delenv("BIND_HOST", raising=False)
|
|
monkeypatch.delenv("BIND_PORT", raising=False)
|
|
entrypoint.main()
|
|
assert captured["target"] == "signal_bot.app:app"
|
|
assert captured["host"] == "127.0.0.1"
|
|
assert captured["port"] == 8000
|
|
|
|
|
|
def test_bind_overrides_are_honoured(
|
|
captured: dict[str, object], monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
# TEST-NET-1: proves the override without a bind-all literal.
|
|
monkeypatch.setenv("BIND_HOST", "192.0.2.10")
|
|
monkeypatch.setenv("BIND_PORT", "9001")
|
|
entrypoint.main()
|
|
assert captured["host"] == "192.0.2.10"
|
|
assert captured["port"] == 9001
|
|
|
|
|
|
def test_module_runs_as_a_script(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""`python -m signal_bot` must actually start the server."""
|
|
seen: dict[str, object] = {}
|
|
monkeypatch.setattr(uvicorn, "run", lambda target, **kw: seen.update(target=target))
|
|
monkeypatch.delenv("BIND_HOST", raising=False)
|
|
monkeypatch.delenv("BIND_PORT", raising=False)
|
|
runpy.run_module("signal_bot", run_name="__main__", alter_sys=True)
|
|
assert seen["target"] == "signal_bot.app:app"
|