mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:07:29 +01:00
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
133 lines
4.4 KiB
Python
133 lines
4.4 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Scenario loading, rendering and adjudication."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from fake_signal.scenario import (
|
|
Expectation,
|
|
Injection,
|
|
Scenario,
|
|
ScenarioError,
|
|
check,
|
|
describe,
|
|
load_scenario,
|
|
)
|
|
from signal_bot.models import parse_envelope
|
|
|
|
GROUPS = {"watched": "W==", "reply": "R==", "other": "O=="}
|
|
|
|
|
|
def _write(tmp_path: Path, document: str) -> Path:
|
|
path = tmp_path / "s.yaml"
|
|
path.write_text(document, encoding="utf-8")
|
|
return path
|
|
|
|
|
|
def test_ships_scenarios_load_and_are_valid() -> None:
|
|
paths = sorted(Path("fake_signal/scenarios").glob("*.yaml"))
|
|
assert paths
|
|
for path in paths:
|
|
assert load_scenario(path).name
|
|
|
|
|
|
def test_injection_renders_a_parseable_group_envelope() -> None:
|
|
frame = Injection(text="!cat").to_frame(GROUPS)
|
|
message = parse_envelope(frame)
|
|
assert message is not None
|
|
assert message.text == "!cat"
|
|
assert message.group_id == "W=="
|
|
|
|
|
|
def test_injection_renders_a_direct_message() -> None:
|
|
message = parse_envelope(Injection(text="hi", group=None).to_frame(GROUPS))
|
|
assert message is not None
|
|
assert message.is_direct_message
|
|
|
|
|
|
def test_injection_renders_sync_sticker_and_reaction() -> None:
|
|
sticker = parse_envelope(Injection(sticker=True, sync=True).to_frame(GROUPS))
|
|
reaction = parse_envelope(Injection(reaction=True).to_frame(GROUPS))
|
|
assert sticker is not None
|
|
assert sticker.has_sticker
|
|
assert reaction is not None
|
|
assert reaction.is_reaction
|
|
|
|
|
|
def test_unknown_group_alias_is_rejected() -> None:
|
|
with pytest.raises(ScenarioError, match="unknown group alias"):
|
|
Injection(group="nope").to_frame(GROUPS)
|
|
|
|
|
|
def test_loads_a_full_scenario(tmp_path: Path) -> None:
|
|
path = _write(
|
|
tmp_path,
|
|
"name: demo\ninject:\n - {text: '!cat'}\nexpect:\n - {kind: image}\n",
|
|
)
|
|
scenario = load_scenario(path)
|
|
assert scenario.name == "demo"
|
|
assert scenario.inject[0].text == "!cat"
|
|
assert scenario.expect[0].kind == "image"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("document", "match"),
|
|
[
|
|
("- a list\n", "must contain a mapping"),
|
|
("inject: []\n", "missing a name"),
|
|
("name: x\ninject:\n - {bogus: 1}\n", "unknown inject keys"),
|
|
("name: x\nexpect:\n - {bogus: 1}\n", "unknown expect keys"),
|
|
("name: x\ninject:\n - not-a-mapping\n", "must be a mapping"),
|
|
],
|
|
)
|
|
def test_malformed_scenarios_are_rejected(tmp_path: Path, document: str, match: str) -> None:
|
|
with pytest.raises(ScenarioError, match=match):
|
|
load_scenario(_write(tmp_path, document))
|
|
|
|
|
|
def test_describe_classifies_sends() -> None:
|
|
assert describe({"message": "hi", "recipients": ["R=="]}) == ("text", "R==", "hi")
|
|
assert describe({"base64_attachments": ["A"], "recipients": ["R=="]})[0] == "image"
|
|
assert describe({})[1] == ""
|
|
|
|
|
|
def test_check_passes_on_a_match() -> None:
|
|
scenario = Scenario("s", expect=[Expectation(kind="image", to="reply")])
|
|
sent = [{"base64_attachments": ["A"], "recipients": ["R=="]}]
|
|
assert check(scenario, sent, GROUPS) == []
|
|
|
|
|
|
def test_check_reports_a_count_mismatch() -> None:
|
|
scenario = Scenario("s", expect=[Expectation()])
|
|
failures = check(scenario, [], GROUPS)
|
|
assert "expected 1 send(s), captured 0" in failures[0]
|
|
assert any("missing" in line for line in failures)
|
|
|
|
|
|
def test_check_reports_kind_recipient_and_body() -> None:
|
|
scenario = Scenario("s", expect=[Expectation(kind="image", to="reply", contains="nope")])
|
|
sent = [{"message": "hello", "recipients": ["W=="]}]
|
|
failures = check(scenario, sent, GROUPS)
|
|
assert any("kind:" in f for f in failures)
|
|
assert any("recipient:" in f for f in failures)
|
|
assert any("body:" in f for f in failures)
|
|
|
|
|
|
def test_check_accepts_a_literal_recipient() -> None:
|
|
scenario = Scenario("s", expect=[Expectation(to="literal==")])
|
|
assert check(scenario, [{"message": "", "recipients": ["literal=="]}], GROUPS) == []
|
|
|
|
|
|
def test_unexpected_sends_are_a_failure() -> None:
|
|
"""A scoping regression shows up here: expect [] and the bot replied."""
|
|
failures = check(Scenario("s"), [{"message": "leak", "recipients": ["R=="]}], GROUPS)
|
|
assert "expected 0 send(s), captured 1" in failures[0]
|
|
|
|
|
|
def test_frame_is_json() -> None:
|
|
assert json.loads(Injection().to_frame(GROUPS))["account"] == "+15550000000"
|