mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:07:29 +01:00
Krzysztof kuhy Rudnicki
6bde3493a4
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
69 lines
2.0 KiB
Python
69 lines
2.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The daily report, driven by an injected clock."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import datetime as dt
|
|
|
|
from signal_bot.scheduler import SECONDS_PER_DAY, Action, DailyScheduler
|
|
|
|
|
|
def _scheduler(action: Action, now: dt.datetime, slept: list[float]) -> DailyScheduler:
|
|
async def sleeper(seconds: float) -> None:
|
|
slept.append(seconds)
|
|
|
|
return DailyScheduler(21, 37, action, lambda: now, sleeper)
|
|
|
|
|
|
async def _noop() -> None:
|
|
return None
|
|
|
|
|
|
def test_waits_until_later_today() -> None:
|
|
now = dt.datetime(2026, 8, 29, 20, 37, tzinfo=dt.UTC)
|
|
assert _scheduler(_noop, now, []).seconds_until_next(now) == 3600
|
|
|
|
|
|
def test_rolls_over_to_tomorrow_once_passed() -> None:
|
|
now = dt.datetime(2026, 8, 29, 22, 37, tzinfo=dt.UTC)
|
|
assert _scheduler(_noop, now, []).seconds_until_next(now) == SECONDS_PER_DAY - 3600
|
|
|
|
|
|
def test_exact_target_time_waits_a_full_day() -> None:
|
|
"""Never returns zero, which would busy-loop the report."""
|
|
now = dt.datetime(2026, 8, 29, 21, 37, tzinfo=dt.UTC)
|
|
assert _scheduler(_noop, now, []).seconds_until_next(now) == SECONDS_PER_DAY
|
|
|
|
|
|
async def test_runs_the_action_after_sleeping() -> None:
|
|
calls: list[int] = []
|
|
slept: list[float] = []
|
|
|
|
async def action() -> None:
|
|
calls.append(1)
|
|
|
|
now = dt.datetime(2026, 8, 29, 20, 37, tzinfo=dt.UTC)
|
|
await _scheduler(action, now, slept).run(iterations=2)
|
|
assert calls == [1, 1]
|
|
assert slept == [3600, 3600]
|
|
|
|
|
|
async def test_a_failing_report_does_not_stop_the_loop() -> None:
|
|
calls: list[int] = []
|
|
|
|
async def action() -> None:
|
|
calls.append(1)
|
|
msg = "signal is down"
|
|
raise RuntimeError(msg)
|
|
|
|
now = dt.datetime(2026, 8, 29, 20, 37, tzinfo=dt.UTC)
|
|
await _scheduler(action, now, []).run(iterations=2)
|
|
assert calls == [1, 1]
|
|
|
|
|
|
async def test_zero_iterations_does_nothing() -> None:
|
|
slept: list[float] = []
|
|
now = dt.datetime(2026, 8, 29, 20, 37, tzinfo=dt.UTC)
|
|
await _scheduler(_noop, now, slept).run(iterations=0)
|
|
assert slept == []
|