mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:17:02 +01:00
Krzysztof kuhy Rudnicki
6bde3493a4
The bot did not work. `run.sh` started a FastAPI app whose
`@app.on_event("startup")` awaited `asyncio.gather()` on two infinite
tasks, so uvicorn never finished starting up and no HTTP was ever served;
the readme's `python main.py` was a no-op with no `__main__` block and no
`uvicorn.run()` call. All three CI workflows were red, one referencing an
`environment.yml` that does not exist.
Rewritten as a package behind an injectable transport seam, which is what
makes the offline environment possible.
Bugs fixed:
- startup deadlock: lifespan spawns the loops instead of awaiting them
- sticker filter read dataMessage.sticker even on syncMessage envelopes, so
the account's own stickers were never filtered (e038772, 53028cc, 07fa90d,
2416cef all fought this symptom)
- no websocket reconnect: a container restart killed the bot silently
- blocking `requests` inside async functions stalled the event loop
- every counted message DMed the whole tally to the bot itself
- images were written to CWD under a filename taken from the remote URL
- one global 10s cooldown shared across all users and commands
- dead code: RECEIVE_URL, get_attachments (no call site), USER_MESSAGE_COUNT
- .env.sample declared PRIMARY/SECONDARY_PHONE_NUMBER and MODE, none read
Scoping is now an enforced invariant. A linked device receives every DM and
every group on the account; GROUP_ID was the only thing narrowing that and
defaulted to "". Config refuses to start unscoped, direct messages are
dropped explicitly rather than by a falsy check, and a scenario asserts that
DMs and other groups produce zero outbound messages.
Offline environment: fake_signal/ serves the real protocol surface, so the
unmodified bot connects to it by pointing API_BASE_URL at it. scripts/e2e.sh
boots both, replays 7 scenarios and exits non-zero on mismatch. A local
Signal server is not achievable (signal-cli compiles its endpoints and trust
store in; Signal-Server needs FoundationDB), so faking this boundary is the
only way to test every feature without an account.
Transport pinned to bbernhard/signal-cli-rest-api:0.100 with
MODE=json-rpc-native. The readme pinned 0.167-dev; the dev tag series counts
separately, so that was older than 0.100, not newer. /v1/receive is only a
WebSocket in a json-rpc mode, so the mode is verified at startup.
Repo standards: ruff select=ALL, mypy --strict, 189 tests at 100% branch
coverage, 250-line cap, exact pins at newest stable, shared gates delegated
to ~/utils, one CI workflow replacing three red ones. No noqa, no
type: ignore, no coverage omits anywhere.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
94 lines
3.0 KiB
Python
94 lines
3.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""SQLite persistence, including survival across a restart."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from signal_bot.store import Store, open_store
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
def test_increment_creates_and_accumulates(store: Store) -> None:
|
|
store.increment("u1", "Alice")
|
|
store.increment("u1", "Alice")
|
|
store.increment("u2", "Bob")
|
|
assert [(t.display_name, t.count) for t in store.tallies()] == [("Alice", 2), ("Bob", 1)]
|
|
|
|
|
|
def test_display_name_is_refreshed(store: Store) -> None:
|
|
store.increment("u1", "Alice")
|
|
store.increment("u1", "Alicja")
|
|
assert store.tallies()[0].display_name == "Alicja"
|
|
|
|
|
|
def test_tallies_sorted_by_count_then_name(store: Store) -> None:
|
|
store.increment("u1", "Zoe")
|
|
store.increment("u2", "Adam")
|
|
assert [t.display_name for t in store.tallies()] == ["Adam", "Zoe"]
|
|
|
|
|
|
def test_reset_clears_everything(store: Store) -> None:
|
|
store.increment("u1", "Alice")
|
|
store.reset_tallies()
|
|
assert store.tallies() == []
|
|
|
|
|
|
def test_tallies_survive_a_restart(tmp_path: Path) -> None:
|
|
"""The old bot kept the day's tally in a module global."""
|
|
db = str(tmp_path / "bot.sqlite3")
|
|
with open_store(db) as first:
|
|
first.increment("u1", "Alice")
|
|
with open_store(db) as second:
|
|
assert second.tallies()[0].count == 1
|
|
|
|
|
|
def test_last_used_is_none_before_first_use(store: Store) -> None:
|
|
assert store.last_used("u1", "cat") is None
|
|
|
|
|
|
def test_record_use_tracks_cooldown_and_daily(store: Store) -> None:
|
|
store.record_use("u1", "cat", 100.0, "2026-08-29")
|
|
assert store.last_used("u1", "cat") == 100.0
|
|
assert store.uses_today("u1", "cat", "2026-08-29") == 1
|
|
store.record_use("u1", "cat", 200.0, "2026-08-29")
|
|
assert store.last_used("u1", "cat") == 200.0
|
|
assert store.uses_today("u1", "cat", "2026-08-29") == 2
|
|
|
|
|
|
def test_daily_counter_is_per_day(store: Store) -> None:
|
|
store.record_use("u1", "cat", 100.0, "2026-08-29")
|
|
assert store.uses_today("u1", "cat", "2026-08-30") == 0
|
|
|
|
|
|
def test_uses_today_is_per_user_and_command(store: Store) -> None:
|
|
store.record_use("u1", "cat", 100.0, "2026-08-29")
|
|
assert store.uses_today("u2", "cat", "2026-08-29") == 0
|
|
assert store.uses_today("u1", "dog", "2026-08-29") == 0
|
|
|
|
|
|
def test_votes_are_deduplicated_per_person(store: Store) -> None:
|
|
store.add_vote("traps", "u1", 100.0)
|
|
store.add_vote("traps", "u1", 101.0)
|
|
store.add_vote("traps", "u2", 102.0)
|
|
assert store.count_votes("traps", 0.0) == 2
|
|
|
|
|
|
def test_votes_outside_the_window_are_ignored(store: Store) -> None:
|
|
store.add_vote("cmd", "u1", 100.0)
|
|
assert store.count_votes("cmd", 150.0) == 0
|
|
|
|
|
|
def test_clear_votes(store: Store) -> None:
|
|
store.add_vote("cmd", "u1", 100.0)
|
|
store.clear_votes("cmd")
|
|
assert store.count_votes("cmd", 0.0) == 0
|
|
|
|
|
|
def test_store_is_a_context_manager(tmp_path: Path) -> None:
|
|
with Store(str(tmp_path / "x.sqlite3")) as opened:
|
|
opened.increment("u1", "Alice")
|
|
assert opened.tallies.__self__ is opened
|