mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:07:29 +01:00
Krzysztof kuhy Rudnicki
0717df646a
The registry used to be built once, inline in build_bot, so every change to the data behind it -- a person tagged in the web UI, an alias, soon a command switched off from the management page -- meant restarting the unit. That is cheap and lossless, but it is a deploy step somebody has to remember, and a 21:37 report can land in the middle of it. Now the registration sequence lives in wiring.build_registry, and RegistryHolder runs it again on POST /_reload: the new table is built whole and swapped in with one assignment, never patched in place, so a duplicate trigger is found before anything the dispatcher reads has changed. Bad data (ConfigError, DuplicateTriggerError) keeps the previous table and answers 409 with the reason; a programming error still surfaces as a 500. scripts/reload.sh wraps it, with --code for the restart a Python change needs, and an optional command to type in testbot so "reloaded" means "answered". No Python hot-reload on purpose. The loader change is what makes deploying this safe: two rows in the live tags.json name files that are no longer in media/, and load_pack refused them, so the next restart would have looped on ConfigError. A stale tag is drift in a file a page edits mid-session, not a broken album -- it is now skipped with a warning naming it. A tag that reaches outside the album is still refused. pack_load.py split at the 250-line cap; pack_tags.py is the half whose checks are not all fatal. Proven offline in scripts/e2e.sh: !delta is unknown, a fifth person is tagged into the synthetic pack, scripts/reload.sh runs, and the same process posts delta's photo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
57 lines
2.0 KiB
Python
57 lines
2.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The mutable box: a swap that works, and one that must not take the bot down."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
|
|
from signal_bot.pack_holder import PackHolder
|
|
from signal_bot.pack_load import load
|
|
from tests import pack_fixture
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
def test_a_reload_publishes_what_is_now_on_disk(tmp_path: Path) -> None:
|
|
root = pack_fixture.build(tmp_path / "pack")
|
|
holder = PackHolder(load(root))
|
|
assert holder.pack.matching(frozenset({"p3"})) == ("gamma.png",)
|
|
|
|
(root / "media" / "extra.png").write_bytes(pack_fixture.PIXEL)
|
|
tags = json.loads((root / "tags.json").read_text(encoding="utf-8"))
|
|
tags["extra.png"] = ["p3"]
|
|
(root / "tags.json").write_text(json.dumps(tags), encoding="utf-8")
|
|
|
|
assert holder.reload() is True
|
|
assert holder.pack.matching(frozenset({"p3"})) == ("extra.png", "gamma.png")
|
|
|
|
|
|
def test_a_pack_that_no_longer_loads_keeps_the_old_one_and_does_not_raise(
|
|
tmp_path: Path, caplog: pytest.LogCaptureFixture
|
|
) -> None:
|
|
"""Restart=always turns a raised ConfigError into a restart loop."""
|
|
root = pack_fixture.build(tmp_path / "pack")
|
|
holder = PackHolder(load(root))
|
|
before = holder.pack
|
|
|
|
# Half a write: exactly what a page interrupted mid-save leaves behind.
|
|
# (A tag naming a vanished file used to be the example here; since
|
|
# 2026-09-04 that is skipped with a warning rather than refused.)
|
|
(root / "tags.json").write_text('{"alfa.png": ["p1"', encoding="utf-8")
|
|
|
|
assert holder.reload() is False
|
|
assert holder.pack is before
|
|
assert holder.pack.matching(frozenset({"p1"})) == ("alfa.png", "both.png", "clip.mp4")
|
|
assert "no longer loads" in caplog.text
|
|
|
|
|
|
def test_the_holder_reloads_from_the_directory_it_already_has(tmp_path: Path) -> None:
|
|
root = pack_fixture.build(tmp_path / "pack")
|
|
holder = PackHolder(load(root))
|
|
assert holder.reload() is True
|
|
assert holder.pack.directory == root
|