mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:37:03 +01:00
Krzysztof kuhy Rudnicki
a202317072
A "!cat" in a busy group produced a cat picture floating loose in the chat with
nothing tying it to whoever asked. Replies now quote the triggering message.
The container advertises this and always could: /v1/about reports
capabilities {"v2/send": ["quotes", "mentions"]}, and /v2/send takes
quote_timestamp, quote_author and quote_message. What was missing was on this
side -- parse_envelope discarded the envelope's timestamp, which is the id
Signal quotes a message by, so nothing downstream could have built a quote even
in principle. IncomingMessage now carries it, preferring the payload's own
value over the envelope's for the case where they ever disagree.
Quote is a value object rather than three more parameters threaded through
every send: the Transport protocol has five methods and two of them send.
CommandContext grows reply_image() so quoting lives in one place instead of
each handler reaching for ctx.transport itself, which is what animals.py did.
quote_of() returns None when the timestamp or author is missing. Answering the
room is a worse reply than a quoted one but a much better outcome than a
payload the container rejects.
The e2e gate learned to tell the two apart: Expectation.quotes demands a send
either does or does not point at a message, defaulting to None so the ten
existing scenarios stay indifferent. Without it the fake would have accepted an
unquoted reply as a pass.
Verified in the testbot group on a real Signal client before this bump, per
kuhy's rule that a bump is a publish rather than a checkpoint: he sent !cat and
confirmed the picture renders attached to his message as a reply.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015d48t4qsQLBJnDwDeo2Nom
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| __main__.py | ||
| aliases.json | ||
| animals.py | ||
| announce.py | ||
| app.py | ||
| changelog.py | ||
| config.py | ||
| counting.py | ||
| decorators.py | ||
| discovery.py | ||
| dispatcher.py | ||
| groups.py | ||
| http_client.py | ||
| liveness.py | ||
| membership.py | ||
| models.py | ||
| popes.json | ||
| portcheck.py | ||
| quoting.py | ||
| registry.py | ||
| scheduler.py | ||
| schema.py | ||
| store.py | ||
| transport_base.py | ||
| transport_fake.py | ||
| transport_rest.py | ||
| trust.py | ||
| versioning.py | ||