mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 18:17:02 +01:00
Krzysztof kuhy Rudnicki
a24d0d5905
./web.sh serves health, the configuration and the photo album on 127.0.0.1:8140 -- the port tool/tagger.py vacates. React 19, Vite 8, TypeScript 6.0.3, ESLint 10 with strictTypeChecked + stylisticTypeChecked + unicorn + sonarjs + perfectionist, Vitest 4 at 100% on all four metrics. No coverage exclude list, including for main.tsx. This repository treats a coverage omit as a suppression, and "the DOM bootstrap is awkward to assert" is the same sentence as "this code is untested" -- so the bootstrap is a shim thin enough to test in jsdom, and the album view holds its file list apart from the album so the update path stopped carrying a "what if it is null" branch that cannot happen. An untestable branch is an untested one. TypeScript stays at 6.0.3: typescript-eslint 8.68.0 declares typescript >=4.8.4 <6.1.0, and the fleet-wide allowlist entry says the compiler waits for the linter. The freshness gate then caught two pins the reference repo was carrying stale -- eslint-plugin-unicorn 73 -> 74 and a floating node-version: "24" in CI -- both bumped rather than allowlisted. Traps the gates found, all of them real: - .gitignore has a bare lib/, which matches at any depth, so web/src/lib/ would have been silently untracked. The source lives in src/api/. - CI's shellcheck glob was `run.sh scripts/*.sh`, so tag.sh was unlinted in CI for its whole life and web.sh would have inherited that. Now ./*.sh. - tsconfig.json is strict JSON, not JSONC: check-json is generic and tsconfig being commentable is a convention, not a requirement. - The personal-data gate refused an invented phone number in a test, which is exactly what it is for. The album's warning that names a command moved with the command, and every path that pointed at tool/tagger.py now points at ./web.sh. The historical mentions stay: they explain why the code is shaped as it is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01416TegJ3sa8xL5qGGgrygP
62 lines
2.4 KiB
Python
62 lines
2.4 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The one mutable box the pack lives in, so a new photo is visible at once.
|
|
|
|
``pack_command.pack_handler`` used to close over a frozen ``Pack``. That was
|
|
right while the only writer was the tagging page and a restart followed
|
|
every change; with ``!add_photo`` it means a photo somebody just added stays
|
|
invisible to their own command until the unit is restarted. Every pack
|
|
handler therefore reads ``holder.pack`` at call time instead of capturing it.
|
|
|
|
What a swap may and may not change is the load-bearing part. Custom tags
|
|
never become commands, so a swap only ever replaces *Pack data* -- it never
|
|
re-registers a trigger and never recomputes ``Command.groups``. That is what
|
|
makes immediate availability cheap, and it is the property to preserve: the
|
|
moment a swap could add a command, it could also add one to the wrong group.
|
|
|
|
``reload`` never raises. A handler that raised here would take the exception
|
|
to the dispatcher, which logs and moves on -- but the album would already be
|
|
half-swapped, and ``Restart=always`` turns a startup-time ConfigError into a
|
|
loop. Failing back onto the pack that was already working is the only
|
|
behaviour that degrades safely.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from dataclasses import dataclass
|
|
from typing import TYPE_CHECKING
|
|
|
|
from signal_bot.groups import ConfigError
|
|
from signal_bot.pack_load import load
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.pack import Pack
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@dataclass(slots=True)
|
|
class PackHolder:
|
|
"""A mutable reference to the album every handler reads through."""
|
|
|
|
pack: Pack
|
|
|
|
def reload(self) -> bool:
|
|
"""Re-read the album from disk and publish it if it is servable.
|
|
|
|
Returns:
|
|
True when the new pack is live, False when the old one is still
|
|
being served because the directory no longer loads.
|
|
"""
|
|
directory = self.pack.directory
|
|
try:
|
|
fresh = load(directory)
|
|
except ConfigError:
|
|
# The path that keeps the bot alive after a bad write: the files
|
|
# are rolled back by the caller and the album in memory is the
|
|
# one that was already answering.
|
|
logger.exception("photo pack %s no longer loads; keeping the previous one", directory)
|
|
return False
|
|
self.pack = fresh
|
|
return True
|