mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-11 12:27:52 +01:00
Krzysztof kuhy Rudnicki
b48c945d89
First live reply, as its own registered account. `!cat` and `!dog` from the
phone return images -- verified in the production shape (the bot *invited to
an already-existing group*) and under a systemd user unit.
Four failures, each of which left the bot looking perfectly healthy:
- Invited is not joined. Signal only adds an account outright if the adder
holds its profile key; with no profile the add becomes a pending invite,
and signal-cli cannot accept one addressed to a phone number ("Cannot find
service ID for self"). Group listed, websocket up, /healthz OK, zero
messages. register_bot.sh now sets the profile *before* the add, and
startup refuses on `member: false`.
- MODE=json-rpc-native is a GraalVM build with no AWT: text sends work,
every attachment 400s with "Can't load library: awt". Both mode guards now
demand exactly json-rpc, and start_container replaces a wrong-mode
container instead of reusing it.
- The API spells one group two ways -- /v1/groups returns `group.<base64>`,
envelopes carry what that decodes to -- so the scoping gate rejected the
bot's own group. e2e.sh now models both spellings; reverting the fix fails
4 scenarios, which is why the offline suite missed it before.
- BIND_PORT in .env was dead: __main__ read os.getenv before anything loaded
a .env. The bind address comes from Config now.
A taken port used to be uvicorn logging the collision and exiting 0, which
every supervisor reads as success. portcheck.py refuses to start, exits
non-zero, and names the holder by reading /proc directly -- no subprocess, no
PATH assumptions, testable against a fake proc tree. Default port is 8137:
not 8000, and below the ephemeral range so the kernel cannot take it.
The bot now runs as signal-bot.service (Restart=always, linger checked rather
than assumed, StartLimitBurst so a config error fails visibly instead of
looping). Verified by SIGKILL and by re-running a command under the unit.
100% branch coverage, 230 tests, all gates green.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
39 lines
1.3 KiB
Desktop File
39 lines
1.3 KiB
Desktop File
# Installed to ~/.config/systemd/user/ by scripts/install_service.sh, which
|
|
# substitutes @REPO_ROOT@. Edit this template, never the installed copy.
|
|
|
|
[Unit]
|
|
Description=Signal group bot
|
|
Documentation=file://@REPO_ROOT@/README.md
|
|
# The bot's only outbound dependency is signal-cli-rest-api in Docker. That
|
|
# container runs --restart=always, so it comes back by itself, but Docker has
|
|
# to exist before the bot's first connection attempt.
|
|
After=network-online.target docker.service
|
|
Wants=network-online.target
|
|
# A config error -- missing GROUP_ID, a port that is taken -- exits non-zero
|
|
# instantly, and would otherwise spin forever at RestartSec. Five failures in
|
|
# a minute stops the unit in `failed` state, which is visible in `systemctl
|
|
# --user status`, instead of hiding as a permanent restart loop.
|
|
StartLimitIntervalSec=60
|
|
StartLimitBurst=5
|
|
|
|
[Service]
|
|
Type=exec
|
|
WorkingDirectory=@REPO_ROOT@
|
|
# run.sh execs the interpreter, so this PID is the bot itself.
|
|
ExecStart=@REPO_ROOT@/run.sh
|
|
# `always`, not `on-failure`: this process has no correct reason to exit 0.
|
|
Restart=always
|
|
RestartSec=5
|
|
# The bot writes only its SQLite tally database, inside the repo.
|
|
NoNewPrivileges=true
|
|
PrivateTmp=true
|
|
ProtectSystem=strict
|
|
ProtectHome=read-only
|
|
ReadWritePaths=@REPO_ROOT@
|
|
ProtectKernelTunables=true
|
|
ProtectControlGroups=true
|
|
RestrictSUIDSGID=true
|
|
|
|
[Install]
|
|
WantedBy=default.target
|