mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-22 11:52:30 +01:00
First live reply, as its own registered account. `!cat` and `!dog` from the
phone return images -- verified in the production shape (the bot *invited to
an already-existing group*) and under a systemd user unit.
Four failures, each of which left the bot looking perfectly healthy:
- Invited is not joined. Signal only adds an account outright if the adder
holds its profile key; with no profile the add becomes a pending invite,
and signal-cli cannot accept one addressed to a phone number ("Cannot find
service ID for self"). Group listed, websocket up, /healthz OK, zero
messages. register_bot.sh now sets the profile *before* the add, and
startup refuses on `member: false`.
- MODE=json-rpc-native is a GraalVM build with no AWT: text sends work,
every attachment 400s with "Can't load library: awt". Both mode guards now
demand exactly json-rpc, and start_container replaces a wrong-mode
container instead of reusing it.
- The API spells one group two ways -- /v1/groups returns `group.<base64>`,
envelopes carry what that decodes to -- so the scoping gate rejected the
bot's own group. e2e.sh now models both spellings; reverting the fix fails
4 scenarios, which is why the offline suite missed it before.
- BIND_PORT in .env was dead: __main__ read os.getenv before anything loaded
a .env. The bind address comes from Config now.
A taken port used to be uvicorn logging the collision and exiting 0, which
every supervisor reads as success. portcheck.py refuses to start, exits
non-zero, and names the holder by reading /proc directly -- no subprocess, no
PATH assumptions, testable against a fake proc tree. Default port is 8137:
not 8000, and below the ephemeral range so the kernel cannot take it.
The bot now runs as signal-bot.service (Restart=always, linger checked rather
than assumed, StartLimitBurst so a config error fails visibly instead of
looping). Verified by SIGKILL and by re-running a command under the unit.
100% branch coverage, 230 tests, all gates green.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yaBT45KhHqxTKVCTA87iy
47 lines
1.7 KiB
Python
47 lines
1.7 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Which messages count toward the daily tally, and which chats we listen to."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
if TYPE_CHECKING:
|
|
from signal_bot.config import Config
|
|
from signal_bot.models import IncomingMessage
|
|
|
|
|
|
def is_watched_group(message: IncomingMessage, config: Config) -> bool:
|
|
"""True only for messages from the one group the bot is scoped to.
|
|
|
|
A linked Signal device receives every direct conversation and every group
|
|
on the account. This predicate is the entire boundary between "a bot in
|
|
one group" and "a bot reading all of your chats", so it is deliberately
|
|
written as an explicit group-id membership test rather than a falsy
|
|
check: a direct message has no group id at all and must never reach a
|
|
handler. The set, rather than a single ==, is because the REST API
|
|
spells the same group two ways -- see Config.watched_group_ids.
|
|
"""
|
|
if message.group_id is None:
|
|
return False
|
|
return message.group_id in config.watched_group_ids
|
|
|
|
|
|
def should_count(message: IncomingMessage) -> bool:
|
|
"""True when a message should add to its sender's tally.
|
|
|
|
Reactions and stickers are not messages for tally purposes, and a frame
|
|
with no text body carries nothing to count.
|
|
"""
|
|
if message.is_reaction or message.has_sticker:
|
|
return False
|
|
return bool(message.text)
|
|
|
|
|
|
def format_tally(rows: list[tuple[str, int]]) -> str:
|
|
"""Render the daily report, or a placeholder when nobody spoke."""
|
|
if not rows:
|
|
return "Brak wiadomosci dzisiaj."
|
|
width = max(len(name) for name, _ in rows)
|
|
lines = [f"{name.ljust(width)} {count}" for name, count in rows]
|
|
return "\n".join(lines)
|