signal-bot/tool/e2e_fixtures.py
Krzysztof kuhy Rudnicki 48957a105d
Some checks are pending
CI / check (push) Waiting to run
feat: serve several photo albums at once, each scoped to its own groups
You asked for !add_photo in testbot without the real album being reachable
there. One album cannot do that: its people.json "groups" list *is* the
privacy guarantee, so making the commands exist in a second group necessarily
makes the real photos postable there. So the bot now loads several albums.

PHOTO_PACK_DIR takes a comma-separated list, the spelling GROUP_IDS and
TRUSTED_INVITERS already use. Each album carries its own group scope, its own
people, its own tags and its own custom labels; they share nothing but the
process they run in.

That makes trigger collisions between albums legal for the first time, and the
registry had to learn it. Two albums are two different sets of people and both
may reasonably call somebody "!alfa" -- no message can ever mean both, because
a command a group is not scoped to is not a command there at all. So a trigger
may be claimed more than once, and DuplicateTriggerError now fires only where
the group sets *overlap*. Overlapping albums are refused at startup rather than
resolved by registration order: a coin toss about which private album receives
a photo is the outcome this whole design exists to prevent.

Two consequences worth naming:

- registry.resolve() takes an optional group. Without one it still answers
  "does anything claim this word", which is what pack_add's mint check wants;
  with one it answers "what runs here", which is what the dispatcher wants.
  resolve_with_args no longer resolves-then-checks, because with two claimants
  the first one found may be the wrong group's.
- CommandContext moved to signal_bot/context.py to keep registry.py under the
  250-line cap. A filing change: that file is "which word runs what", this one
  is "what the thing that runs may do".

DOCS-add-photo.md is likewise a split, not new prose -- DOCS-photo-pack.md had
grown past the cap and the ingest path is its own subject now.

Verified live: the unit serves both albums, the real group resolves its 13
album commands and testbot its 7, and !losowe / !alfa / !dodaj all fire in
testbot through the live dispatcher. 997 tests, 100% branch coverage, 28 e2e
scenarios.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JqqE22jp94B1ypwxppdr1o
2026-08-31 11:58:50 +02:00

185 lines
5.4 KiB
Python
Executable File

#!/usr/bin/env python3
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
"""Generating the media scripts/e2e.sh feeds to !add_photo.
Split out of e2e_media.py at the 250-line cap. Nothing here is committed as a
file: a fixture photo in this repository is exactly what the binary gate and
the personal-data gate exist to prevent, so every sample is built at run time
and carries *real* metadata -- a real APP1 Exif segment, a real QuickTime
geotag, a real HEVC parameter set. A file with nothing to strip proves nothing.
"""
from __future__ import annotations
import tempfile
from pathlib import Path
from typing import Final
from signal_bot.external import run
# Warsaw, in an actual GPS tag. If any of this survives, the run must fail.
LATITUDE: Final = "52.2297"
LONGITUDE: Final = "21.0122"
PROBE_MAKE: Final = "SecretPhoneModel"
PROBE_CREATOR: Final = "A Real Person Name"
# An SVG carrying both things exiftool cannot help with: a metadata block and
# a whole embedded raster. Stored as-is, per the decision recorded in
# DOCS-add-photo.md -- this exists so the e2e run *demonstrates* that hole
# rather than leaving it to the prose.
SVG_DOCUMENT: Final = (
'<?xml version="1.0"?>'
'<svg xmlns="http://www.w3.org/2000/svg" width="8" height="8">'
f"<metadata>{PROBE_CREATOR}</metadata>"
'<rect width="8" height="8" fill="teal"/>'
"</svg>"
).encode()
# Not a media file in any sense. The sniffer must refuse it on the bytes.
JUNK: Final = b"this is not a photo, it is a text file pretending to be one\n"
class ToolError(RuntimeError):
"""An external tool this script needs did not do its job."""
def run_tool(command: list[str]) -> str:
"""Run a tool and return its stdout, failing loudly if it errors.
Goes through signal_bot.external like everything else that starts a
process, and turns its "ok=False" into an exception because this is a
script: there is nothing to degrade to.
"""
result = run(command)
if not result.ok:
msg = f"{command[0]} failed: {result.stderr.strip()}"
raise ToolError(msg)
return result.stdout
def _jpeg(workspace: Path, name: str, colour: str) -> bytes:
"""A JPEG with a real APP1 Exif segment: GPS, Make and an XMP creator."""
path = workspace / f"{name}.jpg"
run_tool(
[
"ffmpeg",
"-loglevel",
"error",
"-f",
"lavfi",
"-i",
f"color=c={colour}:s=48x48:d=1",
"-frames:v",
"1",
str(path),
"-y",
]
)
run_tool(
[
"exiftool",
"-q",
"-overwrite_original",
f"-GPSLatitude={LATITUDE}",
"-GPSLatitudeRef=N",
f"-GPSLongitude={LONGITUDE}",
"-GPSLongitudeRef=E",
f"-Make={PROBE_MAKE}",
f"-XMP:Creator={PROBE_CREATOR}",
str(path),
]
)
return path.read_bytes()
def _mp4(workspace: Path) -> bytes:
"""An MP4 geotagged the way a phone does it: a QuickTime atom, not GPS.
This is the case a naive "-Exif:all -GPS:all -XMP:all" gate passes
straight through, because exiftool files the atom under QuickTime.
"""
path = workspace / "clip.mp4"
run_tool(
[
"ffmpeg",
"-loglevel",
"error",
"-f",
"lavfi",
"-i",
"color=c=navy:s=48x48:d=1",
"-c:v",
"libx264",
"-pix_fmt",
"yuv420p",
str(path),
"-y",
]
)
run_tool(
[
"exiftool",
"-q",
"-overwrite_original",
f"-QuickTime:GPSCoordinates={LATITUDE} {LONGITUDE} 0",
f"-XMP:Creator={PROBE_CREATOR}",
str(path),
]
)
return path.read_bytes()
def _heic(workspace: Path) -> bytes:
"""A geotagged HEIC -- what an iPhone actually sends.
Its HEVC parameter set survives the strip and is on the allowlist; the
GPS and the Make must not survive, and verify_pack re-reads the stored
file to prove it.
"""
path = workspace / "shot.heic"
source = workspace / "heic-source.jpg"
run_tool(
[
"ffmpeg",
"-loglevel",
"error",
"-f",
"lavfi",
"-i",
"color=c=teal:s=48x48:d=1",
"-frames:v",
"1",
str(source),
"-y",
]
)
run_tool(["heif-enc", str(source), "-o", str(path)])
run_tool(
[
"exiftool",
"-q",
"-overwrite_original",
f"-GPSLatitude={LATITUDE}",
"-GPSLatitudeRef=N",
f"-Make={PROBE_MAKE}",
f"-XMP:Creator={PROBE_CREATOR}",
str(path),
]
)
return path.read_bytes()
def build() -> dict[str, bytes]:
"""Every attachment the scenarios reference, by the id they name."""
with tempfile.TemporaryDirectory(prefix="e2e-media-") as raw:
workspace = Path(raw)
return {
"att-person": _jpeg(workspace, "person", "orange"),
"att-custom": _jpeg(workspace, "custom", "purple"),
"att-second": _jpeg(workspace, "second", "green"),
"att-video": _mp4(workspace),
"att-heic": _heic(workspace),
"att-svg": SVG_DOCUMENT,
"att-junk": JUNK,
}