mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:17:02 +01:00
Krzysztof kuhy Rudnicki
d5c63b423b
Today the bot was up, healthy and answering nothing for three hours. A host
firewall change (fixed in testsAndMisc 334c0cd9) cut every Docker container
off the internet; signal-cli lost Signal and reconnected in a loop from
15:32:50 onward. Nothing noticed:
- the container's own healthcheck answered 204
- /v1/groups answered 200 out of local state, so discovery saw no change
- the bot's WebSocket to the container stayed OPEN, so the transport's
reconnect logic never fired
- /healthz answered {"status": "ok"} the entire time
The only symptom was silence, which is also what a quiet evening looks like.
signal_bot/liveness.py asks the one question that cannot be answered from a
cache -- GET /v1/devices, which needs a live round trip -- but only after
SILENCE_SECONDS (120) with no frame of any kind, so a busy group costs
nothing and an idle one costs one request per window. Three consecutive
failures and /healthz answers 503 with the reason. Verified end to end in
scripts/e2e.sh against the real process: 503 after 84s with the fake's
connection cut, back to 200 on its own 30s after restoring it.
scripts/signal_api_watchdog.sh + a two-minute user timer do the recovery the
bot cannot do for itself, since a wedged bot cannot restart the container it
depends on. Two tiers, so the steady state costs no Signal round trip at
all: the bot's own /healthz first, the authenticated probe only when that is
not 200. It stops after 3 restarts in 6 hours and escalates instead -- a
deregistered account or a blocked network is not fixable by restarting, and
a restart loop would hide it. Its own bash suite stubs curl and docker and
drives every branch including the give-up cap.
signal_bot/trust.py answers the other half: TRUSTED_INVITERS decides who may
put this bot in a group. The gate sits in GroupDirectory._permitted, which
both _join_pending and _adopt already route through -- gating only invites
would gate the door nobody uses, since prime_profile.sh exists precisely so
that an add becomes a direct join. Evidence is either the group-update
envelope, which is the only frame naming an inviter, or a trusted identity
being a full member in the listing. A refusal is logged once, with that
group's members, so the operator can see which string to add.
verify_allowlist moved to membership.py to keep discovery.py under the
250-line gate; it was already the module that owns MembershipError.
Verified live, by stopping the container by hand and touching nothing else:
18:54:35 docker stop signal-api
18:56:36 liveness: failure 1 of 3 after 123s of silence
18:57:36 failure 3 of 3 -> /healthz answers 503 from 18:57:45
18:58:18 watchdog: probe failed (1/2)
19:00:28 watchdog: probe failed (2/2) -> docker restart signal-api
19:00:36 liveness: receive path recovered after 8 failed probe(s)
19:01:13 watchdog: signal-api is back
Six minutes, unattended, against three hours of silence this afternoon. All
four real groups are still adopted with TRUSTED_INVITERS=+48123456789 set,
and no group was refused.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KbjfWdAyHbCubac7wJKJZW
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""Shared mutable state for the fake server."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import base64
|
|
from dataclasses import dataclass, field
|
|
from typing import TYPE_CHECKING, Any, Final
|
|
|
|
if TYPE_CHECKING:
|
|
from fastapi import WebSocket
|
|
|
|
# A 1x1 PNG, inline so no binary file enters the repo.
|
|
PIXEL_PNG: Final = base64.b64decode(
|
|
"iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQ"
|
|
"GAhKmMIQAAAABJRU5ErkJggg=="
|
|
)
|
|
|
|
|
|
@dataclass
|
|
class State:
|
|
"""Everything the fake remembers between requests."""
|
|
|
|
sockets: list[WebSocket] = field(default_factory=list)
|
|
sent: list[dict[str, Any]] = field(default_factory=list)
|
|
attachments: list[str] = field(default_factory=list)
|
|
mode: str = "json-rpc"
|
|
base_url: str = "http://127.0.0.1:8099"
|
|
# Registration and group state, so the registration runbook can be
|
|
# rehearsed offline instead of first executing against real Signal.
|
|
accounts: list[str] = field(default_factory=list)
|
|
pending: dict[str, str] = field(default_factory=dict)
|
|
groups: list[dict[str, Any]] = field(default_factory=list)
|
|
# Whether signal-cli can reach Signal. False reproduces the 2026-08-29
|
|
# outage: local state still answers, anything needing a round trip 400s.
|
|
connection_alive: bool = True
|
|
|
|
def reset(self) -> None:
|
|
"""Forget captured sends and attachments."""
|
|
self.sent.clear()
|
|
self.attachments.clear()
|
|
|
|
def record_send(self, payload: dict[str, Any]) -> None:
|
|
"""Capture one outgoing message and mint ids for its attachments."""
|
|
self.sent.append(payload)
|
|
attachments = payload.get("base64_attachments") or []
|
|
for index in range(len(attachments)):
|
|
self.attachments.append(f"attach-{len(self.sent)}-{index}")
|