mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 19:27:20 +01:00
Krzysztof kuhy Rudnicki
da016e1b94
A photo sent to the chat no longer enters the album by itself. pack_add strips it, checks it against the album and the queue, and writes it to pending/ with a sidecar naming the people and labels the sender proposed; the reply is "czeka na zatwierdzenie". The management page lists the queue above the tagger, with the proposal pre-ticked, and Approve moves the file in, mints the labels, records approved_at and asks the bot to rebuild its table through /_reload -- the same publish path every other data change takes, so PackHolder.reload is gone. A reload the bot refuses is reported on the page, not rolled back: the photo is in the album either way. The personal-data gate now reads pending/*.json too, so a label that is still waiting for approval is forbidden in the tree already. The e2e run boots the management page beside the bot with the same environment, proves the queue is stripped and never reaches media/, approves it through the real routes, and has !losowe answer with the photo afterwards without a restart; exiftool is found through media_strip.locate() there rather than PATH, which lacks vendor_perl on Arch. !gadaj is dropped from !odcisz: it was within a typo of !dodaj, and the nearest-command suggestion must never be a coin toss. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""UNGATED is a second copy of a fact wiring.py expresses in code, so it is checked."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from dataclasses import replace
|
|
from typing import TYPE_CHECKING
|
|
|
|
from signal_bot.config import DEFAULT_COMMONS_API_URL
|
|
from signal_bot.portraits import PortraitCache
|
|
from signal_bot.wiring import UNGATED, build_registry
|
|
from tests import pack_fixture
|
|
from tests.test_help_command import _offline_fetcher
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
from signal_bot.config import Config
|
|
from signal_bot.registry import Handler
|
|
|
|
COOLDOWN_WRAPPER = "cooldown.<locals>.decorate.<locals>.wrapper"
|
|
|
|
|
|
def _has_cooldown(handler: Handler) -> bool:
|
|
"""Whether the cooldown decorator sits anywhere in a handler's wrapping.
|
|
|
|
``functools.wraps`` copies the inner function's ``__qualname__`` outward,
|
|
so the wrapper is recognisable only by its own code object, which wraps
|
|
leaves alone.
|
|
"""
|
|
current: object = handler
|
|
while current is not None:
|
|
code = getattr(current, "__code__", None)
|
|
if code is not None and code.co_qualname == COOLDOWN_WRAPPER:
|
|
return True
|
|
current = getattr(current, "__wrapped__", None)
|
|
return False
|
|
|
|
|
|
def test_ungated_names_exactly_the_commands_registered_without_a_cooldown(
|
|
config: Config, tmp_path: Path
|
|
) -> None:
|
|
"""With an album wired, because !add_photo is one of the ungated ones."""
|
|
fetcher = _offline_fetcher()
|
|
with_album = replace(config, photo_pack_dirs=(pack_fixture.build(tmp_path / "pack"),))
|
|
registry = build_registry(with_album, fetcher, PortraitCache(fetcher, DEFAULT_COMMONS_API_URL))
|
|
ungated = {c.name for c in registry.commands if not _has_cooldown(c.handler)}
|
|
assert ungated == set(UNGATED)
|