mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 20:37:03 +01:00
Krzysztof kuhy Rudnicki
dc1995b558
The tally was one integer per person, deleted after each post. Nothing dated survived it, so weeks, months, records, streaks and weekday averages were all unanswerable. This replaces it with an append-only per-message log holding metadata only -- never a message body -- and rebuilds the nightly report on top. What changes for the group: a photo posted without a caption now counts (it was worth zero), stickers count, the bot's own messages no longer do, people who said nothing appear with a 0, and the report covers the previous full calendar day in Europe/Warsaw instead of "since the last post" -- which used to merge two days whenever a group went quiet. Notable decisions, each with the trap it avoids: - Events and people are PERMANENT_TABLES: neither forget_group nor a future SCHEMA_VERSION bump may drop them. Both paths used to cost a day's counter and would now cost the entire history, and forget_group fires on a listing that merely omits members. - is_own comes from which envelope branch carried the payload, not from comparing identities. The account is spelled as a uuid on some frames and a +E.164 number on others, so any comparison misses one of them. - The roster is stashed in refresh(), not _adopt(), which returns early once the watched set stops changing -- i.e. always, in the steady state. - The roster matches on uuid OR number because /v1/groups spells kuhy as +48123456789 while his messages carry an ACI uuid. Joining on uuid alone would have listed him twice every night, once with 0. - Members whose display name we have never seen are counted, not named: their only spellings are a uuid or a phone number. - (group, uuid, sent_at_ms) is the primary key, so a websocket redelivery after a reconnect cannot inflate the counts. - Days come from a stored Warsaw date string, never a timestamp range: 2026-03-29 is 23 hours long and 2026-10-25 is 25. - Polish number agreement is a real rule with a 12-14 exception, so "44 znaki" and "45 znaków" are both spelled correctly. config.py and startup.py were two lines under the 250-line cap and both had to grow, so config_env and startup_retry come out of them first, as pure moves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015d48t4qsQLBJnDwDeo2Nom
118 lines
4.0 KiB
Python
118 lines
4.0 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The nightly block: exact text, and the line budget."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from signal_bot.stats.queries_day import DayRow, day_totals, with_silent
|
|
from signal_bot.stats.render_day import MAX_LINES, render_day, summary_line
|
|
|
|
# The real group, so the rendered example is a case that can actually occur.
|
|
GROUP = [
|
|
("Ala", 76, 12),
|
|
("Jan Nowak", 42, 3),
|
|
("kuhy", 38, 0),
|
|
("Basia", 33, 1),
|
|
("Franciszek Kowalczyk", 16, 0),
|
|
("Cezary Wiśniewski", 15, 0),
|
|
]
|
|
|
|
|
|
def rows(spec: list[tuple[str, int, int]], *, commands: int = 0) -> list[DayRow]:
|
|
"""Build day rows from (name, messages, media) triples."""
|
|
return [
|
|
DayRow(
|
|
uuid=f"u{i}",
|
|
display_name=name,
|
|
messages=messages,
|
|
media=media,
|
|
commands=commands if i == 0 else 0,
|
|
chars=messages * 47,
|
|
)
|
|
for i, (name, messages, media) in enumerate(spec)
|
|
]
|
|
|
|
|
|
def test_the_nightly_block_for_a_real_day() -> None:
|
|
"""Pinned exactly: this is the only assertion that proves the rendering."""
|
|
day_rows_ = with_silent(rows(GROUP), [("u9", "Marek")])
|
|
rendered = render_day(
|
|
"2026-09-01",
|
|
day_rows_,
|
|
day_totals(day_rows_),
|
|
since="2026-08-30",
|
|
highlights=["🏆 Ala 76 — rekord życiowy (poprzedni 71)"],
|
|
)
|
|
assert rendered == (
|
|
"📊 Wtorek, 1 września — 220 wiadomości (16 📷)\n"
|
|
"👑 Ala — 76 (12 📷)\n"
|
|
"2. Jan Nowak — 42 (3 📷)\n"
|
|
"3. kuhy — 38\n"
|
|
"4. Basia — 33 (1 📷)\n"
|
|
"5. Franciszek Kowalczyk — 16\n"
|
|
"6. Cezary Wiśniewski — 15\n"
|
|
"🏆 Ala 76 — rekord życiowy (poprzedni 71)\n"
|
|
"Cisza: Marek\n"
|
|
"Średnio 47 znaków.\n"
|
|
"(liczymy od 30 sierpnia)"
|
|
)
|
|
assert len(rendered.split("\n")) <= MAX_LINES
|
|
|
|
|
|
def test_a_day_with_no_media_shows_no_camera() -> None:
|
|
day = rows([("kuhy", 3, 0)])
|
|
rendered = render_day("2026-09-01", day, day_totals(day))
|
|
assert "📷" not in rendered
|
|
assert rendered.startswith("📊 Wtorek, 1 września — 3 wiadomości\n👑 kuhy — 3")
|
|
|
|
|
|
def test_commands_are_broken_out() -> None:
|
|
day = rows([("kuhy", 10, 0)], commands=4)
|
|
assert summary_line(day_totals(day)) == "Z tego 4 komendy, średnio 47 znaków."
|
|
|
|
|
|
def test_summary_is_empty_on_a_day_nobody_spoke() -> None:
|
|
assert summary_line(day_totals([])) == ""
|
|
assert day_totals([]).average_length == 0
|
|
|
|
|
|
def test_unnamed_members_are_counted_never_named() -> None:
|
|
"""Their only spellings are a uuid or a phone number; both would leak."""
|
|
day = with_silent(rows([("kuhy", 3, 0)]), [("u9", "Marek")])
|
|
rendered = render_day("2026-09-01", day, day_totals(day), unnamed=2)
|
|
assert "Cisza: Marek, i 2 osoby bez ani jednej wiadomości tutaj" in rendered
|
|
|
|
|
|
def test_a_big_group_is_truncated_and_still_fits() -> None:
|
|
"""The rule the current group size cannot reach, fixed before it can."""
|
|
big = rows([(f"Osoba {i:02d}", 30 - i, 0) for i in range(20)])
|
|
rendered = render_day(
|
|
"2026-09-01",
|
|
big,
|
|
day_totals(big),
|
|
since="2026-08-30",
|
|
highlights=["🏆 rekord", "👑 korona", "📅 wtorki"],
|
|
)
|
|
lines = rendered.split("\n")
|
|
assert len(lines) <= MAX_LINES
|
|
assert any(line.startswith("…i ") for line in lines)
|
|
# The reserved highlight slot survives the truncation.
|
|
assert "🏆 rekord" in rendered
|
|
|
|
|
|
def test_the_hidden_tail_reports_its_own_total() -> None:
|
|
day = rows([("A", 10, 0), ("B", 5, 0), ("C", 3, 0), ("D", 2, 0)])
|
|
rendered = render_day(
|
|
"2026-09-01",
|
|
day,
|
|
day_totals(day),
|
|
since="2026-08-30",
|
|
highlights=["h1", "h2", "h3"],
|
|
)
|
|
assert len(rendered.split("\n")) <= MAX_LINES
|
|
|
|
|
|
def test_a_custom_heading_replaces_the_date() -> None:
|
|
day = rows([("kuhy", 1, 0)])
|
|
rendered = render_day("2026-09-01", day, day_totals(day), heading="Dziś, na razie")
|
|
assert rendered.startswith("Dziś, na razie\n")
|