mirror of
https://github.com/kuhyx/signal-bot.git
synced 2026-11-10 21:37:03 +01:00
Krzysztof kuhy Rudnicki
f92502d18b
Release n is pope n, so the version is a fact about the ordinal rather than a judgement about the size of a change. The constraint that fixes the scheme is Jan Pawel II at 2.13.7: eight patches per minor with majors opening at ordinals 33 and 153 gives (264 - 153) = 13 * 8 + 7 exactly, and both earlier majors happen to divide evenly by eight too, so no bracket needs a fudge factor. The anchors are not arbitrary -- 33 is Sylwester I, pope through the Edict of Milan and Nicaea, and 153 is Wiktor II, the first pope elected after the 1054 schism. popes.json is scraped by tool/gen_popes.py rather than recalled, because antipopes, Benedykt IX's three separate reigns and the Stefan II question all shift the count and being wrong by one moves Jan Pawel II off 2.13.7 silently. The generator refuses to write a list that is not 267 contiguous entries with Jan Pawel II at 264. A second, independent parse of the same page agreed on every ordinal, which is the only reason to believe either. On startup each watched group is told about the releases it has not seen. A group with no record has seen none of them, so the first announcement starts at 0.0.0 "Swiety Piotr Apostol" rather than skipping to whatever is current -- watching the ladder start at Peter is the point of naming releases after popes. A group added years from now would otherwise be handed the whole backlog, so the message is capped at ten releases and says how many it left out. The version is recorded before the message is sent: with Restart=always and RestartSec=5, a crash between the two would re-announce on every restart, and a missed announcement is far cheaper than a looping one. DOCS-changelog.md is the single source -- the bot parses it, so there is no second machine-readable copy to drift. It is DOCS-, not CHANGELOG.md, because the md-naming gate allows four namespaces and that is not one of them. Deliberately NOT bumping SCHEMA_VERSION for the new group_meta table: _apply_schema drops every table on a bump, so bumping to add a table would have thrown away the live tallies to gain nothing. Verified against the real database -- group_meta appeared and all four counts survived the restart. The schema moves to its own module so store.py stays under the 250-line cap, and /healthz now names the build, because there was previously no way to ask a running bot which version it is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015d48t4qsQLBJnDwDeo2Nom
95 lines
3.1 KiB
Python
95 lines
3.1 KiB
Python
# Copyright (c) 2026 Krzysztof Rudnicki. MIT licence.
|
|
"""The pope ladder, and the one fixed point the whole scheme exists for."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import itertools
|
|
import json
|
|
import tomllib
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from signal_bot.versioning import (
|
|
POPE,
|
|
POPES,
|
|
RELEASE_ORDINAL,
|
|
__version__,
|
|
ordinal_for,
|
|
pope_for,
|
|
version_for,
|
|
)
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent
|
|
JOHN_PAUL_II = 264
|
|
|
|
|
|
def test_john_paul_ii_is_exactly_2_13_7() -> None:
|
|
"""The requirement the two ladder constants were solved for."""
|
|
assert version_for(JOHN_PAUL_II) == "2.13.7"
|
|
assert pope_for(JOHN_PAUL_II).name == "Jan Paweł II"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("ordinal", "version", "name"),
|
|
[
|
|
(1, "0.0.0", "Święty Piotr Apostoł"),
|
|
(2, "0.0.1", "Linus"),
|
|
(32, "0.3.7", "Milcjades"),
|
|
(33, "1.0.0", "Sylwester I"),
|
|
(152, "1.14.7", "Leon IX"),
|
|
(153, "2.0.0", "Wiktor II"),
|
|
(265, "2.14.0", "Benedykt XVI"),
|
|
(267, "2.14.2", "Leon XIV"),
|
|
],
|
|
)
|
|
def test_the_anchors_and_the_boundaries_either_side(ordinal: int, version: str, name: str) -> None:
|
|
assert version_for(ordinal) == version
|
|
assert pope_for(ordinal).name == name
|
|
|
|
|
|
def test_versions_never_go_backwards() -> None:
|
|
"""A ladder that is not monotonic is not a version scheme."""
|
|
ladder = [
|
|
tuple(int(part) for part in version_for(n).split(".")) for n in range(1, len(POPES) + 1)
|
|
]
|
|
assert all(earlier < later for earlier, later in itertools.pairwise(ladder))
|
|
|
|
|
|
@pytest.mark.parametrize("ordinal", [0, -1, 268, 9999])
|
|
def test_an_ordinal_off_the_list_is_refused(ordinal: int) -> None:
|
|
with pytest.raises(ValueError, match="no pope with ordinal"):
|
|
version_for(ordinal)
|
|
with pytest.raises(ValueError, match="no pope with ordinal"):
|
|
pope_for(ordinal)
|
|
|
|
|
|
def test_ordinal_for_is_the_inverse_of_version_for() -> None:
|
|
for ordinal in (1, 2, 33, 153, JOHN_PAUL_II, len(POPES)):
|
|
assert ordinal_for(version_for(ordinal)) == ordinal
|
|
|
|
|
|
def test_a_version_no_release_carries_is_refused() -> None:
|
|
with pytest.raises(ValueError, match="no release carries version"):
|
|
ordinal_for("9.9.9")
|
|
|
|
|
|
def test_this_build_names_itself() -> None:
|
|
assert __version__ == version_for(RELEASE_ORDINAL)
|
|
assert pope_for(RELEASE_ORDINAL) == POPE
|
|
|
|
|
|
def test_pyproject_agrees_with_the_ladder() -> None:
|
|
"""Two version sources with nothing reconciling them would drift silently."""
|
|
pyproject = tomllib.loads((REPO_ROOT / "pyproject.toml").read_text(encoding="utf-8"))
|
|
assert pyproject["project"]["version"] == version_for(RELEASE_ORDINAL)
|
|
|
|
|
|
def test_the_committed_pope_list_is_whole() -> None:
|
|
"""popes.json is generated; this is what stops a bad regeneration shipping."""
|
|
document = json.loads((REPO_ROOT / "signal_bot" / "popes.json").read_text(encoding="utf-8"))
|
|
entries = document["popes"]
|
|
assert len(entries) == 267
|
|
assert [entry["ordinal"] for entry in entries] == list(range(1, 268))
|
|
assert all(entry["name"] and entry["portrait"] and entry["reign"] for entry in entries)
|