Fix deploy exit 1 after PASS (RETURN trap)
Some checks are pending
md-naming / markdown naming convention (push) Waiting to run
pre-commit / pre-commit (${{ matrix.group }}) (mypy, mypy, ) (push) Waiting to run
pre-commit / pre-commit (${{ matrix.group }}) (pylint, pylint, ) (push) Waiting to run
pre-commit / pre-commit (${{ matrix.group }}) (rest, , mypy,pylint,dependency-freshness) (push) Waiting to run
Tests / test (push) Waiting to run
Tests / web-coverage (push) Waiting to run
repo-contract / repo contract (push) Waiting to run

sync_mcp_venv runs in the main shell, so its RETURN trap outlived the
function and fired again when main returned, with $log unset: set -u
turned a passing deploy into exit 1. Remove the temp log explicitly.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WzxdWWuLpGVY9MnowhTNcM
This commit is contained in:
Krzysztof Rudnicki 2026-11-22 14:28:52 +01:00
parent e0c6f967fe
commit 550e702b7a

View File

@ -65,11 +65,15 @@ preflight() {
sync_mcp_venv() {
local log
log="$(mktemp)"
trap 'rm -f "$log"' RETURN
# No RETURN trap: this runs in the main shell (not a $(...) like
# sync_units), where the trap outlives the function and later fires
# with $log unset.
if ! bash "$CHECKOUT/scripts/setup_mcp.sh" >"$log" 2>&1; then
cat "$log" >&2
rm -f "$log"
die "scripts/setup_mcp.sh failed: MCP venv not synced"
fi
rm -f "$log"
ok "mcp venv synced"
}