mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 13:47:31 +01:00
Krzysztof kuhy Rudnicki
b5b4b35c07
Each of these was one file doing several jobs, so they are split along what they actually do rather than at arbitrary line offsets: - _total_block: the lock file and the status derived from it stay in _total_block; making Steam *not installed* moves to _total_block_purge, making it *unreachable* to _total_block_hosts / _total_block_iptables. The generic pacman verbs (owner, installed, remove) become _pacman, since nothing about them is total-block-specific. Domain and process name tables become data modules. - _playtime: budget state and persistence (_playtime_state), pure transitions (_playtime_budget), cmdline process detection (_playtime_procs), the warn/cutoff/kill ladder (_playtime_cutoff), desktop notifications (_playtime_notify), process-tree walking and killing (_playtime_kill), mountinfo parsing (_playtime_mountinfo) and the shared privileged-command helper (_playtime_run). - _mcp: read-only tools (_mcp_query) split from mutating ones (_mcp_actions, _mcp_gaming_time), so "what can this server change?" is answerable from one file. _mcp keeps the server object and entry point. No re-export shims: callers import from the module that defines the name. That keeps a stale patch target loud (AttributeError) instead of letting it pass while intercepting nothing. `ruff check --select F821,F401` is run after every extraction -- an earlier mechanical attempt moved functions without the module-level names they referenced, which imported fine and only failed when called (349 errors), so it was reverted and redone by hand. The autouse fixtures in conftest are now imported by name and held by __all__; ruff --unsafe-fixes had deleted them as unused, since pytest resolves fixtures by name. 1324 tests pass at 100.00% coverage in the clean venv; `main status` is byte-identical to a worktree at HEAD. 49 -> 39 files over the cap. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPpmMpTSkp8UziRc5u8B7P
85 lines
3.0 KiB
Python
85 lines
3.0 KiB
Python
"""Tests for the generic pacman wrappers."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from steam_backlog_enforcer._pacman import (
|
|
is_package_installed,
|
|
pacman_owner,
|
|
uninstall_package,
|
|
)
|
|
|
|
PKG = "steam_backlog_enforcer._pacman"
|
|
|
|
|
|
class TestPacmanOwner:
|
|
"""Tests for pacman owner."""
|
|
|
|
def test_owned_path_returns_package_name(self) -> None:
|
|
"""Test that owned path returns package name."""
|
|
result = MagicMock(
|
|
returncode=0,
|
|
stdout="/usr/bin/prismlauncher is owned by prismlauncher-git 11.0.0-1\n",
|
|
)
|
|
with patch(f"{PKG}.subprocess.run", return_value=result):
|
|
assert pacman_owner("/usr/bin/prismlauncher") == "prismlauncher-git"
|
|
|
|
def test_unowned_path_returns_none(self) -> None:
|
|
"""Test that unowned path returns none."""
|
|
result = MagicMock(returncode=1, stdout="")
|
|
with patch(f"{PKG}.subprocess.run", return_value=result):
|
|
assert pacman_owner("/opt/foo/bar") is None
|
|
|
|
def test_unexpected_output_format_returns_none(self) -> None:
|
|
"""Test that unexpected output format returns none."""
|
|
result = MagicMock(returncode=0, stdout="something unexpected\n")
|
|
with patch(f"{PKG}.subprocess.run", return_value=result):
|
|
assert pacman_owner("/usr/bin/x") is None
|
|
|
|
|
|
class TestUninstallPackage:
|
|
"""Tests for uninstall package."""
|
|
|
|
def test_success(self) -> None:
|
|
"""Test that success."""
|
|
with patch(
|
|
f"{PKG}.subprocess.run", return_value=MagicMock(returncode=0, stderr="")
|
|
):
|
|
assert uninstall_package("foo") is True
|
|
|
|
def test_already_absent_treated_as_success(self) -> None:
|
|
"""Test that already absent treated as success."""
|
|
with patch(
|
|
f"{PKG}.subprocess.run",
|
|
return_value=MagicMock(returncode=1, stderr="error: target not found: foo"),
|
|
):
|
|
assert uninstall_package("foo") is True
|
|
|
|
def test_real_failure_returns_false(self) -> None:
|
|
"""Test that real failure returns false."""
|
|
with patch(
|
|
f"{PKG}.subprocess.run",
|
|
return_value=MagicMock(returncode=1, stderr="some other error"),
|
|
):
|
|
assert uninstall_package("foo") is False
|
|
|
|
def test_subprocess_error_returns_false(self) -> None:
|
|
"""Test that subprocess error returns false."""
|
|
with patch(f"{PKG}.subprocess.run", side_effect=OSError):
|
|
assert uninstall_package("foo") is False
|
|
|
|
|
|
class TestIsPackageInstalled:
|
|
"""Tests for is package installed."""
|
|
|
|
def test_installed(self) -> None:
|
|
"""Test that installed."""
|
|
with patch(f"{PKG}.subprocess.run", return_value=MagicMock(returncode=0)):
|
|
assert is_package_installed("protonup-qt") is True
|
|
|
|
def test_not_installed(self) -> None:
|
|
"""Test that not installed."""
|
|
with patch(f"{PKG}.subprocess.run", return_value=MagicMock(returncode=1)):
|
|
assert is_package_installed("protonup-qt") is False
|