steam-backlog-enforcer/steam_backlog_enforcer/tests/test_counted_procs.py
Krzysztof kuhy Rudnicki 1faf211767 Show which games make up the gaming budget, and bill osu!lazer
The budget tab answered "how much did I play" but not "what did I play":
playtime_state.json and playtime_history.json each stored one aggregate
seconds figure per gaming day, so the 14-day chart was a row of featureless
bars. Separately, qualifying_pids had exactly two sources — the SteamAppId
env var and a hardcoded 16-launcher frozenset — so osu!lazer, which sets no
SteamAppId and matches no launcher name, was never billed at all.

qualifying_pids now returns pid -> attribution key instead of a bare pid set.
The app id was already in hand and thrown away on its first line; it now
survives into PlaytimeState.per_game, alongside a user-editable
counted_processes list in config.json seeded with osu!lazer.

Two things the parts/whole relationship forces:

  - per_game only ever sums to AT MOST seconds, never equals it. backdate
    refunds the idle grace on every engaged-to-paused edge, and
    _state_or_recover synthesises a full budget with no breakdown. The
    refund is debited from last_credited_key, and the remainder is rendered
    as "Unattributed" rather than stored — one path then covers legacy days,
    focus-probe failures and drift alike.

  - counted_processes is kept apart from LAUNCHER_PROCESS_NAMES. That
    frozenset is also the total-block kill list, and it routes through
    kill_and_uninstall_launchers, which pacman -R's the owning package.
    Counted entries are killed on total block, never uninstalled.

Both storage formats stay at schema 1: load_state already filters to
dataclass fields, so a record without per_game migrates for free, and the
history reader has to accept both a bare float and an object regardless, so
a version bump would distinguish nothing.

Chart segments use the shared design system's categorical ramp (--cat-1..6),
capped at six games plus "Other" because a seventh distinguishable hue does
not exist under simulated CVD. The red over-budget fill is gone: colour now
encodes which game, and the dashed budget line alone says over or under.

Snapshot persistence moves to _snapshot.py to keep config.py under the
250-line cap. Three modules bound config paths at import time, which
bypasses the conftest redirect — they now reach them through the module.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MKFzwzwRU1JD7SFLHtQBsz
2026-08-29 18:32:03 +02:00

147 lines
5.2 KiB
Python

"""Tests for _counted_procs — 100% branch coverage.
The validation here is load-bearing rather than cosmetic: these names are fed
to the budget cutoff and the total-block killer, and `_playtime_kill` signals a
matched PID *and its descendants*. A name like `sh` would take the whole
session down with it.
"""
from __future__ import annotations
import json
from typing import TYPE_CHECKING
from steam_backlog_enforcer import config as config_mod
from steam_backlog_enforcer._counted_procs import (
DEFAULT_COUNTED_PROCESSES,
CountedProcess,
counted_process_names,
key_by_name,
kill_target_names,
labels_by_key,
load_counted_processes,
parse_counted_processes,
)
if TYPE_CHECKING:
from pathlib import Path
def _write(payload: object) -> None:
config_mod.CONFIG_FILE.write_text(json.dumps(payload), encoding="utf-8")
class TestParse:
"""Turning raw JSON into validated entries."""
def test_reads_a_well_formed_entry(self) -> None:
entries = parse_counted_processes(
[{"id": "osu-lazer", "label": "osu!lazer", "names": ["osu!", "osu-lazer"]}]
)
assert entries == (
CountedProcess(
id="osu-lazer",
label="osu!lazer",
names=frozenset({"osu!", "osu-lazer"}),
),
)
def test_label_defaults_to_the_id(self) -> None:
entries = parse_counted_processes([{"id": "quake", "names": ["quake"]}])
assert entries[0].label == "quake"
def test_rejects_a_non_list(self) -> None:
assert parse_counted_processes({"id": "x"}) == ()
def test_drops_a_non_object_entry(self) -> None:
assert parse_counted_processes(["nope"]) == ()
def test_drops_an_entry_with_no_id(self) -> None:
assert parse_counted_processes([{"names": ["x"]}]) == ()
def test_drops_an_entry_with_no_usable_names(self) -> None:
assert parse_counted_processes([{"id": "x", "names": []}]) == ()
def test_drops_an_entry_whose_names_are_not_a_list(self) -> None:
assert parse_counted_processes([{"id": "x", "names": "osu!"}]) == ()
def test_drops_a_duplicate_id(self) -> None:
entries = parse_counted_processes(
[
{"id": "x", "names": ["a"]},
{"id": "x", "names": ["b"]},
]
)
assert len(entries) == 1
assert entries[0].names == frozenset({"a"})
def test_ignores_non_string_and_blank_names(self) -> None:
entries = parse_counted_processes([{"id": "x", "names": ["a", 7, " ", None]}])
assert entries[0].names == frozenset({"a"})
def test_refuses_a_shell_or_interpreter_name(self) -> None:
"""`sh` would SIGTERM every shell on the system, and its children."""
entries = parse_counted_processes(
[{"id": "osu", "names": ["sh", "dotnet", "osu!"]}]
)
assert entries[0].names == frozenset({"osu!"})
def test_an_entry_of_only_forbidden_names_is_dropped(self) -> None:
assert parse_counted_processes([{"id": "osu", "names": ["sh"]}]) == ()
class TestLoad:
"""Reading straight from config.json, with no Config to consult."""
def test_missing_file_falls_back_to_defaults(self) -> None:
assert load_counted_processes() == DEFAULT_COUNTED_PROCESSES
def test_unreadable_file_falls_back_to_defaults(self) -> None:
config_mod.CONFIG_FILE.write_text("{not json", encoding="utf-8")
assert load_counted_processes() == DEFAULT_COUNTED_PROCESSES
def test_non_object_payload_falls_back_to_defaults(self) -> None:
_write([1, 2, 3])
assert load_counted_processes() == DEFAULT_COUNTED_PROCESSES
def test_absent_key_falls_back_to_defaults(self) -> None:
_write({"steam_id": "1"})
assert load_counted_processes() == DEFAULT_COUNTED_PROCESSES
def test_an_explicit_empty_list_means_none(self) -> None:
"""Distinct from absent: the user can switch the feature off."""
_write({"counted_processes": []})
assert load_counted_processes() == ()
def test_reads_a_configured_list(self) -> None:
_write({"counted_processes": [{"id": "q", "names": ["quake"]}]})
assert load_counted_processes()[0].id == "q"
def test_the_default_covers_every_osu_layer(self) -> None:
"""The sh wrapper, the AppImage and the game each exec a new comm."""
assert counted_process_names(DEFAULT_COUNTED_PROCESSES) == frozenset(
{"osu-lazer", "osu.AppImage", "osu!"}
)
class TestDerivedViews:
"""The three projections the billing and kill paths consume."""
_ENTRIES = (
CountedProcess(id="osu-lazer", label="osu!lazer", names=frozenset({"osu!"})),
)
def test_names_of_no_entries_is_empty(self) -> None:
assert counted_process_names(()) == frozenset()
def test_key_by_name(self) -> None:
assert key_by_name(self._ENTRIES) == {"osu!": "proc:osu-lazer"}
def test_labels_by_key(self) -> None:
assert labels_by_key(self._ENTRIES) == {"proc:osu-lazer": "osu!lazer"}
def test_kill_targets_come_from_the_config(self, tmp_path: Path) -> None:
assert tmp_path.exists()
_write({"counted_processes": [{"id": "q", "names": ["quake"]}]})
assert kill_target_names() == frozenset({"quake"})