mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 19:33:49 +01:00
Krzysztof kuhy Rudnicki
d6d9a2d1a6
The pinned howlongtobeatpy (1.0.23) takes a user agent in send_website_request_getcode and dropped parse_all_scripts; the call still matched 1.0.20, which only worked because the deployed env was behind its own pin. Now on the pinned API, and the env upgraded. Three modules carried the same executable/path constant block since the 250-line split; it is _store_tools. Four carried the same "restore the hours a refetch lost" loop; it is restore_prior_hours. Both detached launches go through one helper that returns the process. Thirteen try/except/else blocks are flat, dataclass fields come from dataclasses.fields, and the rest are one-line fixes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHCbkJWXHjtTUaqvnHRAqA
67 lines
2.3 KiB
Python
67 lines
2.3 KiB
Python
"""Spawning processes as the desktop user, and reaping them.
|
|
|
|
Split out of :mod:`steam_backlog_enforcer._steam_launch` to keep both under
|
|
the 250-line cap. Owns the fire-and-forget process registry so it has a single
|
|
owner rather than a global shared across responsibilities.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
import subprocess
|
|
|
|
from steam_backlog_enforcer._desktop_env import desktop_user_cmd
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
# Handles for fire-and-forget launches, kept only so they can be reaped.
|
|
_SPAWNED: list[subprocess.Popen[bytes]] = []
|
|
|
|
|
|
def spawn_detached(cmd: list[str]) -> subprocess.Popen[bytes]:
|
|
"""Start ``cmd`` and hand back the process, output discarded.
|
|
|
|
Fire-and-forget on purpose: the process must outlive the calling scope
|
|
(Steam itself, a desktop notifier), so it is polled or reaped later rather
|
|
than waited on in a ``with`` block here.
|
|
"""
|
|
return subprocess.Popen(
|
|
cmd,
|
|
stdout=subprocess.DEVNULL,
|
|
stderr=subprocess.DEVNULL,
|
|
)
|
|
|
|
|
|
def _reap_spawned() -> None:
|
|
"""Clear out previously launched processes that have since exited.
|
|
|
|
Launches here are fire-and-forget: Steam is meant to outlive the call, so
|
|
it is never waited on. That leaves any launch which dies immediately - a
|
|
missing binary, a broken wrapper - sitting as a zombie that still carries
|
|
the name ``steam``, which anything scanning /proc reads as "Steam is
|
|
running". Polling the old handles reaps them and retires the name.
|
|
"""
|
|
_SPAWNED[:] = [proc for proc in _SPAWNED if proc.poll() is None]
|
|
|
|
|
|
def _run_as_user(cmd: list[str], user: str | None) -> None:
|
|
"""Run a command, dropping to *user* if currently root.
|
|
|
|
Refuses to run at all when root and no desktop user resolves: the command
|
|
would otherwise execute *as root* on the user's session, which is how the
|
|
enforcer put a root Steam ("Cannot run as root user") on screen.
|
|
Failing closed costs one skipped pass; failing open costs a modal.
|
|
"""
|
|
_reap_spawned()
|
|
if os.geteuid() == 0 and (not user or user == "root"):
|
|
logger.error(
|
|
"Refusing to run %s as root: no desktop user resolved "
|
|
"(is STEAM_ENFORCER_DESKTOP_USER set?)",
|
|
cmd[0] if cmd else "<empty>",
|
|
)
|
|
return
|
|
full_cmd = desktop_user_cmd(cmd, user)
|
|
|
|
_SPAWNED.append(spawn_detached(full_cmd))
|