mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 15:07:58 +01:00
The enforce service runs as root (no User=) but sets DISPLAY=:0, so any GUI
it starts lands on the desktop session. Two resolvers disagreed about who to
drop privileges to:
library_hider._resolve_desktop_user() read STEAM_ENFORCER_DESKTOP_USER
game_install._get_real_user() read only SUDO_USER or USER
systemd sets neither of the latter, so _get_real_user() returned None under
the service and every `geteuid() == 0 and real_user and ...` guard fell
through to running as root. Steam answered with a zenity modal ("Cannot run
as root user", /usr/lib/steam/steam:261) on screen.
Confirmed from the live process tree: root `bash /usr/lib/steam/steam
-cef-disable-gpu ... steam://install/618510` with a root zenity child. It
never reached the journal, because that text goes to zenity and _run_as_user
sends child output to DEVNULL.
- _desktop_env: add resolve_desktop_user/desktop_uid/desktop_user_cmd. Only
the argv builder is shared, never the spawn call: tests/_no_subprocess.py
patches subprocess per module by name, so a spawn site in an unpatched
module could fire a real `sudo -u kuhy steam`.
- game_install._get_real_user: delegate to the shared resolver. This alone
also fixes the root `steam -silent` in _ensure_steam_running and the
no-op os.chown on new appmanifests.
- _trigger_steam_install / enforcer.send_notification: drop privileges.
send_notification had no DBUS_SESSION_BUS_ADDRESS, so it silently reached
nobody for all six of its callers.
- _run_as_user: fail closed. Running unchanged as root when no desktop user
resolves is what put the modal on screen; refuse and log instead.
Also stop the retry storm behind it. steamapps does not exist (Steam has
never completed sign-in), so is_game_installed() was always False and the
loop re-triggered every allowed game every pass: 1656 attempts in 30
minutes, service RSS 1.5 GB (peak 4.3 GB), a FileNotFoundError traceback
each time. Guard install_game and _reinstall_missing_allowed on
steam_library_ready() -- a missing library means no install can succeed by
any route, so this is a correctness check rather than a tuned retry limit.
The module splits here are forced by the pre-commit 250-line gate, which
blocks any commit touching an over-cap file: game_install, library_hider and
_enforce_loop were already over before this change. They are split by
responsibility (_cdp transport, _steam_launch lifecycle, _steam_process
spawning, _steam_errors, _steam_client, _game_names, game_uninstall,
_enforce_steps, _owned_apps_cache, _echo, _protected_apps). game_install and
library_hider re-export their old public names, so the 15 modules that
import from them are untouched by this commit.
Verified as real root under the unit's environment: argv is now
`sudo -u kuhy env DISPLAY=:0 ... xdg-open steam://install/...` for both the
installer and notify-send; three enforce passes spawn no process and log
once; _run_as_user refuses with no desktop user. After restart: 0 retries,
0 tracebacks, 0 root-owned files under ~/.local/share/Steam, RSS 342 MB.
1311 tests pass. _desktop_env and _steam_state at 100% branch coverage.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016A1EYiv7e7HGhET84oa9M3
249 lines
8.6 KiB
Python
249 lines
8.6 KiB
Python
"""Getting Steam running with its devtools port open.
|
|
|
|
Split out of :mod:`steam_backlog_enforcer.library_hider` to keep both files
|
|
under the 250-line cap: this module owns the Steam *lifecycle* (is it up, does
|
|
it have a CDP port, restart it as the desktop user), not what to do with it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from pathlib import Path
|
|
import shutil
|
|
import subprocess
|
|
import time
|
|
|
|
from steam_backlog_enforcer._cdp import (
|
|
_CDP_PORT,
|
|
_cdp_result_value,
|
|
_evaluate_js,
|
|
_get_shared_js_ws_url,
|
|
)
|
|
from steam_backlog_enforcer._desktop_env import (
|
|
desktop_runtime_dir,
|
|
desktop_session_ready,
|
|
desktop_uid,
|
|
)
|
|
from steam_backlog_enforcer._steam_errors import (
|
|
DesktopSessionNotReadyError,
|
|
SteamUnavailableError,
|
|
SteamUpdateInProgressError,
|
|
)
|
|
from steam_backlog_enforcer._steam_process import _run_as_user
|
|
from steam_backlog_enforcer._steam_state import steam_update_in_progress
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_CDP_TIMEOUT = 120
|
|
_STEAM_STARTUP_WAIT = 45
|
|
# Real Steam client binary, as shipped by the distro's `steam` package.
|
|
#
|
|
# Deliberately NOT probed with shutil.which("steam"): a launcher wrapper on
|
|
# $PATH (e.g. /usr/local/bin/steam adding -cef-* flags) keeps `which` truthy
|
|
# long after the package itself is gone - as happens when a total block
|
|
# uninstalls Steam. Checking the real binary is what actually answers
|
|
# "can we launch Steam at all?".
|
|
_STEAM_BINARY = "/usr/bin/steam"
|
|
|
|
|
|
def steam_is_installed() -> bool:
|
|
"""Return True if the real Steam client binary is present."""
|
|
return Path(_STEAM_BINARY).exists()
|
|
|
|
|
|
# Handles for fire-and-forget launches, kept only so they can be reaped.
|
|
_SPAWNED: list[subprocess.Popen[bytes]] = []
|
|
|
|
|
|
# ──────────────────────────────────────────────────────────────
|
|
# Ensure Steam is running with devtools port
|
|
# ──────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _is_steam_running() -> bool:
|
|
"""Check whether any Steam process is alive."""
|
|
pgrep = shutil.which("pgrep") or "/usr/bin/pgrep"
|
|
result = subprocess.run(
|
|
[pgrep, "-x", "steam"],
|
|
capture_output=True,
|
|
check=False,
|
|
)
|
|
return result.returncode == 0
|
|
|
|
|
|
def _steam_has_debug_port() -> bool:
|
|
"""Check whether steamwebhelper is listening on the CDP port."""
|
|
return _get_shared_js_ws_url() is not None
|
|
|
|
|
|
def _wait_for_cdp_ready() -> bool:
|
|
"""Wait up to *_STEAM_STARTUP_WAIT* seconds for CDP to become ready."""
|
|
for _ in range(_STEAM_STARTUP_WAIT):
|
|
if _get_shared_js_ws_url() is not None:
|
|
return True
|
|
time.sleep(1)
|
|
return False
|
|
|
|
|
|
def _wait_for_collections_ready() -> bool:
|
|
"""Wait until ``collectionStore`` is fully initialised.
|
|
|
|
Right after Steam starts, the CDP port may be open but the
|
|
internal collection data hasn't loaded yet. Poll a lightweight
|
|
JS check until ``GetCollection`` stops throwing.
|
|
"""
|
|
js = (
|
|
"(() => { try { collectionStore.GetCollection('hidden');"
|
|
" return 'ok'; } catch(e) { return 'not_ready'; } })()"
|
|
)
|
|
for _ in range(_STEAM_STARTUP_WAIT):
|
|
try:
|
|
result = _evaluate_js(js)
|
|
if _cdp_result_value(result) == "ok":
|
|
return True
|
|
except RuntimeError:
|
|
pass
|
|
time.sleep(1)
|
|
return False
|
|
|
|
|
|
def _resolve_desktop_user() -> str | None:
|
|
"""Resolve which desktop user owns the Steam/X11 session.
|
|
|
|
Prefers the explicit STEAM_ENFORCER_DESKTOP_USER (set by the systemd
|
|
unit, which has no SUDO_USER/USER of its own since it is started
|
|
directly by systemd rather than via `sudo`), then falls back to
|
|
SUDO_USER/USER for interactive `sudo` invocations.
|
|
"""
|
|
return (
|
|
os.environ.get("STEAM_ENFORCER_DESKTOP_USER")
|
|
or os.environ.get("SUDO_USER")
|
|
or os.environ.get("USER")
|
|
)
|
|
|
|
|
|
def _shutdown_steam() -> None:
|
|
"""Send ``steam -shutdown`` and wait for the process to exit."""
|
|
real_user = _resolve_desktop_user()
|
|
try:
|
|
_run_as_user(["steam", "-shutdown"], real_user)
|
|
except FileNotFoundError:
|
|
return
|
|
|
|
pgrep = shutil.which("pgrep") or "/usr/bin/pgrep"
|
|
for _ in range(30):
|
|
result = subprocess.run(
|
|
[pgrep, "-x", "steam"],
|
|
capture_output=True,
|
|
check=False,
|
|
)
|
|
if result.returncode != 0:
|
|
return
|
|
time.sleep(1)
|
|
|
|
|
|
def _launch_steam_with_debug() -> None:
|
|
"""Launch Steam with CEF debugging enabled."""
|
|
real_user = _resolve_desktop_user()
|
|
_run_as_user(
|
|
[
|
|
"steam",
|
|
"-cef-enable-debugging",
|
|
f"-devtools-port={_CDP_PORT}",
|
|
"-silent",
|
|
],
|
|
real_user,
|
|
)
|
|
|
|
|
|
def ensure_steam_debug_port() -> None:
|
|
"""Make sure Steam is running with the CDP debug port open.
|
|
|
|
If Steam is running without the port, it is restarted.
|
|
If Steam is not running, it is launched.
|
|
|
|
Raises:
|
|
SteamUnavailableError: If Steam is not installed, or is installed but
|
|
never opens its debug port.
|
|
"""
|
|
if _steam_has_debug_port():
|
|
logger.debug("Steam CDP port already available.")
|
|
return
|
|
|
|
# Bail out before the ~45s launch-and-wait: with no binary to exec there
|
|
# is nothing to wait for, and retrying every pass only burns time and
|
|
# leaves dead processes behind.
|
|
if not steam_is_installed():
|
|
msg = f"Steam is not installed ({_STEAM_BINARY} does not exist)"
|
|
raise SteamUnavailableError(msg)
|
|
|
|
# Never launch Steam into a session that does not exist yet: it would get
|
|
# a missing XDG_RUNTIME_DIR, silently fall back to winealsa, and stay
|
|
# audio-broken until the next restart. Defer instead — the loop retries.
|
|
real_user = _resolve_desktop_user()
|
|
if os.geteuid() == 0 and not desktop_session_ready(desktop_uid(real_user)):
|
|
msg = (
|
|
"Deferring Steam launch: the desktop session's runtime directory "
|
|
f"({desktop_runtime_dir(desktop_uid(real_user))}) does not exist "
|
|
"yet. Launching now would leave Steam without audio; will retry."
|
|
)
|
|
logger.info(msg)
|
|
raise DesktopSessionNotReadyError(msg)
|
|
|
|
logger.info("Steam CDP port not available — (re)starting Steam...")
|
|
if _is_steam_running():
|
|
# Never bounce a running Steam while a game update is downloading or
|
|
# committing: the shutdown suspends it and can leave a partially
|
|
# written install (the root cause of the AoE2 launch crash). Defer and
|
|
# retry on the next enforce pass.
|
|
if steam_update_in_progress():
|
|
msg = (
|
|
"Deferring Steam restart: a game update is in progress. "
|
|
"Restarting now would interrupt and can corrupt it; will "
|
|
"retry once the update settles."
|
|
)
|
|
logger.info(msg)
|
|
raise SteamUpdateInProgressError(msg)
|
|
_shutdown_steam()
|
|
|
|
_launch_steam_with_debug()
|
|
|
|
if not _wait_for_cdp_ready():
|
|
msg = "Timed out waiting for Steam CDP port to become ready"
|
|
raise SteamUnavailableError(msg)
|
|
logger.info("Steam CDP port ready.")
|
|
|
|
if not _wait_for_collections_ready():
|
|
msg = "Timed out waiting for Steam collections to initialise"
|
|
raise SteamUnavailableError(msg)
|
|
logger.info("Steam collection store ready.")
|
|
|
|
|
|
# ──────────────────────────────────────────────────────────────
|
|
# Steam restart helper
|
|
# ──────────────────────────────────────────────────────────────
|
|
|
|
|
|
def restart_steam() -> None:
|
|
"""Gracefully restart the Steam client with CEF debugging enabled.
|
|
|
|
Skips the restart if a game update is downloading or committing, so the
|
|
update is not interrupted (interrupting it can corrupt the install).
|
|
"""
|
|
if steam_update_in_progress():
|
|
logger.warning(
|
|
"Skipping Steam restart — a game update is in progress; "
|
|
"restarting now could corrupt it.",
|
|
)
|
|
return
|
|
|
|
logger.info("Restarting Steam client with debug port...")
|
|
_shutdown_steam()
|
|
_launch_steam_with_debug()
|
|
|
|
if not _wait_for_cdp_ready():
|
|
logger.warning("Steam restarted but CDP port not ready.")
|
|
else:
|
|
logger.info("Steam restarted with CDP port ready.")
|