mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-21 18:52:18 +01:00
main.py became main/ with __main__.py, so the invocation string baked into
run.sh and the systemd unit (`python -m steam_backlog_enforcer.main`) stays
byte-identical and nothing needs redeploying. Commands are grouped into
sibling modules (status, install, picks, abandon, misc), with _shared.py as
a leaf holding the lock helpers and constants both need, and _registry.py
holding the command tables. main/__init__.py keeps every public and private
name importable, so `from steam_backlog_enforcer.main import X` is unchanged.
The subtle part is patch targets. The test suite builds them as
f"{PKG}.{name}", so a grep for the literal module path found nothing -- but
once a command moves to a submodule it resolves its dependencies from that
module's globals, and patching the main package's re-export silently stops
biting. Measured which of the 36 patched symbols moved: 8 could have passed
vacuously. Rather than repair PKG per class, the five test_main*.py files
(all cap violators anyway) were regrouped to mirror the production modules,
so each file has exactly one correct PKG. Verified by mutation: breaking a
line in status/misc/picks/_shared each makes the corresponding tests fail.
test_web_server.py patched main_mod.serve, which no longer intercepts
cmd_serve; repointed at main.misc and confirmed it fails when the call is
removed. Added tests for the __main__ shim, which coverage would otherwise
report at 0% under fail_under = 100.
Shared test builders live in tests/_main_helpers.py, reachable because the
Phase 0 name-tests-test exclude allows tests/_*.py.
1290 tests pass; every main/ module reports 100% coverage; `main`, `status`,
`bogus` and `--status` produce byte-identical output and exit codes to
pre-refactor. 55 -> 49 files over the cap.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPpmMpTSkp8UziRc5u8B7P
146 lines
4.8 KiB
Python
146 lines
4.8 KiB
Python
"""``abandon-pick``: back out of a manual pick inside its grace window."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from typing import TYPE_CHECKING
|
|
|
|
from steam_backlog_enforcer._actions import (
|
|
ABANDON_COOLDOWN_DAYS as _ABANDON_COOLDOWN_DAYS,
|
|
)
|
|
from steam_backlog_enforcer._actions import (
|
|
MANUAL_GRACE_DAYS as _MANUAL_GRACE_DAYS,
|
|
)
|
|
from steam_backlog_enforcer._actions import (
|
|
abandon_manual_pick,
|
|
active_manual_picks,
|
|
can_abandon_manual_pick,
|
|
find_manual_pick,
|
|
manual_pick_grace_remaining,
|
|
)
|
|
from steam_backlog_enforcer.game_install import (
|
|
_echo,
|
|
is_game_installed,
|
|
uninstall_game,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from steam_backlog_enforcer.config import Config, State
|
|
|
|
_ABANDON_PICK_USAGE = (
|
|
"Usage: abandon-pick <app_id>\n"
|
|
" app_id : the manually-picked game you want to back out of.\n\n"
|
|
f"Only works within {_MANUAL_GRACE_DAYS} days of the pick."
|
|
)
|
|
|
|
|
|
def _abandon_pick_target(state: State, args: list[str]) -> int | None:
|
|
"""Validate the abandon-pick argument against the active manual pick.
|
|
|
|
Requiring the explicit app_id (rather than defaulting to the current pick)
|
|
makes an accidental abandon impossible to trigger by muscle memory.
|
|
|
|
Args:
|
|
state: Current enforcer state.
|
|
args: Remaining CLI args (first element should be the app_id).
|
|
|
|
Returns:
|
|
The validated app id, or ``None`` if the input was unusable (a message
|
|
has already been printed in that case).
|
|
"""
|
|
if not args:
|
|
_echo(_ABANDON_PICK_USAGE)
|
|
return None
|
|
|
|
try:
|
|
app_id = int(args[0])
|
|
except ValueError:
|
|
_echo(f"Error: app_id must be a number, got '{args[0]}'.")
|
|
return None
|
|
|
|
picks = active_manual_picks(state)
|
|
if not picks:
|
|
_echo("No manual pick is active — nothing to abandon.")
|
|
return None
|
|
|
|
if find_manual_pick(state, app_id) is None:
|
|
listed = ", ".join(f"{p['game_name']} (AppID={p['app_id']})" for p in picks)
|
|
_echo(
|
|
f"Error: AppID={app_id} is not one of your manual picks.\nActive: {listed}."
|
|
)
|
|
return None
|
|
|
|
return app_id
|
|
|
|
|
|
def cmd_abandon_pick(_config: Config, state: State, args: list[str]) -> None:
|
|
"""Back out of a manual pick while still inside the grace period.
|
|
|
|
Args:
|
|
_config: Enforcer configuration (unused, kept for dispatch symmetry).
|
|
state: Current enforcer state.
|
|
args: Remaining CLI args (first element should be the app_id).
|
|
"""
|
|
app_id = _abandon_pick_target(state, args)
|
|
if app_id is None:
|
|
sys.exit(1)
|
|
|
|
pick = find_manual_pick(state, app_id)
|
|
game_name = str(pick["game_name"]) if pick else ""
|
|
|
|
if not can_abandon_manual_pick(state, app_id):
|
|
# ``remaining`` is negative once the window has closed, so its
|
|
# magnitude is how long ago that happened.
|
|
remaining = manual_pick_grace_remaining(state, app_id)
|
|
elapsed = (
|
|
f"{abs(remaining):.1f} day(s) ago"
|
|
if remaining is not None
|
|
else "at an unknown time"
|
|
)
|
|
_echo(
|
|
f"\nGrace period EXPIRED for {game_name} (AppID={app_id}).\n"
|
|
f"The {_MANUAL_GRACE_DAYS}-day window closed {elapsed}.\n"
|
|
"Finish the game (100% achievements) or wait out the lock."
|
|
)
|
|
sys.exit(1)
|
|
|
|
others = [p for p in active_manual_picks(state) if p["app_id"] != app_id]
|
|
_echo(f"\nAbandoning manual pick: {game_name} (AppID={app_id})")
|
|
_echo(
|
|
f"\nThis will:"
|
|
f"\n - Drop this pick from your allowed games"
|
|
f"\n - Uninstall {game_name}"
|
|
f"\n - Keep it out of auto-assignment for"
|
|
f" {_ABANDON_COOLDOWN_DAYS} days"
|
|
)
|
|
if others:
|
|
kept = ", ".join(f"{p['game_name']} (AppID={p['app_id']})" for p in others)
|
|
_echo(f"\n Your other pick(s) stay locked in: {kept}")
|
|
else:
|
|
_echo("\n - Leaves you with no assigned game (run 'scan' to get one)")
|
|
_echo()
|
|
confirm = input(f"Type YES to abandon {game_name}: ").strip()
|
|
if confirm != "YES":
|
|
_echo("Aborted.")
|
|
return
|
|
|
|
if not abandon_manual_pick(state, app_id):
|
|
# Should be unreachable: the grace check above already passed.
|
|
_echo("Error: the grace period closed before the pick could be abandoned.")
|
|
sys.exit(1)
|
|
|
|
_echo(f"\nManual pick abandoned: {game_name}")
|
|
|
|
if is_game_installed(app_id):
|
|
_echo(f" Uninstalling {game_name}...")
|
|
if uninstall_game(app_id, game_name):
|
|
_echo(" Uninstalled.")
|
|
else:
|
|
_echo(" Warning: could not uninstall — remove it from Steam manually.")
|
|
|
|
if state.current_app_id is None:
|
|
_echo("\nNo game is assigned now. Run 'scan' to get a new assignment,")
|
|
_echo("or 'pick-manual <app_id>' to choose one yourself.\n")
|
|
else:
|
|
_echo(f"\nStill assigned: {state.current_game_name}\n")
|