mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 18:33:49 +01:00
Krzysztof kuhy Rudnicki
b5b4b35c07
Each of these was one file doing several jobs, so they are split along what they actually do rather than at arbitrary line offsets: - _total_block: the lock file and the status derived from it stay in _total_block; making Steam *not installed* moves to _total_block_purge, making it *unreachable* to _total_block_hosts / _total_block_iptables. The generic pacman verbs (owner, installed, remove) become _pacman, since nothing about them is total-block-specific. Domain and process name tables become data modules. - _playtime: budget state and persistence (_playtime_state), pure transitions (_playtime_budget), cmdline process detection (_playtime_procs), the warn/cutoff/kill ladder (_playtime_cutoff), desktop notifications (_playtime_notify), process-tree walking and killing (_playtime_kill), mountinfo parsing (_playtime_mountinfo) and the shared privileged-command helper (_playtime_run). - _mcp: read-only tools (_mcp_query) split from mutating ones (_mcp_actions, _mcp_gaming_time), so "what can this server change?" is answerable from one file. _mcp keeps the server object and entry point. No re-export shims: callers import from the module that defines the name. That keeps a stale patch target loud (AttributeError) instead of letting it pass while intercepting nothing. `ruff check --select F821,F401` is run after every extraction -- an earlier mechanical attempt moved functions without the module-level names they referenced, which imported fine and only failed when called (349 errors), so it was reverted and redone by hand. The autouse fixtures in conftest are now imported by name and held by __all__; ruff --unsafe-fixes had deleted them as unused, since pytest resolves fixtures by name. 1324 tests pass at 100.00% coverage in the clean venv; `main status` is byte-identical to a worktree at HEAD. 49 -> 39 files over the cap. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPpmMpTSkp8UziRc5u8B7P
86 lines
3.3 KiB
Python
86 lines
3.3 KiB
Python
"""Autouse redirection of the playtime module's on-disk state.
|
|
|
|
Split out of ``conftest.py`` to keep every file inside the 250-line cap;
|
|
``conftest`` imports the fixture by name, which is what registers it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import Iterator
|
|
from pathlib import Path
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_playtime(tmp_path: Path) -> Iterator[None]:
|
|
"""Redirect the daily-gaming-budget paths to a temporary directory.
|
|
|
|
Separate from :func:`_isolate_filesystem` only because CPython caps a
|
|
``with`` statement at 20 statically nested blocks and that fixture is
|
|
already at the limit.
|
|
|
|
The ``BLOCK_TARGETS`` patch is the load-bearing one: unpatched, that tuple
|
|
names the real ``/usr/bin/steam``, and a test reaching the mount code would
|
|
mask the user's actual Steam install behind a refusal stub.
|
|
"""
|
|
# Namespaced names: an autouse fixture that creates bare "proc"/"targets"
|
|
# inside tmp_path would claim those names for every other test in the
|
|
# suite (test_enforcer builds its own tmp_path/"proc" with mkdir()).
|
|
fake_config = tmp_path / "config"
|
|
fake_config.mkdir(exist_ok=True)
|
|
fake_proc = tmp_path / "playtime_proc"
|
|
fake_proc.mkdir(exist_ok=True)
|
|
fake_targets = tmp_path / "playtime_targets"
|
|
fake_targets.mkdir(exist_ok=True)
|
|
|
|
with (
|
|
# Computed at import time from CONFIG_DIR, so patching CONFIG_DIR
|
|
# alone does not redirect them.
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_state.PLAYTIME_STATE_FILE",
|
|
fake_config / "playtime_state.json",
|
|
),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_state.PLAYTIME_DEMO_STATE_FILE",
|
|
fake_config / "playtime_demo_state.json",
|
|
),
|
|
patch("steam_backlog_enforcer._playtime_procs._PROC", fake_proc),
|
|
patch("steam_backlog_enforcer._playtime_kill._PROC", fake_proc),
|
|
# Never let a test chattr +i a file inside tmp_path — pytest could
|
|
# then not clean the directory up.
|
|
patch("steam_backlog_enforcer._playtime_state._try_set_immutable", MagicMock()),
|
|
patch("steam_backlog_enforcer._playtime_state.unlock_for_write", MagicMock()),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_block.BLOCK_TARGETS",
|
|
(
|
|
fake_targets / "steam",
|
|
fake_targets / "bin_steam.sh",
|
|
fake_targets / "steam.sh",
|
|
fake_targets / "lutris",
|
|
),
|
|
),
|
|
patch("steam_backlog_enforcer._playtime_block._STUB_DIR", tmp_path / "run"),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_block.STUB_PATH",
|
|
tmp_path / "run" / "gaming-blocked",
|
|
),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_block.MOUNTINFO_PATH",
|
|
tmp_path / "mountinfo",
|
|
),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_block._INIT_MOUNTINFO_PATH",
|
|
tmp_path / "init_mountinfo",
|
|
),
|
|
patch(
|
|
"steam_backlog_enforcer._playtime_block.PACMAN_LOCK", tmp_path / "db.lck"
|
|
),
|
|
patch("steam_backlog_enforcer._playtime_block._PROC", fake_proc),
|
|
):
|
|
yield
|