mirror of
https://github.com/kuhyx/steam-backlog-enforcer.git
synced 2026-11-11 14:27:33 +01:00
The enforcer allowed exactly one game: `current_app_id` was the single
"allowed" id threaded through the uninstall guard, the process killer, the
library hider and the auto-installer. Picking a second game manually meant
the first was uninstalled and hidden.
Manual picks are now a set, capped by `Config.max_manual_picks` (default 2).
Every active pick stays installed, visible and un-killed; the lock releases
only when all of them are finished or past their own 14-day deadline.
- `State.manual_picks` holds `{app_id, game_name, started_at}` entries. The
legacy single-slot `manual_pick_*` fields are still read on load, migrated
into the list and cleared, so a live lock survives the upgrade.
- `_actions.allowed_app_ids` / `allowed_games` are the single source of truth
for "may exist". `uninstall_other_games`, `hide_other_games` (incl. its
injected JS), `enforce_allowed_game` and `_guard_installed_games` now take
that set instead of one app id; every call site passes it.
- `pick-manual` joins `_MANUAL_LOCK_EXEMPT_COMMANDS` so a second game can be
added while the first holds the lock — the cap is what limits it, not the
lock check. Its post-pick cascade operates on the whole allowed set, so
adding a pick never tears down an earlier one.
- `abandon-pick <app_id>` drops only that pick; a survivor inherits the
assignment and keeps the lock. Grace and deadline are per pick.
- `cmd_done` is unchanged: it finishes `current_app_id` and auto-picks a
replacement, so two games stay queued. A finished pick leaves the active
set automatically via `finished_app_ids`.
Deployment note, learned the hard way during development: the daemon holds
the allowed set in code, so it MUST be restarted after upgrading. A
pre-upgrade daemon knows only `current_app_id` and uninstalled the other pick
as "unauthorized" within seconds of the second pick being made.
Verified live: legacy KCD2 lock migrated on load; a second pick (Vampire
Survivors) was accepted while the first was locked, with both kept by the
uninstall pass; a third was refused at the cap; abandoning one pick left the
other locked and handed it the assignment; the restarted daemon reports
"KEEPING allowed game" for both. 1060 tests pass at 100% coverage.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
163 lines
5.1 KiB
Python
163 lines
5.1 KiB
Python
"""Enforce that only the assigned game may run."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from pathlib import Path
|
|
import shutil
|
|
import signal
|
|
import subprocess
|
|
|
|
from steam_backlog_enforcer.game_install import (
|
|
is_protected_app,
|
|
)
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def get_running_steam_game_pids() -> dict[int, int]:
|
|
"""Scan /proc to find running Steam game processes.
|
|
|
|
Returns: dict mapping PID -> SteamAppId.
|
|
"""
|
|
running: dict[int, int] = {}
|
|
proc = Path("/proc")
|
|
|
|
for entry in proc.iterdir():
|
|
if not entry.name.isdigit():
|
|
continue
|
|
try:
|
|
environ = (entry / "environ").read_bytes()
|
|
pairs = environ.split(b"\x00")
|
|
for pair in pairs:
|
|
if pair.startswith(b"SteamAppId="):
|
|
value = pair.split(b"=", 1)[1].decode("utf-8", errors="replace")
|
|
if value.isdigit():
|
|
running[int(entry.name)] = int(value)
|
|
break
|
|
except (PermissionError, OSError, ValueError):
|
|
continue
|
|
|
|
return running
|
|
|
|
|
|
def get_pids_by_process_names(names: frozenset[str]) -> dict[int, str]:
|
|
"""Scan /proc/*/comm for processes whose command name is in *names*.
|
|
|
|
The kernel truncates ``/proc/[pid]/comm`` to 15 characters (plus a null
|
|
terminator), so *names* longer than that (e.g. ``EpicGamesLauncher``,
|
|
``gdlauncher-carbon``) are matched against their own first 15 characters
|
|
- matching how the kernel actually stores them, not an exact string
|
|
that could never appear in ``comm``.
|
|
|
|
Returns: dict mapping PID -> matched comm string.
|
|
"""
|
|
truncated = {name[:15]: name for name in names}
|
|
running: dict[int, str] = {}
|
|
proc = Path("/proc")
|
|
|
|
for entry in proc.iterdir():
|
|
if not entry.name.isdigit():
|
|
continue
|
|
try:
|
|
comm = (entry / "comm").read_text(encoding="utf-8").strip()
|
|
except (PermissionError, OSError, ValueError):
|
|
continue
|
|
if comm in truncated:
|
|
running[int(entry.name)] = truncated[comm]
|
|
|
|
return running
|
|
|
|
|
|
def kill_processes_by_name(names: frozenset[str]) -> list[tuple[int, str]]:
|
|
"""Kill (SIGTERM) every running process whose name is in *names*.
|
|
|
|
Matching is by ``/proc/[pid]/comm`` via :func:`get_pids_by_process_names`,
|
|
not the ``SteamAppId`` environment variable (unlike
|
|
:func:`get_running_steam_game_pids`) - this is for non-Steam processes
|
|
(the Steam client itself, and third-party game launchers) that don't set
|
|
that variable.
|
|
|
|
Returns: list of (pid, matched_name) actually killed.
|
|
"""
|
|
killed: list[tuple[int, str]] = []
|
|
for pid, name in get_pids_by_process_names(names).items():
|
|
if _kill_pid_by_name(pid, name):
|
|
killed.append((pid, name))
|
|
return killed
|
|
|
|
|
|
def _kill_pid_by_name(pid: int, name: str) -> bool:
|
|
"""Send SIGTERM to *pid*. Returns True if the signal was delivered."""
|
|
try:
|
|
os.kill(pid, signal.SIGTERM)
|
|
except ProcessLookupError:
|
|
return False
|
|
except PermissionError:
|
|
logger.exception("No permission to kill PID %d (%s).", pid, name)
|
|
return False
|
|
else:
|
|
return True
|
|
|
|
|
|
def enforce_allowed_game(
|
|
allowed_app_ids: set[int],
|
|
*,
|
|
kill_unauthorized: bool = True,
|
|
) -> list[tuple[int, int]]:
|
|
"""Check running games; optionally kill unauthorized ones.
|
|
|
|
Args:
|
|
allowed_app_ids: Every app id the user may play right now — the
|
|
assignment plus any concurrent manual picks. Empty disables the
|
|
check entirely (nothing is assigned, so nothing is unauthorized).
|
|
kill_unauthorized: Whether to kill violating processes.
|
|
|
|
Returns list of (pid, app_id) that were killed or detected.
|
|
"""
|
|
if not allowed_app_ids:
|
|
return []
|
|
running = get_running_steam_game_pids()
|
|
violations: list[tuple[int, int]] = []
|
|
|
|
for pid, app_id in running.items():
|
|
if app_id in allowed_app_ids:
|
|
continue
|
|
# Skip Steam client itself (app_id 0 or very low IDs).
|
|
if app_id == 0:
|
|
continue
|
|
if is_protected_app(app_id):
|
|
continue
|
|
|
|
violations.append((pid, app_id))
|
|
if kill_unauthorized:
|
|
kill_process(pid, app_id)
|
|
|
|
return violations
|
|
|
|
|
|
def kill_process(pid: int, app_id: int) -> None:
|
|
"""Kill a process by PID."""
|
|
try:
|
|
logger.warning("Killing unauthorized game (AppID=%d, PID=%d)", app_id, pid)
|
|
os.kill(pid, signal.SIGTERM)
|
|
except ProcessLookupError:
|
|
logger.debug("Process %d already gone.", pid)
|
|
except PermissionError:
|
|
logger.exception("No permission to kill PID %d.", pid)
|
|
|
|
|
|
def send_notification(title: str, body: str) -> None:
|
|
"""Send a desktop notification."""
|
|
_notify_send = shutil.which("notify-send") or "/usr/bin/notify-send"
|
|
try:
|
|
subprocess.run(
|
|
[_notify_send, title, body, "--icon=dialog-warning"],
|
|
capture_output=True,
|
|
timeout=5,
|
|
check=False,
|
|
)
|
|
except (FileNotFoundError, OSError):
|
|
logger.debug("notify-send not available.")
|