steam-backlog-enforcer/steam_backlog_enforcer/tests
Krzysztof kuhy Rudnicki bfdd69453e
Some checks failed
pre-commit / pre-commit (push) Has been cancelled
Tests / test (3.10) (push) Has been cancelled
Tests / test (3.11) (push) Has been cancelled
Tests / test (3.12) (push) Has been cancelled
Pass XDG_RUNTIME_DIR when launching Steam as the desktop user
The enforcer runs as root under systemd and launches Steam via
`sudo -u <user> env DISPLAY=... XAUTHORITY=... DBUS_SESSION_BUS_ADDRESS=...`.
sudo uses env_reset, so that list is the child's entire environment - an
allowlist where every omission fails silently.

XDG_RUNTIME_DIR was missing. Without it Wine cannot reach
$XDG_RUNTIME_DIR/pulse/native, falls back from winepulse.drv to
winealsa.drv, and hands FMOD raw ALSA devices instead of the session sink.
Kingdom Come: Deliverance II died in its Bink startup video as a result.
Across 18 sessions the split was total: 9/9 runs logging "PulseAudio
Output" exited cleanly, 9/9 logging "HDA NVidia" crashed on the same line.

It presented as a corrupt install - the apparent cure was a 92GB reinstall -
but verify-integrity always passed. What actually fixed it was the Steam
restart the reinstall incidentally performed.

Extract the duplicated env construction into _desktop_env.desktop_env_args
and derive XDG_RUNTIME_DIR from the target uid, never from the ambient
environment: root's own value would point the child at /run/user/0.

PULSE_SERVER is deliberately not exported. pressure-vessel reads
XDG_RUNTIME_DIR to bind-mount the pulse socket into the Steam Linux Runtime
container, whereas a hardcoded unix:/run/user/<uid>/pulse/native names a
host path that need not resolve inside it.

Also gate the launch on the session existing. The enforcer is ordered only
After=network-online, while /run/user/<uid> is created by
user-runtime-dir@<uid>.service; on a measured boot the enforcer started 54ms
before that unit and won only by doing other work first. Launching in that
window would name a runtime dir that is not there and reintroduce the same
silent winealsa fallback for the whole session, so defer instead - the
enforce loop already retries every 3s, and DesktopSessionNotReadyError
subclasses SteamUnavailableError so existing callers degrade as before.
An ordering dependency would not be reliable here, since logind may start
user-runtime-dir outside the boot transaction.

Verified on the failing path rather than a dev shell: after restarting the
enforcer, the Steam it launched carried XDG_RUNTIME_DIR=/run/user/1000 and
KCD2 ran 15 minutes on "PulseAudio Output" with no crash artifacts.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-26 14:39:38 +02:00
..
__init__.py test: achieve 100% branch coverage across all python_pkg packages 2026-03-21 17:51:36 +01:00
conftest.py fix(enforcer): defer Steam restart while a game update is in progress 2026-07-18 15:59:47 +02:00
test_actions.py fix(game_install): refuse to delete folders matching an allowed game's name 2026-07-25 15:50:29 +02:00
test_cmd_done_part2.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_config.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_desktop_env.py Pass XDG_RUNTIME_DIR when launching Steam as the desktop user 2026-07-26 14:39:38 +02:00
test_enforce_loop_part2.py fix(enforcer): idle when Steam is absent instead of crash-looping 2026-07-17 13:53:24 +02:00
test_enforce_loop_part3.py feat: add block-gaming command (Stage 4) + guard-lib migration cleanup 2026-07-04 11:45:54 +02:00
test_enforce_loop.py feat(enforcer): allow two concurrent manual picks 2026-07-19 17:28:23 +02:00
test_enforcer_part2.py feat: add block-gaming command (Stage 4) + guard-lib migration cleanup 2026-07-04 11:45:54 +02:00
test_enforcer.py feat(enforcer): allow two concurrent manual picks 2026-07-19 17:28:23 +02:00
test_game_install_part2.py fix(game_install): refuse to delete folders matching an allowed game's name 2026-07-25 15:50:29 +02:00
test_game_install_part3.py fix: add websockets dependency and apply ruff formatting to tests 2026-05-28 21:00:49 +02:00
test_game_install.py Pass XDG_RUNTIME_DIR when launching Steam as the desktop user 2026-07-26 14:39:38 +02:00
test_hltb_detail.py fix: sort requirements.txt and add tests for uncovered branches 2026-05-28 21:11:53 +02:00
test_hltb_part2.py feat: add pick-manual command with 2-week enforcement lock 2026-05-30 17:15:37 +02:00
test_hltb_part3.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_hltb_search_part2.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_hltb_search.py fix: HLTB count_comp=0 bug, false matches, and ProtonDB log noise 2026-05-28 20:40:51 +02:00
test_hltb.py fix: sort requirements.txt and add tests for uncovered branches 2026-05-28 21:11:53 +02:00
test_library_hider_part2.py feat(enforcer): allow two concurrent manual picks 2026-07-19 17:28:23 +02:00
test_library_hider.py fix(enforcer): idle when Steam is absent instead of crash-looping 2026-07-17 13:53:24 +02:00
test_main_part2.py feat(enforcer): add 4-day grace period to undo a manual pick 2026-07-19 17:04:08 +02:00
test_main_part3.py fix(enforcer): accept flag-style subcommands, explain unknown ones 2026-07-19 18:21:30 +02:00
test_main_part4.py feat(enforcer): allow two concurrent manual picks 2026-07-19 17:28:23 +02:00
test_main_part5.py feat: add block-gaming command (Stage 4) + guard-lib migration cleanup 2026-07-04 11:45:54 +02:00
test_main.py feat(enforcer): add 4-day grace period to undo a manual pick 2026-07-19 17:04:08 +02:00
test_mcp.py feat(enforcer): allow two concurrent manual picks 2026-07-19 17:28:23 +02:00
test_polls_tracking_part2.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_polls_tracking.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_protondb.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_scanning_part2.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_scanning_part3.py fix: add websockets dependency and apply ruff formatting to tests 2026-05-28 21:00:49 +02:00
test_scanning_part4.py fix: add websockets dependency and apply ruff formatting to tests 2026-05-28 21:00:49 +02:00
test_scanning.py fix: add websockets dependency and apply ruff formatting to tests 2026-05-28 21:00:49 +02:00
test_stats.py Deterministically cover the SteamAPIError branch in stats refresh 2026-07-10 23:10:44 +02:00
test_steam_api.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_store_blocker_part2.py feat: add block-gaming command (Stage 4) + guard-lib migration cleanup 2026-07-04 11:45:54 +02:00
test_store_blocker.py chore: set up as standalone repo 2026-05-28 07:21:29 +02:00
test_total_block.py feat: block-gaming purges Steam/Proton filesystem remnants + helper packages 2026-07-04 17:25:08 +02:00
test_update_restart_guard.py fix(enforcer): defer Steam restart while a game update is in progress 2026-07-18 15:59:47 +02:00
test_web_dataset.py feat: add pick-manual command with 2-week enforcement lock 2026-05-30 17:15:37 +02:00
test_web_server.py feat: add interactive web UI for backlog completion planning 2026-05-29 18:35:45 +02:00
test_whitelist.py perf(whitelist): only shell out to chattr when the immutable flag differs 2026-07-25 20:15:12 +02:00