Krzysztof kuhy Rudnicki a4b879b19d bucket_catch: 45 eslint errors -> 5, no suppressions ... These were unmasked, not caused, last session: `lint` is `tsc --noEmit && eslint src`, and a broken tsc had been short-circuiting the && so eslint had never run on this package. The binding constraint is the 100% coverage gate, not the linter. Most idiomatic fixes for no-non-null-assertion add a branch that no test can reach, which trades a lint error for a coverage failure - and the no-suppressions rule forbids escaping either way. So every fix here is one that adds no branch: - no-non-null-assertion 18 -> 2: a waitFor already proves result.current is non-null, so capture it into a local instead of asserting on each read. App.tsx's files[0]! was pure noise (the same position also reported no-unnecessary-type-assertion). usePuzzleGameLoop's shift()! became index-then-shift, since the while condition already indexes [0] unasserted. - non-nullable-type-assertion-style 9 -> 0: the rule-swap trap - eslint asks for `!`, which the other rule forbids. Narrowed with instanceof. - unbound-method 10 -> 1: keep the MockInstance vi.spyOn already returns rather than detaching the method. This surfaced a latent bug: one test calls restoreAllMocks() mid-test, so the beforeEach handle was stale. - no-unnecessary-type-assertion 5 -> 1, require-await 1 -> 0. Coverage held at 100%: 584/217/98/535 -> 585/217/98/536. The +1 statement and +1 line are the index-then-shift split; branches unchanged at 217 is the number that proves no fix added an untested path. 145 tests, tsc 0. The 5 remaining are reported, not silenced. App.tsx's fileResult! needs the phase state to carry the result ({ kind: "done"; result }) - three smaller structures all failed the same way. The rest are documented in the evidence file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY		2026-08-17 11:48:45 +02:00
bucket_catch	bucket_catch: 45 eslint errors -> 5, no suppressions	2026-08-17 11:48:45 +02:00