shell-tests: drop the last stale suite name
Some checks are pending
Pre-commit checks / pre-commit (push) Waiting to run
Python tests / test (push) Waiting to run
Shell tests / shell-tests (push) Waiting to run
Shell tests / arch-tests (push) Waiting to run

test_usage_monitoring_installer_efficiency.sh left with
system-maintenance, but shell-tests.yml keeps TWO hand-maintained lists
and I had only cleaned the Arch-specific one. The side-effect-free list
still named it, so ci-mirror rejected every push since that extraction.

Cross-checked the whole workflow this time: every test_*.sh it names now
exists on disk.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PJrqKERAo5QUeEHWS5Asgp
This commit is contained in:
Krzysztof Rudnicki 2026-08-23 18:11:36 +02:00
parent 60a7fb38f4
commit cbdf3a3d85
2 changed files with 28 additions and 1 deletions

View File

@ -29,7 +29,6 @@ jobs:
test_i3blocks_persist_common.sh
test_music_parallelism.sh
test_setup_dns_blocker.sh
test_usage_monitoring_installer_efficiency.sh
)
failed=0
for t in "${tests[@]}"; do

View File

@ -0,0 +1,28 @@
{
"intent": "Remove the last stale test name from shell-tests.yml's explicit lists, which was turning the pre-push gate red after the system-maintenance extraction.",
"scope": [
".github/workflows/shell-tests.yml - one entry removed from the side-effect-free list",
"Non-goal: the glob-discovered lib/tests suites, which need no maintenance"
],
"changes": [
"Dropped test_usage_monitoring_installer_efficiency.sh from the side-effect-free list. It moved to the system-maintenance repo, and I had already cleaned three names from the Arch-specific list but missed this second list in the same file."
],
"verification": [
{
"command": "bash meta/scripts/ci_mirror.sh",
"result": "fail then pass",
"evidence": "Before: 'ci-mirror: FAILED - shell test failed: test_usage_monitoring_installer_efficiency.sh', which is what had been rejecting the push. Re-run after the fix to confirm green."
},
{
"command": "cross-check every test named in the workflow against the filesystem",
"result": "pass",
"evidence": "Extracted every test_*.sh mention and confirmed each file exists under linux_configuration/tests/; no misses remain."
}
],
"risks": [
"shell-tests.yml keeps two hand-maintained lists plus a glob. A future extraction has to check all three; the cross-check loop used here is the cheap way to catch it."
],
"rollback": [
"git revert; CI would go red again on the missing file, which is how the problem surfaced in the first place."
]
}