diff --git a/docs/superpowers/contracts/logo-review-icon-2026-11-20.json b/docs/superpowers/contracts/logo-review-icon-2026-11-20.json new file mode 100644 index 00000000..e7641c6a --- /dev/null +++ b/docs/superpowers/contracts/logo-review-icon-2026-11-20.json @@ -0,0 +1,11 @@ +{ + "title": "Family icon for the logo-review app", + "objective": "Register a square-tick glyph and the logo_review app so the generator can write its launcher icon; done when the registry tests pass and icon_qa passes all six checks on the app.", + "acceptance_criteria": [ + "apps.get_app('logo_review') uses glyph square-tick and label LogoJudge", + "The label passes labels.label_problems", + "The standard asset set renders at 1024 px" + ], + "out_of_scope": ["style.py", "other apps' glyphs", "Linux desktop icons"], + "verifier": "python -m pytest python_pkg/app_icons; ~/.claude/skills/app-icon/scripts/icon_qa.py" +} diff --git a/docs/superpowers/evidence/logo-review-icon-2026-11-20.json b/docs/superpowers/evidence/logo-review-icon-2026-11-20.json new file mode 100644 index 00000000..195f2b67 --- /dev/null +++ b/docs/superpowers/evidence/logo-review-icon-2026-11-20.json @@ -0,0 +1,31 @@ +{ + "intent": "The logo-review phone app (LogoJudge) gets a family launcher icon: a tick in a rounded square.", + "scope": [ + "python_pkg/app_icons: one new glyph (square-tick), one registry entry (logo_review), one label (LogoJudge)", + "No change to style.py or to any other app's icon" + ], + "changes": [ + "Added _SQUARE_TICK to _glyph_art_code.py and registered it in glyphs.py", + "Registered logo_review in _apps_more.py and its launcher name in labels.py", + "Extended tests/test_registry_code_apps.py with the new entry" + ], + "verification": [ + { + "command": "python -m pytest python_pkg/app_icons -q", + "result": "pass", + "evidence": "149 passed" + }, + { + "command": "~/.claude/skills/app-icon/scripts/icon_qa.py /app", + "result": "pass", + "evidence": "bw, px48, px16, bg, accent, svg: all PASS" + } + ], + "risks": [ + "The tick could merge with the frame at small sizes; px48 and px16 checks pass" + ], + "rollback": [ + "git revert this commit", + "python -m pytest python_pkg/app_icons" + ] +} diff --git a/docs/superpowers/evidence/track-local-bin-scripts-2026-10-11.json b/docs/superpowers/evidence/track-local-bin-scripts-2026-10-11.json deleted file mode 100644 index ce75dcf4..00000000 --- a/docs/superpowers/evidence/track-local-bin-scripts-2026-10-11.json +++ /dev/null @@ -1,37 +0,0 @@ -{ - "intent": "Hand-placed ~/.local/bin scripts are version-controlled in linux_configuration/scripts/ while every existing ~/.local/bin path keeps working through a symlink.", - "scope": [ - "linux_configuration/scripts/{fix-execstack-launch.sh,nvidia-pmon-logger.sh,usage-report-catchup.sh,krita-scaled.sh,blender-mcp-host,blender-mcp-serve,unreal-mcp-server}, linux_configuration/features/lib/unreal_mcp_repo.sh, linux_configuration/features/install_unreal_mcp.sh", - "Non-goal: no behaviour change to the moved scripts; callers are not edited" - ], - "changes": [ - "Six scripts copied byte-for-byte (cmp-verified, mode preserved); ~/.local/bin/krita is now named krita-scaled.sh in the repo", - "unreal-mcp-server is tracked; it reads UNREAL_MCP_PYTHON_DIR (default ~/.local/share/unreal-mcp/unreal-mcp/Python) because a static file cannot bake in --install-dir", - "install_launcher replaces the heredoc with ln -sfn to the tracked wrapper, chown -h under sudo, and logs a warning to export UNREAL_MCP_PYTHON_DIR when --install-dir is non-default" - ], - "verification": [ - { - "command": "for n in ...; do readlink -f ~/.local/bin/$n; bash -n ~/.local/bin/$n; done", - "result": "pass", - "evidence": "all seven names resolve into linux_configuration/scripts and parse" - }, - { - "command": "source lib/unreal_mcp_repo.sh with USER_HOME=; install_launcher twice over a stale regular file", - "result": "pass", - "evidence": "regular file replaced by symlink to scripts/unreal-mcp-server; second run idempotent; non-default install dir warning logged" - }, - { - "command": "pre-commit run --files ", - "result": "pass", - "evidence": "all passed" - } - ], - "risks": [ - "A non-default --install-dir now needs UNREAL_MCP_PYTHON_DIR exported where the MCP client launches the server", - "Moving or renaming the repo checkout breaks the ~/.local/bin symlinks" - ], - "rollback": [ - "git revert the commit, then cp the scripts from the previous ~/.local/bin state (git show :linux_configuration/scripts/) over the symlinks", - "Check systemctl --user status nvidia-pmon.service usage-report-catchup.timer afterwards" - ] -} diff --git a/python_pkg/app_icons/_apps_more.py b/python_pkg/app_icons/_apps_more.py index 77944fcd..d861fcef 100644 --- a/python_pkg/app_icons/_apps_more.py +++ b/python_pkg/app_icons/_apps_more.py @@ -82,4 +82,13 @@ MORE_APPS: Final[tuple[AppIcon, ...]] = ( # board is the separate web/ TypeScript app, not this Flutter build. linux=False, ), + AppIcon( + key="logo_review", + repo=_HOME / "src/logo-review/app", + accent="#B8862E", + glyph="square-tick", + icon_name="logo-review", + # Android only: the desktop half is the server's own web page. + linux=False, + ), ) diff --git a/python_pkg/app_icons/_glyph_art_code.py b/python_pkg/app_icons/_glyph_art_code.py index 07f90334..1f822503 100644 --- a/python_pkg/app_icons/_glyph_art_code.py +++ b/python_pkg/app_icons/_glyph_art_code.py @@ -47,3 +47,16 @@ A 72 72 0 0 1 744 752 L 280 752 A 72 72 0 0 1 208 680 L 208 344 \ A 72 72 0 0 1 280 272 Z"/> """ + +# A tick in a rounded square -- logo-review, where each logo candidate gets +# judged: the approving check mark (kuhy's pick, 2026-11-20). +# +# Geometry: rounded square x=232..792, y=232..792, corner r=96; tick +# (368,520)->(468,620)->(656,412). Tick ends sit 136px (centrelines) from the +# walls: 64px of ink gap, ~55px after the fit shrinks the glyph (~0.87), clear +# of MIN_NEGATIVE_SPACE=36. +_SQUARE_TICK = """\ + + """ diff --git a/python_pkg/app_icons/glyphs.py b/python_pkg/app_icons/glyphs.py index aa76551f..4125434c 100644 --- a/python_pkg/app_icons/glyphs.py +++ b/python_pkg/app_icons/glyphs.py @@ -33,6 +33,7 @@ from python_pkg.app_icons._glyph_art_code import ( _CODE_BRACKETS, _DOCUMENT_SPLIT, _SCREEN_TICK_PLAY, + _SQUARE_TICK, ) from python_pkg.app_icons._glyph_art_extra import ( _CAMERA, @@ -128,6 +129,7 @@ GLYPHS: Final[dict[str, Glyph]] = { "Rounded screen holding a tick and a filled play triangle", _SCREEN_TICK_PLAY, ), + Glyph("square-tick", "Rounded square holding a tick", _SQUARE_TICK), ) } diff --git a/python_pkg/app_icons/labels.py b/python_pkg/app_icons/labels.py index 1f8b9101..1f31955b 100644 --- a/python_pkg/app_icons/labels.py +++ b/python_pkg/app_icons/labels.py @@ -52,6 +52,7 @@ LABELS: Final[dict[str, str]] = { "kartka": "Kartka", "leetcode": "LeetGuard", "todoimpl": "TodoImpl", + "logo_review": "LogoJudge", } diff --git a/python_pkg/app_icons/tests/test_registry_code_apps.py b/python_pkg/app_icons/tests/test_registry_code_apps.py index e9532dc8..1216e143 100644 --- a/python_pkg/app_icons/tests/test_registry_code_apps.py +++ b/python_pkg/app_icons/tests/test_registry_code_apps.py @@ -24,6 +24,7 @@ _EXPECTED: dict[str, tuple[str, str, bool, str]] = { "kartka": ("document-split", "kartka", True, "src/kartka"), "leetcode": ("code-brackets", "leetcode-guard-app", True, "src/leetcode-guard/app"), "todoimpl": ("screen-tick-play", "todoimpl", False, "src/todoImplementer/app"), + "logo_review": ("square-tick", "logo-review", False, "src/logo-review/app"), }