Commit Graph

8 Commits

Author SHA1 Message Date
87cbcd5ff6 fix(lint): remove style preference rules from global ignores
Fixed violations:
- PERF401: Use list comprehension (downloadCats, split)
- SIM102: Combine nested if statements (keyboardCoop)
- SIM113: Use enumerate (lichess_bot/tests)
- B904: Add 'from None/e' to raises (engine, stockfish_analysis, generate_blunder_tests)
- TRY300: Move return to else block (screen_locker)

Per-file ignores added for TRY301:
- lichess_bot/main.py: Null checks on subprocess streams
- randomize_numbers/random_digits.py: Input validation

Removed from global ignore (no violations):
- RUF005, SIM103, SIM105, SIM108

Global ignore now only contains unavoidable conflicts:
- D203/D213: Docstring style conflicts
- COM812/ISC001: Formatter conflicts (per ruff docs)
2025-11-30 20:47:38 +01:00
1f9061e1c9 Enable S113: add timeout to requests calls 2025-11-30 15:17:52 +01:00
6a519db40f Enable TRY401: remove redundant exception object from logging.exception 2025-11-30 15:03:50 +01:00
3f793d2d17 Enable PLR2004: replace magic values with named constants
- Added constants for HTTP status codes (using http.HTTPStatus)
- Added validation limit constants in screen_locker
- Added centipawn loss threshold constants in chess analysis
- Added various other domain-specific constants across 9 files
2025-11-30 15:01:14 +01:00
a5406b71b0 Enable INP001: add __init__.py to 11 packages
- poker-modifier-app excluded via per-file-ignore (has hyphens)
- Disable pylint invalid-name for existing camelCase folder names
2025-11-30 14:55:20 +01:00
3ac56e541e Enable D100-D107 docstring rules: add docstrings to all modules, classes, methods, and functions
- Added module docstrings to 19 Python files
- Added class docstrings to 5 classes (ScreenLocker, PokerModifierApp, etc.)
- Added method docstrings to 22 methods
- Added function docstrings to 25 functions
- Added __init__ docstrings to 5 classes
- Removed D100-D107 from ruff ignore list (docstrings now enforced)
- Removed deprecated ANN101, ANN102, UP038 rules from ignore list
- Fixed UP038: use union types in isinstance() calls
- All ruff checks now pass with full docstring enforcement
2025-11-30 14:45:55 +01:00
1bc09449b5 refactor: replace print() with logging (T201)
- Converted 67 print statements to logging across 11 files
- Added logging.basicConfig(level=logging.INFO) to each file
- Used appropriate log levels: info, warning, error, exception
- Removed T201 from ruff ignore list to enforce logging usage
2025-11-30 14:36:13 +01:00
e3f9e6dc0b fix: correct shebang and executable permissions
- Add +x to Python scripts with shebangs (3 files)
- Remove -x from non-script files like .cpp, .txt, makefile (23 files)
- Move shebang to first line in C/imageViewer/lint.sh
2025-11-30 13:42:16 +01:00