testsAndMisc/linux_configuration/fixes/diagnose_arch_performance.sh
Krzysztof kuhy Rudnicki 4f2b0ccdf7 Dissolve linux_configuration/scripts/ and single_use/
Two levels of pure taxonomy carrying no information, and a 2-directory
cap leaves no room for them. Categories now sit directly under
linux_configuration/: features, fixes, utils, misc, fresh-install,
installers, diagnostics, gaming, boot_recovery, periodic_background, lib,
meta, tests. A script's own lib/ and tests/ are exempt from the cap, so
those stay put.

Depth violations 248 -> 139; roughly 40 of the remainder are inside
digital_wellbeing and hosts, deferred until the guard-lib repoint.

The moves are the easy half. What breaks is every path that counted
levels, and three classes of it had to be found by resolving paths rather
than reading diffs:

  - 52 relative `source` lines for lib/common.sh and lib/android.sh. The
    correct prefix differs per file: 40 were ../../ and 12 were ../../../,
    so a blanket replace would have fixed one set and broken the other.
  - REPO_ROOT in 7 fixes/lib/tests harnesses and setup_syncyomi_guard.sh,
    each walking up four levels from a directory now two levels shallower.
    This caused a real regression -- the fixes suite went red with
    "log_warn: command not found" -- caught by running it and comparing
    against the pre-move baseline worktree.
  - conftest.py's sys.path entries, which took the pytest gate down with
    14 collection errors, and the `# shellcheck source=` directives, which
    took shellcheck down with SC1091.

16 symlinks in $HOME broke, including the entire i3blocks bar. All
repointed, and cpu_monitor/memory/disk/time/volume were run to confirm
they emit real output rather than merely resolving.

Verified: 1798 tests pass at 100% coverage, 8 of 9 lib/tests suites pass
(the ninth needs the coverage jail, identically at baseline), pre-commit
is clean, and the two untracked secret configs are still ignored after
their gitignore paths changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PJrqKERAo5QUeEHWS5Asgp
2026-08-23 18:53:30 +02:00

126 lines
2.5 KiB
Bash
Executable File

#!/usr/bin/env bash
set -euo pipefail
SCRIPT_DIR="$(dirname "$(readlink -f "$0")")"
# shellcheck source=../lib/common.sh
source "$SCRIPT_DIR/../lib/common.sh"
REPORT_DIR="${HOME}/.local/state/system-diagnostics"
REPORT_FILE="$REPORT_DIR/arch-performance-$(date +%Y%m%d_%H%M%S).log"
APPLY_SAFE_FIXES=false
INSTALL_TOOLS=false
declare -a FINDINGS=()
declare -a ACTIONS=()
usage() {
cat <<'EOF'
diagnose_arch_performance.sh - Diagnose common causes of Arch Linux slowness/instability
Usage:
diagnose_arch_performance.sh [OPTIONS]
Options:
--apply-safe-fixes Apply conservative fixes (requires sudo)
--install-tools Install optional diagnostics packages (requires sudo)
-h, --help Show help
Safe fixes applied when --apply-safe-fixes is used:
- Enable/start fstrim.timer if missing
- Resolve TLP vs power-profiles-daemon conflict (keeps power-profiles-daemon)
- Vacuum journal logs if they exceed 1GiB
Notes:
- Script does not reboot automatically.
- Some checks are informational and provide next-step commands.
EOF
}
parse_args() {
while [[ $# -gt 0 ]]; do
case "$1" in
--apply-safe-fixes)
APPLY_SAFE_FIXES=true
shift
;;
--install-tools)
INSTALL_TOOLS=true
shift
;;
-h | --help)
usage
exit 0
;;
*)
log_error "Unknown option: $1"
usage
exit 2
;;
esac
done
}
add_finding() {
FINDINGS+=("$1")
log_warn "$1"
}
add_action() {
ACTIONS+=("$1")
log_info "$1"
}
run_and_log() {
local header="$1"
shift
{
echo
echo "=== $header ==="
"$@" 2>&1 || true
} >>"$REPORT_FILE"
}
check_root_if_needed() {
if [[ $APPLY_SAFE_FIXES == "true" || $INSTALL_TOOLS == "true" ]]; then
require_root "$@"
fi
}
install_optional_tools() {
if [[ $INSTALL_TOOLS != "true" ]]; then
return
fi
local packages=(lm_sensors smartmontools nvtop iotop powertop)
log_info "Installing optional diagnostic packages: ${packages[*]}"
pacman -S --needed --noconfirm "${packages[@]}"
}
# shellcheck source=lib/arch_perf_probes.sh
source "$SCRIPT_DIR/lib/arch_perf_probes.sh"
# shellcheck source=lib/arch_perf_report.sh
source "$SCRIPT_DIR/lib/arch_perf_report.sh"
main() {
parse_args "$@"
check_root_if_needed "$@"
mkdir -p "$REPORT_DIR"
log_info "Writing diagnostic report to: $REPORT_FILE"
collect_basics
install_optional_tools
check_cpu_governor
check_thermal_state
check_power_services
check_storage_health
check_memory_pressure
check_gpu_state
check_journal_size
apply_safe_fixes
print_summary
}
main "$@"