mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-10 22:07:03 +01:00
Krzysztof kuhy Rudnicki
46c8f065e8
check_shell_coverage.sh has existed for a while and was never in .pre-commit-config.yaml, so nothing ran it: a new shell library with no suite beside it could land freely. Wiring it was unaffordable while the gate measured a jail-run 100% bar (--all took over 600s). After578c4a6cdropped that, --all is 0.31s and the per-file mode this hook uses is milliseconds, so it goes in. Also fixes a bug578c4a6cintroduced: the failure path still interpolated ${COVERAGE_BAR}, which that commit deleted, so every rejection printed "COVERAGE_BAR: unbound variable" and advised a 100% line-coverage bar that no longer exists. The message now describes what is enforced. Three libs blocked the wiring -- meta/scripts/lib/shell_coverage_{bar, case_runner,jail_setup}.sh, the code that BUILDS the jail, and so the one corner of the repo the jail cannot measure itself. They are pure file-writers, so they get a suite that calls them against a temp $JAIL and asserts on what was written: 48 assertions, nothing mounted, no unshare, no kcov. Several assertions check that an emitted file contains an UNEXPANDED ${BASH_SOURCE} or $1 -- the whole point of the quoted heredocs the jail relies on. Written as single-quoted literals that is SC2016 on every line, so the needles compose the dollar from an exported constant instead. No suppressions were added. check_shell_coverage.sh --all: 3 BLOCK -> 0 BLOCK hook, repo-wide: 0.16s new suite: 48 assertions, green Proved the ratchet still bites: an untested lib dropped into mtk_root/lib is refused with "needs: .../tests/run_all.sh". Probe removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJrqKERAo5QUeEHWS5Asgp
56 lines
2.5 KiB
Bash
Executable File
56 lines
2.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# write_case_runner: the script that executes cases INSIDE the jail.
|
|
set -uo pipefail
|
|
HERE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
# shellcheck source=./coverage_tool_harness.sh
|
|
. "$HERE/coverage_tool_harness.sh"
|
|
# shellcheck source=../shell_coverage_case_runner.sh
|
|
. "$HERE/../shell_coverage_case_runner.sh"
|
|
|
|
_t_new_jail
|
|
write_case_runner
|
|
runner="$JAIL/run_cases.sh"
|
|
|
|
_t_eq "yes" "$([[ -x "$runner" ]] && echo yes)" "the runner is written executable"
|
|
body="$(cat "$runner")"
|
|
|
|
# It runs in the child namespace, so it must be syntactically valid on its own.
|
|
bash -n "$runner" 2>/dev/null
|
|
_t_eq "0" "$?" "the emitted runner parses as bash"
|
|
|
|
# Both passes must be present, and they cannot be merged: kcov's ptrace and
|
|
# xtrace destroy each other's numbers.
|
|
_t_has "$body" "kcov --include-pattern" "the kcov pass invokes kcov with an include pattern"
|
|
_t_has "$body" "BASH_ENV=" "the trace pass delivers tracing via BASH_ENV"
|
|
_t_lacks "$body" "SHELLOPTS=xtrace" "tracing is NOT delivered via SHELLOPTS (readonly, and dropped when privileged)"
|
|
|
|
# fd 199, deliberately high: a subject doing `exec 9>...` would clobber a low fd
|
|
# and silently truncate the trace.
|
|
_t_has "$body" "BASH_XTRACEFD=199" "the trace uses the high fd 199"
|
|
_t_has "$body" '199>>' "and the runner opens 199 itself so the subject cannot swallow it"
|
|
|
|
# Every case is bounded and has stdin closed: a subject that reads stdin
|
|
# otherwise blocks on the caller's terminal for the whole timeout.
|
|
_t_has "$body" "timeout --kill-after=10s" "each case runs under a bounded timeout"
|
|
_t_has "$body" "</dev/null" "each case has stdin closed"
|
|
|
|
# A timed-out or failing case must be RECORDED, not swallowed: swallowing it is
|
|
# what let a deliberately-broken assertion exit 0 through the push gate.
|
|
_t_has "$body" "case timed out" "a timeout is reported"
|
|
_t_has "$body" "case exited" "a non-zero case is reported"
|
|
_t_has "$body" "case_failures" "and both are recorded to a case_failures file"
|
|
_t_has "$body" "124" "SIGTERM-timeout (124) is treated as a timeout"
|
|
_t_has "$body" "137" "SIGKILL-timeout (137) is treated as a timeout too"
|
|
|
|
# PATH is pinned to the jail's shim dir FIRST, so a shimmed tool wins over the
|
|
# host's real one.
|
|
_t_has "$body" "PATH=\"${DOLLAR}jail/bin:" "the jail's bin/ is first on PATH"
|
|
|
|
# The heredoc is quoted, so the runner's own variables survive to the child
|
|
# shell rather than being expanded when the file is written.
|
|
_t_has "$body" "${DOLLAR}1" "the runner reads its arguments at run time"
|
|
_t_lacks "$body" "$JAIL" "the writing shell's JAIL path is not baked in"
|
|
|
|
_t_drop_jail
|
|
_t_summary
|