testsAndMisc/meta/scripts/verify_shell_split.sh
Krzysztof kuhy Rudnicki 23baf9d63f shell splits: add a verbatim-move harness and triage all 29 targets
The five Python splits this session were made safe by a throwaway ast
identity check. There is no ast for bash, so meta/scripts/verify_shell_split.sh
does the same job with shfmt -mn (minify: strips comments and indentation,
keeps logic), hashing each top-level function and naming the one that differs.
shfmt is already a REQUIRED_TOOLS binary, so this adds no dependency.

Validated in all three directions before trusting it: an unchanged copy is
IDENTICAL, a copy with blank lines inserted is IDENTICAL, and a one-character
logic change ($1 -> $2) is caught and named. The first mutation attempt used
sed 's/exit 1/exit 2/' on a file with no 'exit 1' and reported IDENTICAL - the
harness was fine, the test was vacuous. That trap is now documented, because a
normalizer that silently passes everything is worse than none.

Also triaged all 29 over-cap shell scripts for deployed copies, which the
trace harness cannot see. The finding that changes the plan: deploy.sh copies
a hardcoded per-file list into /data/local/tmp/focus_mode and never deploys
lib/, so an entry+lib seam would break focus mode on the phone at its first
source - for 8 of the 29, not the 2 the brief named. Those scripts source only
config.sh, which is on the copy list, so a sibling-file seam works provided
deploy.sh's list grows in the same commit.

16 scripts have no deployed copy and are safe to split conventionally.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
2026-08-17 14:07:20 +02:00

67 lines
2.2 KiB
Bash
Executable File

#!/bin/bash
# Prove a shell split moved every function verbatim.
#
# Extracts each top-level `name() {` block from the pre-split file at a git rev
# and from the post-split files, normalises both through `shfmt -mn`
# (minify: strips comments and indentation, keeps logic), and asserts the set
# of function bodies is identical. Formatting-blind, logic-sensitive.
#
# Usage: verify_shell_split.sh <rev> <old-path> <new-path>...
set -euo pipefail
readonly REV="$1"
readonly OLD_PATH="$2"
shift 2
TMP_DIR="$(mktemp -d)"
trap 'rm -rf "$TMP_DIR"' EXIT
# Write "<name>\t<shfmt-minified body hash>" for every top-level function.
extract_functions() {
local src="$1" out="$2"
awk '
/^[a-zA-Z_][a-zA-Z0-9_]*\(\)[[:space:]]*\{/ {
name = $0; sub(/\(\).*/, "", name); gsub(/[[:space:]]/, "", name)
depth = 0; body = ""
inside = 1
}
inside {
body = body $0 "\n"
depth += gsub(/\{/, "{")
depth -= gsub(/\}/, "}")
if (depth <= 0) {
printf "%s\x01%s\x02", name, body
inside = 0
}
}
' "$src" > "$TMP_DIR/raw"
: > "$out"
while IFS= read -r -d $'\x02' record; do
[[ -z "$record" ]] && continue
local fname="${record%%$'\x01'*}"
local fbody="${record#*$'\x01'}"
local norm
norm="$(printf '%s' "$fbody" | shfmt -mn 2>/dev/null | sha256sum | cut -d' ' -f1)"
printf '%s\t%s\n' "$fname" "$norm" >> "$out"
done < "$TMP_DIR/raw"
sort -o "$out" "$out"
}
git show "$REV:$OLD_PATH" > "$TMP_DIR/before.sh"
extract_functions "$TMP_DIR/before.sh" "$TMP_DIR/before.txt"
: > "$TMP_DIR/after_all.sh"
for f in "$@"; do cat "$f" >> "$TMP_DIR/after_all.sh"; printf '\n' >> "$TMP_DIR/after_all.sh"; done
extract_functions "$TMP_DIR/after_all.sh" "$TMP_DIR/after.txt"
before_count="$(wc -l < "$TMP_DIR/before.txt")"
if diff -u "$TMP_DIR/before.txt" "$TMP_DIR/after.txt" > "$TMP_DIR/diff.txt"; then
echo "IDENTICAL: all ${before_count} top-level functions moved verbatim"
exit 0
fi
echo "DIFFERENCE FOUND (- before / + after):"
grep -E '^[+-][a-zA-Z_]' "$TMP_DIR/diff.txt" || cat "$TMP_DIR/diff.txt"
exit 1