mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-20 22:12:18 +01:00
flutter analyze --fatal-infos exited 1 at6713ef3with four unnecessary_unawaited issues in lib/ui/home_screen.dart: Flutter now annotates Navigator.push with @awaitNotRequired, which makes the unawaited() wrappers redundant. Removed all four wrappers and the dart:async import they were the only user of. dart format --set-exit-if-changed was separately red on three test files left unformatted bya68313f. One trailing blank line each. Both are steps in .github/workflows/billsplit-ci.yml, so billsplit CI was failing on main for reasons unrelated to any current work. Fixing them first means the platform-directory deletion that follows can be verified green-to-green. flutter test: 60 passing before and after - the unchanged count is what proves the unawaited() removals did not shift navigation timing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
18 lines
1.7 KiB
JSON
18 lines
1.7 KiB
JSON
{
|
|
"title": "Make the billsplit CI gates green before touching billsplit",
|
|
"objective": "billsplit CI was already failing on main at 6713ef3: flutter analyze --fatal-infos exited 1 with four unnecessary_unawaited issues, and dart format --set-exit-if-changed exited 1 on three test files left unformatted by an earlier split commit. Both are steps in .github/workflows/billsplit-ci.yml. This change fixes exactly those two gates and nothing else, so that the platform-directory deletion that follows can be verified as green-to-green rather than red-to-red.",
|
|
"acceptance_criteria": [
|
|
"flutter analyze --fatal-infos exits 0 in billsplit/ (was exit 1, 4 issues)",
|
|
"dart format --set-exit-if-changed . exits 0 in billsplit/ (was exit 1, 3 changed files)",
|
|
"flutter test still reports exactly 60 passing tests, the same count as at HEAD - proving the unawaited() removals did not alter navigation behaviour in the widget tests",
|
|
"No lint suppression, no analysis_options exclusion, and no lowered threshold is used to reach any of the above"
|
|
],
|
|
"out_of_scope": [
|
|
"Deleting billsplit/windows, macos, ios or linux - that is the next commit, with its own contract",
|
|
"Any change to billsplit behaviour, UI, or test assertions",
|
|
"Reformatting Dart files outside billsplit/",
|
|
"The 45 bucket_catch eslint errors and the usage_report split work, both tracked separately in this session"
|
|
],
|
|
"verifier": "cd billsplit && flutter analyze --fatal-infos && dart format --set-exit-if-changed . && flutter test - the first three steps of .github/workflows/billsplit-ci.yml. Each was run before and after the change and the exit codes are recorded in docs/superpowers/evidence/billsplit-ci-green-2026-08-17.json."
|
|
}
|