testsAndMisc/docs/superpowers/evidence/billsplit-drop-unused-platforms-2026-08-17.json
Krzysztof kuhy Rudnicki fc185b835f
Some checks failed
Pre-commit checks / pre-commit (push) Waiting to run
Shell tests / shell-tests (push) Waiting to run
Shell tests / arch-tests (push) Waiting to run
billsplit CI / quality (push) Has been cancelled
billsplit: drop the four unused platform runner directories
windows/ (18 files), macos/ (28), ios/ (40) and linux/ (10) were flutter
create scaffolding that nothing in this repo builds: billsplit-ci.yml runs
pub get, dart format, analyze, test and the Python coverage gate, with no
flutter build step for any platform, and no script or doc invokes one
either. 96 tracked files, 4188 lines.

This also removes win32_window.cpp (288 lines), the last over-cap C++
file. It could not be split honestly - flutter regenerates it - so
deleting the target it belongs to is the honest way off the list.
Over-cap: 41 -> 40, and the cpp category is now empty.

Unpicked all three references: the .binary-allowlist icon entries and the
.gitignore un-ignore rules that existed only to let those icons past the
binary block, plus the README claim that the repo ships without platform
runner folders (false while 96 were tracked, true again now).

The four dirs are now gitignored so `flutter create` regenerates them
locally without re-tracking them. Verified by actually running
`flutter create . --platforms=linux,windows,macos,ios`: git add -An then
refuses all four as ignored. analyze/test/format stay green, 60 tests.

analysis_options.yaml is deliberately untouched - flutter analyze rewrites
the platform excludes back on every run, so removing them is not durable.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
2026-08-17 11:14:32 +02:00

52 lines
5.2 KiB
JSON

{
"intent": "Remove the four unused Flutter platform runner directories from billsplit so the repo tracks only the android target it actually ships, and so the last over-cap C++ file disappears without hand-editing generated scaffolding.",
"scope": [
"Deleted billsplit/windows/ (18 files), billsplit/macos/ (28), billsplit/ios/ (40), billsplit/linux/ (10) - 96 tracked files, 4188 lines",
"Unpicked the three places that referenced them: .gitignore un-ignore rules, .binary-allowlist icon entries, billsplit/README.md",
"Non-goal: billsplit/android/ stays tracked; no lib/ or test/ change; no CI workflow change"
],
"changes": [
"git rm -r on the four platform dirs. Nothing built them: .github/workflows/billsplit-ci.yml runs pub get, dart format, flutter analyze, flutter test and the Python coverage gate, with no flutter build step for any platform. A repo-wide grep found no script or doc invoking a build for them either.",
"Removed the four .binary-allowlist entries (ios/macos AppIcon+LaunchImage PNGs, windows app_icon.ico) and the four .gitignore un-ignore rules that existed solely to let those icons past the repo's binary block.",
"Added billsplit/ios/, billsplit/macos/, billsplit/windows/, billsplit/linux/ as .gitignore entries so a stray `flutter create` regenerates them locally without them becoming tracked files again.",
"Rewrote the billsplit/README.md Running section: it claimed the repo ships without platform runner folders, which was false while 96 of them were tracked and is now true again except for android. Documents that the regenerated dirs are gitignored and that CI never builds them.",
"Left billsplit/analysis_options.yaml alone. An edit removing the now-dead ios/macos/windows/linux/web excludes was attempted and `flutter analyze` immediately rewrote the file back (it prints 'Upgrading analysis_options.yaml to exclude build and platform directories'). The excludes are regenerated by Flutter tooling, so removing them is not durable and fighting it would produce a permanently dirty file."
],
"verification": [
{
"command": "bash ~/utils/scripts/check_file_length.sh --all | grep -c 'over by'",
"result": "pass",
"evidence": "41 over-cap files before, 40 after. grep -c win32_window on the same output returns 0, so billsplit/windows/runner/win32_window.cpp (288 lines, over by 38) is gone from the list. The C++ category is now empty; the remaining 40 are 29 shell, 7 python, 2 kotlin, 1 dart, 1 markdown."
},
{
"command": "cd billsplit && flutter analyze --fatal-infos",
"result": "pass",
"evidence": "exit 0, 'No issues found!' - unchanged from the green baseline established in the preceding commit. Deleting the dirs introduced no analyzer regression."
},
{
"command": "cd billsplit && flutter test",
"result": "pass",
"evidence": "60 tests passed, the same count as before the deletion. An unchanged count is the discriminating check that no test file lived under the removed directories."
},
{
"command": "cd billsplit && dart format --set-exit-if-changed .",
"result": "pass",
"evidence": "exit 0, 'Formatted 29 files (0 changed)'."
},
{
"command": "cd billsplit && flutter create . --platforms=linux,windows,macos,ios ; git add -An billsplit/{windows,macos,ios,linux}",
"result": "pass",
"evidence": "This is the check that the resurrection guard actually works, and it is the only one git can perform. After really regenerating all four directories on disk, `git add -An` refuses every one: 'The following paths are ignored by one of your .gitignore files: billsplit/ios, billsplit/linux, billsplit/macos, billsplit/windows'. git status --untracked-files=all over those paths shows nothing beyond the staged deletions. git check-ignore -v names the new rules at .gitignore:406-409. The regenerated dirs were then deleted again, and the .metadata and pubspec.lock files that flutter create had modified as a side effect were reverted with git checkout."
}
],
"risks": [
"Anyone wanting to run billsplit on linux/macos/windows/iOS must now run `flutter create . --platforms=...` first. The README documents this. The regenerated scaffolding is Flutter-standard, so nothing hand-written is lost - that is precisely why these files were safe to delete rather than split.",
"billsplit/linux/ was deleted on the evidence that nothing references it, not on positive proof it is unused. If the Linux desktop build turns out to be wanted, `flutter create . --platforms=linux` restores it in seconds and it will simply stay untracked.",
"The macos and ios AppIcon assets are gone from the repo. They are regenerable from billsplit/assets/icon/ via the shared generator in python_pkg/app_icons/, which is still tracked and still covers billsplit."
],
"rollback": [
"git revert the commit. All 96 files return, along with the .gitignore un-ignore rules, the .binary-allowlist entries and the old README text.",
"After rollback, confirm check_file_length.sh --all reports 41 over-cap files with win32_window.cpp among them, and that flutter analyze and flutter test are still clean - the revert should not disturb either, since no code under lib/ or test/ is involved."
]
}