testsAndMisc/linux_configuration/scripts/periodic_background/lib/tests/services_path.sh
Krzysztof kuhy Rudnicki 0a69d18390 check_and_enable_services: 100% coverage via a redirectable path prefix
Follow-up to 9085a4e5, which recorded services_units.sh at 84.51% because
its remaining branches sit behind [[ -f /etc/systemd/system/*.service ]] --
absolute root-owned paths that exist on this machine, so the else-branch
never runs and no PATH shim can redirect it.

All 87 such paths across the seven check libs now go through $SYSROOT, read
from SERVICES_ROOT. The prefix is deliberately NOT defaulted. Three commands
in hosts_fix_resolved run outside `run` and so are not stopped by --dry-run
(chattr -i on resolved.conf.d, find -delete over its *.conf, and an append to
resolved.conf); with an empty default, a test that forgot to set SERVICES_ROOT
would really delete this machine's resolved.conf drop-ins. Unset is therefore
a hard error and only an explicitly empty value means the real filesystem.

The harness now owns PATH outright: $FAKE_BIN for shims and staged fake apps,
$REAL_BIN for a curated set of symlinks to genuine coreutils. The machine's
/usr/bin is deliberately absent -- a really-installed discord and chromium
otherwise make the "no target apps present" branches untestable, which is
exactly what happened until these tests caught it.

Coverage, measured against run_all.sh because two test files jointly cover
services_common.sh after the 250-cap split: common 55/55, report 27/27,
units 72/72 (was 84.51%), wrappers 100/100, apps 66/66, browser 79/79 --
seven libs at 100%. services_hosts.sh reads 86.05% and services_hosts_fix.sh
97.30%, and those 14 lines are a kcov attribution artifact rather than a gap.
Falsified rather than assumed: the suite prints "51 passed, 0 failed" when run
under kcov, so no group is skipped, and every supposedly-uncovered line is an
issues+=("...") whose string can only reach stdout through the print loop
below it -- with a passing assertion matching that exact string.

Two falsification checks, both re-run after the rewrite: `--status --dry-run`
as root stays byte-identical to rev 6691cb26 modulo the Date: line, and the
sha256sums of /etc/hosts, /etc/nsswitch.conf and /etc/systemd/resolved.conf
plus the contents of resolved.conf.d are unchanged across a full suite run.
The second one is what makes a missed prefix site detectable instead of a
matter of inspection: the repair paths really do write.

220 assertions across 8 test files. Also fixes a bug in the harness's own
lsattr shim, where printf with a leading-dash format string parsed the dashes
as options and silently produced nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F3PzGc75gBcdxP3PkHXGcV
2026-08-21 14:08:11 +02:00

34 lines
1.6 KiB
Bash
Executable File

#!/usr/bin/env bash
# lib/tests/services_path.sh — build the PATH the tests run under.
#
# Sourced by services_harness.sh once $FAKE_BIN and $TEST_TMPDIR exist. Split
# out of the harness to keep both under the repo-wide 250-line cap.
# `command -v <app>` decides whether the app/browser/VBox checks apply, and it
# is a bash builtin that cannot be shimmed. The tests control it by owning PATH:
# $FAKE_BIN holds the shims and the staged fake apps, and $REAL_BIN is a
# curated directory of symlinks to the genuine coreutils the shims and the
# checks themselves need (grep, sed, tail, ...).
#
# Crucially the machine's own /usr/bin is NOT on PATH, so a really-installed
# discord or chromium cannot make "no target apps present" untestable -- which
# it did, until these tests caught it. Every symlink is created from an
# explicit list and the loop fails loudly on a tool it cannot find, because a
# silently-missing tool shows up much later as a `set -e` abort mid-suite with
# no message, which cost a debugging round the first time.
readonly REAL_BIN="${TEST_TMPDIR}/real_bin"
mkdir -p "${REAL_BIN}"
for real in bash sh env grep egrep awk sed find wc cut tr basename dirname \
seq sha256sum cat ls mkdir rmdir rm chmod chown ln readlink realpath \
stat sort head tail uniq id getent date mktemp touch cp mv diff xargs \
tee expr; do
real_path="$(PATH="/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" \
command -v "$real" 2>/dev/null)" || {
printf 'harness: required tool not found on the system: %s\n' "$real" >&2
exit 1
}
ln -sf "$real_path" "${REAL_BIN}/${real}"
done
unset real real_path