mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-12 17:30:57 +01:00
Krzysztof kuhy Rudnicki
0c92a00f0f
Eighth of the 16 untested fixes/lib libs. 22 assertions; 43/46 = 93.48%. The lib STAYS on the allowlist -- see the artifact below. Third instance of the same dead branch. Line 16 matched on `([0-9]+\.?[0-9]*)\ G`, a required space before the unit, while journalctl prints "4.2G" with no separator, so the vacuum could never run. Fixed to an optional space, as in arch_perf_report.sh. This one differs from that earlier fix and the difference was confirmed with the user before landing: arch_perf_report.sh's vacuum sits behind --apply-safe-fixes, but THIS one runs whenever fix_arch_performance.sh runs. So the fix makes an unflagged destructive action live -- the script will now really vacuum the journal to 300M once it passes a gigabyte. That is the function's evident intent, since its next act is to write a permanent 300M cap, and the user approved it explicitly. Three absolute paths moved behind overrides defaulting to the real ones: JOURNALD_CONF_DIR, SYSTEMD_UNIT_DIR (fix_media_organizer writes /etc/systemd/system/media-organizer.service) and ORGANIZE_SCRIPT_CANDIDATES. Verified afterwards that the real unit file still carries its 2026-07-25 mtime and the journald drop-in its 2026-03-02 one, i.e. a bare un-jailed run_all.sh touched neither. The three uncovered lines (68-70) are the element lines of a multi-line array literal. `PS4` + `set -x` on a minimal case shows bash reporting the whole assignment at its OPENING line and never emitting the elements or the closing paren, so they are data, not statements -- a fourth flavour of defect (a), after multi-line quotes, `} |` and the backslash-continued assignment. The array is provably used: the loop on the next line iterates it and the media-organizer assertions pass. Worth fixing, unlike the bt_adapter one-liner: the form appears in three of the remaining untested libs (thorium_repairs.sh has four) and in nine allowlisted libs repo-wide. That lands as its own commit next. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| features | ||
| feedback-appimage | ||
| fixes | ||
| fresh-install | ||
| lib | ||
| misc/testsAndMisc-bash | ||
| utils | ||
| install_code_insiders.sh | ||
| install_feedback.sh | ||
| install_joplin.sh | ||
| install_ungoogled_chromium_ubuntu.sh | ||
| test_bad.sh | ||
| test_removal.sh | ||