testsAndMisc/linux_configuration/scripts/single_use/features
Krzysztof kuhy Rudnicki 0e843c2a5f Cover rpi_nc_install.sh and fix two latent bugs in the nc_php suite
rpi_nc_install.sh is one 200-line function that apt-installs 24
packages, seeds MariaDB, rm -rf's /var/www/nextcloud, rewrites Apache
and PHP config and installs a www-data crontab. 29 assertions, run for
real inside the jail. The destructive step is the point: a bug in
`rm -rf /var/www/nextcloud` is invisible to any check that does not
actually run it.

Two latent bugs in the ALREADY-COMMITTED nc_php suite, both found by
finally reading its assertion results instead of only its coverage
percentage. It was failing 2 of 29 in isolation:

- the cron entry arrives on crontab's STDIN, not in argv, so asserting
  on the call log could never have passed for the right reason. The
  stub now records stdin.
- configure_mariadb's stdout is eaten by `db_password=$(...)`, so the
  phase-order marker now goes to stderr and the capture reads both.

Suites now: 28 + 30 + 29 = 87 assertions, 0 failures.

KNOWN AND UNEXPLAINED: kcov mis-measures rpi_nc_install.sh at 10/88 =
11.36%, recording lines 13-54 and nothing after -- yet the code past
line 54 provably runs, since /root/.nextcloud_db_password and
/etc/apache2/sites-available/nextcloud.conf both exist afterwards. The
three obvious culprits were each tested against a minimal reproduction
and DISPROVEN: kcov traces fine past a heredoc, into a $( ) command
substitution, and past a heredoc-fed stub reading stdin via $(cat).
The file stays on the allowlist and the suite is kept for its
assertions, not its percentage. Do not 'fix' the number by weakening a
test.

dot_resolver_install.sh 39/39 = 100.00%; nc_php.sh 84/85 = 98.82%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbD4nco3EgL1UFoZKmKsLE
2026-08-22 11:49:47 +02:00
..
lib Cover rpi_nc_install.sh and fix two latent bugs in the nc_php suite 2026-08-22 11:49:47 +02:00
systemd Extract dufs cloud (web + app + scripts) to github.com/kuhyx/dufs-cloud 2026-07-12 18:38:37 +02:00
control_from_mobile.sh Split two more linux_configuration scripts; revert a third 2026-08-16 18:44:18 +02:00
install_unreal_mcp_kvick.sh refactor(linux_configuration/scripts): split all scripts into single_use/ and periodic_background/ 2026-05-15 00:32:35 +02:00
install_unreal_mcp.sh Split five more linux_configuration single_use scripts 2026-08-16 18:51:28 +02:00
keepass_consolidate.sh linux_configuration: unified multi-device KeePass sync over dufs 2026-07-12 05:00:27 +02:00
keepass_sync.sh Fix the 11 shellcheck findings that kept CI red since b83ce5d 2026-08-04 20:55:02 +02:00
keepass-open.sh linux_configuration: unified multi-device KeePass sync over dufs 2026-07-12 05:00:27 +02:00
migrate_github_to_gitea.sh Add self-hosted Gitea deployment, mirroring all GitHub repos publicly 2026-07-04 07:45:00 +02:00
raspberry_pi_flash_sd.sh Split the Pi flasher and the boot-repair test harness 2026-08-16 20:21:44 +02:00
raspberry_pi_nextcloud.sh Split three more linux_configuration giants 2026-08-16 19:43:55 +02:00
setup_activitywatch.sh Split three more scripts; make the verifier catch heredoc cuts 2026-08-16 20:16:08 +02:00
setup_dns_blocker.sh Split setup_dns_blocker.sh, a live systemd unit target 2026-08-16 21:31:03 +02:00
setup_dot_resolver.sh Split seven more linux_configuration scripts 2026-08-16 18:56:05 +02:00
setup_dwm.sh Split five more linux_configuration single_use scripts 2026-08-16 18:51:28 +02:00
setup_gitea.sh Split three near-miss linux_configuration scripts 2026-08-16 18:38:43 +02:00
setup_kcd2_dice_solver.sh Split three large linux_configuration scripts, defer a fourth 2026-08-16 19:06:16 +02:00
setup_keepass_sync.sh linux_configuration: unified multi-device KeePass sync over dufs 2026-07-12 05:00:27 +02:00
setup_local_llm.sh Split five more linux_configuration single_use scripts 2026-08-16 18:51:28 +02:00
setup_nextcloud_raspberry.sh Split setup_nextcloud_raspberry.sh 1383 -> 231 2026-08-16 19:37:07 +02:00
setup_personal_website.sh Split three more linux_configuration feature and fix scripts 2026-08-16 18:48:01 +02:00
setup_phone_wireguard.sh Park phone DNS filtering: Private DNS fails closed, so the PC cannot host it 2026-08-05 10:05:16 +02:00
setup_searxng.sh Split setup_searxng.sh 912 -> 184 2026-08-16 19:11:40 +02:00
setup_syncyomi_guard.sh syncyomi_guard: refuse a collapsed payload as the new good copy 2026-08-10 15:33:18 +02:00
setup_syncyomi.sh Split three more linux_configuration feature and fix scripts 2026-08-16 18:48:01 +02:00
setup_wireguard_ssh.sh Split three more scripts; make the verifier catch heredoc cuts 2026-08-16 20:16:08 +02:00