testsAndMisc/python_pkg/endurain_import/tests/conftest.py
Krzysztof kuhy Rudnicki 325d5a8baa
Some checks are pending
Pre-commit checks / pre-commit (push) Waiting to run
Python tests / test (push) Waiting to run
Shell tests / shell-tests (push) Waiting to run
Shell tests / arch-tests (push) Waiting to run
Stop the endurain importer duplicating RunnerUp's own uploads
RunnerUp can now upload to Endurain directly as well as through the WebDAV
inbox, and the two paths cannot see each other: the same run landed twice
(activities 14 and 15, identical start time, distances differing only by
tcx/gpx rounding). The ledger only knows what this importer handled, so it
could not catch it.

Add a third dedupe check that asks Endurain what it already holds, queried
once per run. Endurain exposes no query-by-start-time endpoint, so a page of
recent activities is fetched and compared client-side, with a +/-120s
tolerance: the file for activity 15 embeds 21:51:04Z while the server stored
21:51:05Z, so exact equality misses the very duplicate that motivated this.
A failed or unauthorised query returns None, never an empty list, so it can
never be read as "nothing matches" and upload on the strength of it.

Export filenames are parsed as LOCAL wall-clock time. RunnerUp_2026-08-14-
00-58-45_Running is 2026-08-13 22:58:45 UTC; reading it as UTC would move a
late-evening run onto the wrong day and defeat the comparison.

Also fix the adb fallback, which broke the moment a second device attached:
phone_attached() returned true if ANY device was in the 'device' state, then
every bare adb call failed with "more than one device/emulator" as a warning
on a path nobody watches. The serial is now resolved once and threaded into
every call as -s. Ambiguity is settled by configuration, never by guessing --
several devices and no ENDURAIN_ADB_SERIAL means the fallback is skipped.

The remote check stays inert until the API key is granted activities:read;
until then it falls back to the ledger, which is the previous behaviour.

85 tests, 100% branch coverage on all four modules, no suppressions. The
oversized test modules are split by concern to stay under the 250-line cap.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GbYEnfGnf1988cdFdGebot
2026-08-23 14:36:03 +02:00

72 lines
1.9 KiB
Python

"""Shared fixtures for the endurain_import orchestration tests."""
from __future__ import annotations
from datetime import datetime
from pathlib import Path
from typing import TYPE_CHECKING
import pytest
if TYPE_CHECKING:
from python_pkg.endurain_import.upload import Result
@pytest.fixture
def inbox(tmp_path: Path) -> Path:
path = tmp_path / "inbox"
path.mkdir()
return path
def _file(inbox: Path, name: str = "RunnerUp_ts_Running.tcx") -> Path:
path = inbox / name
path.write_text("<xml/>")
return path
class _StubMainClient:
"""Stands in for EndurainClient across a whole main() run."""
def __init__(
self,
result: Result,
*,
reachable: bool = True,
remote: list[datetime] | None = None,
) -> None:
self._result = result
self._reachable = reachable
self._remote = remote
self.uploads = 0
def about(self) -> dict[str, object]:
if not self._reachable:
message = "connection refused"
raise OSError(message)
return {"version": "test"}
def recent_start_times(self, _user_id: int) -> list[datetime] | None:
return self._remote
def upload(self, _path: Path) -> Result:
self.uploads += 1
return self._result
def _env(
monkeypatch: pytest.MonkeyPatch, tmp_path: Path, inbox: Path, **extra: str
) -> None:
monkeypatch.setenv("ENDURAIN_API_KEY", "k")
monkeypatch.setenv("ENDURAIN_INBOX", str(inbox))
monkeypatch.setenv("ENDURAIN_STATE", str(tmp_path / "state"))
monkeypatch.setenv("ENDURAIN_NO_ADB", "1")
for key, value in extra.items():
monkeypatch.setenv(key, value)
def _patch_client(monkeypatch: pytest.MonkeyPatch, client: _StubMainClient) -> None:
import python_pkg.endurain_import.__main__ as mod
monkeypatch.setattr(mod, "EndurainClient", lambda *_a, **_k: client)