testsAndMisc/python_pkg/endurain_import/tests/test_upload.py
Krzysztof kuhy Rudnicki 558883f281 feat(endurain): self-hosted run viewer fed by RunnerUp WebDAV exports
Stands up Endurain behind the existing Caddy edge and imports RunnerUp
activities into it. Endurain is a VIEWER: screen-locker's workout gate still
reads the phone over adb and is untouched here, because a WebDAV drop folder is
spoofable by anything that can write to ~/cloud and must not become a
screen-unlock authority.

Primary path is phone -> WebDAV (existing dufs) -> ~/cloud/RunnerUp/ ->
importer -> Endurain, with an adb pull as fallback when a run has not been
uploaded yet. A systemd user timer runs the importer every 15 min.

Findings that shaped the implementation, each verified against the running
system rather than assumed:

- Endurain moved to Codeberg; the GitHub repo is a read-only mirror stale at
  v0.17.7 against v0.19.0. The image is pulled from Codeberg.
- postgres:18 moved PGDATA to /var/lib/postgresql/18/docker. Upstream's compose
  example still mounts the pre-18 path, which fails as an unexplained
  "container is unhealthy"; the real cause is only visible in docker logs.
- Endurain seeds a hardcoded admin/admin via an Alembic migration with no env
  override, and endurain.kuhy.duckdns.org already resolved publicly. Publishing
  is therefore a separate script that refuses to install the Caddy site while
  those credentials still work.
- Endurain performs NO duplicate detection, so the importer owns dedupe on two
  axes: a content hash, and an activity key that collapses the .gpx/.tcx pair
  RunnerUp writes for a single run (different bytes, same run).
- Ambiguous uploads (5xx/timeout) are never re-queued, since the activity may
  already have been committed; only definite 4xx rejections are staged for
  retry. The importer exits non-zero so the timer surfaces the problem.
- RunnerUp has no background sync at all, so every upload is a manual tap.
- Its WebDAV synchronizer needs HTTPS with a real cert (Android blocks
  cleartext at targetSdk 36; self-signed is broken upstream) and a URL with no
  trailing slash, and cannot MKCOL against dufs - so the inbox must pre-exist.

The phone gets a dufs credential scoped to /RunnerUp, verified unable to read
Keepass or gdrive_backups.

Verified: 52 tests at 100% branch coverage; the timer imports 4 real runs and
re-runs create zero duplicates; https://endurain.kuhy.duckdns.org serves 200
with a valid cert and the other edge sites are unaffected; screen-locker's
suite still passes 1090 tests at 100% coverage.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GbYEnfGnf1988cdFdGebot
2026-08-23 13:09:18 +02:00

138 lines
4.1 KiB
Python

"""Upload outcome classification.
The distinction that matters: a definite rejection may be retried/staged, an
ambiguous one may NOT, because Endurain does not deduplicate and the activity
may already have been committed.
"""
from __future__ import annotations
from pathlib import Path
import pytest
import requests
from python_pkg.endurain_import.upload import EndurainClient, Outcome
class _FakeResponse:
def __init__(self, status: int, body: object = None) -> None:
self.status_code = status
self._body = body
self.text = str(body)
def json(self) -> object:
if self._body is None:
message = "no json"
raise ValueError(message)
return self._body
def _client_with(monkeypatch: pytest.MonkeyPatch, outcome: object) -> EndurainClient:
client = EndurainClient("http://x", "k")
def _post(*_args: object, **_kwargs: object) -> object:
if isinstance(outcome, Exception):
raise outcome
return outcome
monkeypatch.setattr(client._session, "post", _post)
return client
@pytest.fixture
def sample(tmp_path: Path) -> Path:
path = tmp_path / "RunnerUp_ts_Running.tcx"
path.write_text("<xml/>")
return path
def test_success_extracts_activity_id(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(201, {"id": 42}))
result = client.upload(sample)
assert result.outcome is Outcome.OK
assert result.activity_id == 42
def test_success_without_parsable_body(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(200))
result = client.upload(sample)
assert result.outcome is Outcome.OK
assert result.activity_id is None
def test_bare_integer_body_is_an_id(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(200, 9))
assert client.upload(sample).activity_id == 9
def test_client_error_is_rejected(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(400, {"detail": "bad"}))
assert client.upload(sample).outcome is Outcome.REJECTED
def test_server_error_is_ambiguous(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
"""5xx may mean the activity WAS created; retrying could duplicate it."""
client = _client_with(monkeypatch, _FakeResponse(503, {}))
assert client.upload(sample).outcome is Outcome.AMBIGUOUS
def test_transport_failure_is_ambiguous(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, requests.Timeout("timed out"))
assert client.upload(sample).outcome is Outcome.AMBIGUOUS
def test_api_key_header_is_set() -> None:
"""Endurain's OpenAPI schema mislabels this; X-API-Key is correct."""
client = EndurainClient("http://x/", "secret")
assert client._session.headers["X-API-Key"] == "secret"
def test_about_returns_parsed_body(monkeypatch: pytest.MonkeyPatch) -> None:
client = EndurainClient("http://x", "k")
class _Resp:
status_code = 200
def raise_for_status(self) -> None:
return None
def json(self) -> dict[str, str]:
return {"version": "0.19.0"}
monkeypatch.setattr(client._session, "get", lambda *_a, **_k: _Resp())
assert client.about() == {"version": "0.19.0"}
def test_activity_id_ignores_non_integer_fields(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(200, {"id": "not-an-int"}))
assert client.upload(sample).activity_id is None
def test_activity_id_from_alternate_key(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(200, {"activity_id": 12}))
assert client.upload(sample).activity_id == 12
def test_activity_id_none_for_list_body(
monkeypatch: pytest.MonkeyPatch, sample: Path
) -> None:
client = _client_with(monkeypatch, _FakeResponse(200, ["a"]))
assert client.upload(sample).activity_id is None