mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-11 18:14:03 +01:00
Krzysztof kuhy Rudnicki
9e62430b8d
control_from_mobile.sh 415 -> 180 and setup_periodic_system.sh 408 -> 228. setup_periodic_system.sh has no main(): it defines functions then runs a block of top-level calls, and the splitter moved that block into the lib, changing when it ran. Redone by hand moving only definitions. It also asks for sudo at source time, so the stubbed run is off-limits - verified instead that the source line precedes the first call and all eleven invoked functions are defined exactly once across the two files. clean_audio.sh is reverted and stays over the cap. Two probe-result globals are read from what would be two different libs, and renaming them to satisfy SC2154 only moved the warning along. That is a refactor, not a line-count split, and forcing it would have cost a suppression. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
19 lines
1.6 KiB
JSON
19 lines
1.6 KiB
JSON
{
|
|
"title": "Split two more linux_configuration scripts, reverting a third",
|
|
"objective": "Bring control_from_mobile.sh (415) and setup_periodic_system.sh (408) under the 250-line cap, and establish when a seam should be abandoned rather than forced.",
|
|
"acceptance_criteria": [
|
|
"Both entry scripts and both new libs are at most 250 lines.",
|
|
"bash -n and shellcheck pass on every touched file, with no new suppression and no shellcheck disable directive.",
|
|
"setup_periodic_system.sh keeps its top-level invocation block in the entry script: it has no main(), so moving that block into a lib would change when it runs. Only function definitions move.",
|
|
"For any script that cannot be stub-run (setup_periodic_system.sh asks for root at source time), verification is: the source line precedes the first top-level call, and every invoked function is defined exactly once across the entry script and its lib.",
|
|
"No script is executed. Both install systemd units and one requires root.",
|
|
"clean_audio.sh is fully reverted, leaving no partial split and no new lib directory behind, and remains over the cap with the reason recorded."
|
|
],
|
|
"out_of_scope": [
|
|
"Executing any installer or enforcement step.",
|
|
"Untangling clean_audio.sh's cross-file globals, which is a refactor rather than a line-count split.",
|
|
"Changing what any script does when run."
|
|
],
|
|
"verifier": "scratchpad/verify_split.sh for control_from_mobile.sh; for setup_periodic_system.sh, bash -n + shellcheck -x plus grep proving source-before-call and one definition per invoked function; plus pre-commit run --files and the real git commit for jscpd."
|
|
}
|