mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-22 14:12:29 +01:00
Some checks are pending
md-naming / markdown naming convention (push) Waiting to run
Pre-commit checks / pre-commit (${{ matrix.group }}) (mypy, mypy) (push) Waiting to run
Pre-commit checks / pre-commit (${{ matrix.group }}) (pylint, pylint) (push) Waiting to run
Pre-commit checks / pre-commit (${{ matrix.group }}) (rest, ) (push) Waiting to run
Pre-commit checks / pre-commit (${{ matrix.group }}) (shellcheck, shellcheck) (push) Waiting to run
Python tests / test (push) Waiting to run
repo-contract / repo contract (push) Waiting to run
Shell tests / shell-tests (push) Waiting to run
Shell tests / lib-tests (push) Waiting to run
Shell tests / arch-tests (push) Waiting to run
phone_deploy.sh runs python_pkg.phone_lease with whatever python3 is
first on PATH. e9ba82ed made it import kuhy_credit at module load, so
from a venv without kuhy-credit every phone deploy died with
ModuleNotFoundError. Both phone CLIs now take the epilog from
help_epilog(), which returns None when the package is missing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
33 lines
1.3 KiB
JSON
33 lines
1.3 KiB
JSON
{
|
|
"intent": "phone_lease and android_ui CLIs run under any python3, even one without kuhy-credit, so phone_deploy.sh works from any venv.",
|
|
"scope": [
|
|
"python_pkg/_optional_credit.py",
|
|
"python_pkg/phone_lease/__main__.py",
|
|
"python_pkg/android_ui/cli.py",
|
|
"python_pkg/phone_lease/tests/test_optional_credit.py"
|
|
],
|
|
"changes": [
|
|
"New help_epilog() imports kuhy_credit lazily and returns None when it is missing.",
|
|
"phone_lease and android_ui take their argparse epilog from help_epilog() instead of a top-level kuhy_credit import."
|
|
],
|
|
"verification": [
|
|
{
|
|
"command": "pytest python_pkg/phone_lease/tests/test_optional_credit.py python_pkg/tests/test_cli_credit.py -k 'phone_lease or android_ui'",
|
|
"result": "pass",
|
|
"evidence": "2 failed before the change (ModuleNotFoundError: kuhy_credit); 5 passed after."
|
|
},
|
|
{
|
|
"command": "/home/kuhy/src/todoImplementer/.venv/bin/python3 -m python_pkg.phone_lease status",
|
|
"result": "pass",
|
|
"evidence": "Printed the lease table instead of ModuleNotFoundError."
|
|
}
|
|
],
|
|
"risks": [
|
|
"With kuhy-credit absent the two CLIs show --help without the credit line."
|
|
],
|
|
"rollback": [
|
|
"git revert the commit",
|
|
"Then run phone_deploy.sh from a venv that has kuhy-credit installed."
|
|
]
|
|
}
|