mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-12 22:50:52 +01:00
Krzysztof kuhy Rudnicki
a5b6663c02
Fourth of the 16 untested fixes/lib libs, the largest at 214 lines, and the
last of the bluetooth family. 47 assertions across three files. The lib
STAYS on the allowlist: 128/132 = 96.97%, twice with the same line set.
The bug the tests found, fixed here. Line 21 read:
if timeout 3 _run_as_user wpctl status &>/dev/null; then
`timeout` is a binary and `_run_as_user` is a shell function that is never
exported, so this always failed with rc=127 -- "timeout: failed to run
command '_run_as_user'". check_pipewire_health therefore reported PipeWire
hung on EVERY run and restarted a healthy audio stack every time
fix_bluetooth.sh ran. The healthy branch was unreachable, which is why the
test for it could not be written without first noticing. Now
`_run_as_user timeout 3 wpctl status`: same bound, inside the sudo'd command.
Why 96.97% and not 100%. An earlier run of this suite read 99/99 = 100.00%,
and that number was wrong -- it measured the file before pre-commit's
`shfmt -w` reformatted it. shfmt rewrites the `{ ...; } \` + `| bluetoothctl`
one-liners into multi-line blocks ending in `} |`, which raises the
denominator 99 -> 132. Confirmed unavoidable by running shfmt against HEAD's
own copy: it rewrites there too, so reverting the reformat is not stable.
The four uncovered lines (90, 113, 137, 157) are each that `} |` -- the pipe
operator joining a block to bluetoothctl, not a statement. They do execute:
a `{ echo a; echo b; } | consumer` block writes every marker to a file even
though bash's xtrace never reports the left-hand side, because a pipe's LHS
runs in a subshell whose xtrace is not captured. kcov instruments them and
cannot attribute them; defect (a) in docs/kcov-under-report.md, third flavour.
Scope, measured: the continuation-pipe form appears ONLY in bt_adapter.sh
(pre-format) and bt_audio.sh (post-shfmt). None of the remaining twelve
untested libs carries either, so this does not block the campaign and the
detector fix stays off the critical path.
Also worth 90.91% -> 96.97% on its own: the bluetoothctl stubs now drain
stdin before exiting. Real bluetoothctl consumes its whole input; a stub
that read one line and exited closed the pipe early, so the writing block
took SIGPIPE partway through and its later lines never ran.
NOTE for whoever edits this file next: bt_audio.sh is now exactly 250 lines,
at the cap. The next change to it needs a split, not a comment trim.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| tests | ||
| arch_cpu.sh | ||
| arch_hardware.sh | ||
| arch_perf_fixes.sh | ||
| arch_perf_probes.sh | ||
| arch_perf_report.sh | ||
| arch_sysctl.sh | ||
| bt_adapter.sh | ||
| bt_audio.sh | ||
| bt_pairing.sh | ||
| bt_report.sh | ||
| hosts_guard_migrate.sh | ||
| hosts_guard_rollback.sh | ||
| nvidia_config.sh | ||
| pacman_hook_stall_capture.sh | ||
| pacman_hook_stall_load.sh | ||
| pacman_hook_stall_setup.sh | ||
| pacman_hook_stall_summary.sh | ||
| pacman_hook_stall_usage.sh | ||
| pacman_hook_stall_watch.sh | ||
| thorium_repairs.sh | ||
| ubuntu_perf_fixes.sh | ||
| ubuntu_perf_more.sh | ||