mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-13 09:10:48 +01:00
Krzysztof kuhy Rudnicki
a84556ac2a
428 lines -> 121, with lib/shell_check_lint.sh (171), lib/shell_check_install.sh (86) and lib/shell_check_discover.sh (78). The temp-file paths (TMPDIR, ABS_FILES_Z, REL_FILES_Z) are set once in the entry before any lib is sourced and only read afterwards, so nothing mutable crosses a seam. shellcheck was clean on the first attempt. Runtime check is --skip-install --list-only --verbose, diffed against the same run from a detached worktree at HEAD: 318 files before, 321 now, the delta being exactly the three new libs the discovery walk now sees. Nothing removed. Not verified: the linting path itself. --skip-install does not gate the AUR branch of install_linters, so a full run cannot be done under decision 6 -- I learned that by running it, which installed four AUR build deps before I killed it. The user chose to leave them. run_linters moved as one intact block with no interior edit and the line-set diff shows zero lines lost, so the seam risk is confined to its two braces. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011w2Pj4Ek3ZNMQVYcFHgXDY
87 lines
2.6 KiB
Bash
Executable File
87 lines
2.6 KiB
Bash
Executable File
#!/bin/bash
|
|
# Linter installation: command probes, Arch/AUR detection, and the pacman /
|
|
# AUR-helper dispatch for shellcheck, shfmt, checkbashisms and bashate.
|
|
#
|
|
# Sourced by shell_check.sh; split out to keep it under the 250-line cap.
|
|
# Sourced rather than run, so it inherits the caller's options and reads
|
|
# SKIP_INSTALL and VERBOSE, which the entry sets from its arguments above the
|
|
# source line.
|
|
|
|
is_cmd() { command -v "$1" > /dev/null 2>&1; }
|
|
|
|
is_arch() { is_cmd pacman; }
|
|
have_aur_helper() { is_cmd yay || is_cmd paru; }
|
|
|
|
install_if_missing() {
|
|
local pkg cmd
|
|
pkg="$1"
|
|
cmd="$2"
|
|
if is_cmd "$cmd"; then
|
|
[[ $VERBOSE == "true" ]] && log_info "Found $cmd"
|
|
return 0
|
|
fi
|
|
|
|
if [[ $SKIP_INSTALL == "true" ]]; then
|
|
log_warn "Skipping install of $pkg ($cmd not found)"
|
|
return 1
|
|
fi
|
|
|
|
if is_arch; then
|
|
log_info "Installing $pkg via pacman..."
|
|
if ! sudo pacman -S --needed --noconfirm "$pkg"; then
|
|
log_warn "Failed to install $pkg via pacman."
|
|
return 1
|
|
fi
|
|
return 0
|
|
else
|
|
log_warn "Non-Arch system detected. Please install '$pkg' manually."
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
install_linters() {
|
|
local ok=0
|
|
|
|
# Core linters
|
|
install_if_missing shellcheck shellcheck || ok=1
|
|
install_if_missing shfmt shfmt || ok=1
|
|
|
|
# Optional linters (best-effort)
|
|
# checkbashisms may be in repos or AUR; try pacman first, then AUR helper
|
|
if ! is_cmd checkbashisms; then
|
|
if is_arch; then
|
|
if ! sudo pacman -S --needed --noconfirm checkbashisms 2> /dev/null; then
|
|
if have_aur_helper; then
|
|
log_info "Installing checkbashisms from AUR (requires yay/paru)..."
|
|
if is_cmd yay; then yay -S --noconfirm checkbashisms || true; fi
|
|
if is_cmd paru; then paru -S --noconfirm checkbashisms || true; fi
|
|
else
|
|
log_warn "checkbashisms not installed (no AUR helper)."
|
|
fi
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
# bashate (python-based), typically available as python-bashate in AUR
|
|
if ! is_cmd bashate; then
|
|
if is_arch && have_aur_helper; then
|
|
log_info "Installing bashate from AUR (requires yay/paru)..."
|
|
if is_cmd yay; then yay -S --noconfirm python-bashate || true; fi
|
|
if is_cmd paru; then paru -S --noconfirm python-bashate || true; fi
|
|
else
|
|
# Try pip if user has it and wants to
|
|
if is_cmd pipx; then
|
|
log_info "Installing bashate via pipx..."
|
|
pipx install bashate || true
|
|
elif is_cmd pip3; then
|
|
log_info "Installing bashate via pip (user)..."
|
|
pip3 install --user bashate || true
|
|
else
|
|
log_warn "bashate not installed (no AUR helper or pip available)."
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
return "$ok"
|
|
}
|