mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-11-11 14:27:49 +01:00
Krzysztof kuhy Rudnicki
d255288e06
Some checks are pending
dependency freshness / dependencies on newest stable (push) Waiting to run
md-naming / markdown naming convention (push) Waiting to run
Pre-commit checks / pre-commit (push) Waiting to run
Shell tests / shell-tests (push) Waiting to run
Shell tests / arch-tests (push) Waiting to run
The guard prints `CI_GREEN_SKIP=1 git commit ...` and stops there, but it runs at two stages: at commit, and again inside the pre-push CI mirror's clean-worktree `pre-commit` run, which sees the same still-red baseline. So the documented escape gets you past the commit and into an identical wall at push, with no hint and nothing in the output connecting the two. Hit today landing the pre-commit cache-key fix: the commit went through, the push did not. The variable is read from the environment and `ci_mirror.sh` does not scrub it, so `CI_GREEN_SKIP=1 git push` carries through to the nested run -- which is now what the message says. Verified both paths: with the variable set the script warns and exits 0, and against today's green main it exits 0 silently. shellcheck clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfnJmxxsZ534AKk16rC2Gr
37 lines
1.8 KiB
JSON
37 lines
1.8 KiB
JSON
{
|
|
"intent": "Make the CI-baseline guard's own error message tell the whole truth: the fix-forward escape hatch has to be given at commit AND at push, because the hook runs at both stages.",
|
|
"scope": [
|
|
"meta/scripts/check_ci_green.sh: the header comment and the failure hint",
|
|
"Non-goal: changing when the guard fires, what it checks, or the semantics of CI_GREEN_SKIP"
|
|
],
|
|
"changes": [
|
|
"Header comment now documents both invocations and why the second is needed (the pre-push CI mirror re-runs pre-commit in a clean worktree against the same still-red baseline)",
|
|
"Failure hint now prints `CI_GREEN_SKIP=1 git push` beneath the commit form, plus one line naming the mirror as the reason"
|
|
],
|
|
"verification": [
|
|
{
|
|
"command": "shellcheck meta/scripts/check_ci_green.sh",
|
|
"result": "pass",
|
|
"evidence": "shellcheck OK (no output)"
|
|
},
|
|
{
|
|
"command": "CI_GREEN_SKIP=1 bash meta/scripts/check_ci_green.sh",
|
|
"result": "pass",
|
|
"evidence": "check_ci_green.sh: CI_GREEN_SKIP is set / skipping the CI-baseline check (pre-push ci-mirror is the real gate). exit 0"
|
|
},
|
|
{
|
|
"command": "bash meta/scripts/check_ci_green.sh",
|
|
"result": "pass",
|
|
"evidence": "silent, exit 0, against a main that is green as of 6eb70de0"
|
|
}
|
|
],
|
|
"risks": [
|
|
"The red path's exact wording is not covered by a test; there is no test file for this script in the repo, so a future edit could break the hint without failing anything.",
|
|
"If ci_mirror.sh ever starts scrubbing the environment, the documented push form stops working and this message becomes wrong."
|
|
],
|
|
"rollback": [
|
|
"git revert the commit; the change is comment and printf text only, so nothing depends on it.",
|
|
"After rollback, confirm the guard still exits 0 on a green main and 1 on a red one."
|
|
]
|
|
}
|